JobApplicationAnswerController::update() - Code Metrics - Inspection of "Refactor Fit step data fetching in same style as p..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — task/refactor-application-data... ( 30e714...e7ce5c )

by Tristan

created 2020-09-23 16:15 UTC

JobApplicationAnswerController::update() A

↳ Parent: JobApplicationAnswerController

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	5
c	1
b	0
f	0
dl	0
loc	12
rs	10
cc	1
nc	1
nop	2

<?php

namespace App\Http\Controllers\Api;

use App\Http\Controllers\Controller;
use App\Http\Requests\StoreJobApplicationAnswer;
use App\Models\JobApplicationAnswer;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\JsonResource;

class JobApplicationAnswerController extends Controller
{

    public function store(StoreJobApplicationAnswer $request)
    {
        // Validate job application answer.
        $data = $request->validated();
        // Create new object with data and save to db.
        $jobApplicationAnswer = new JobApplicationAnswer($data);
        $jobApplicationAnswer->job_poster_question_id = $data['job_poster_question_id'];
        $jobApplicationAnswer->job_application_id = $data['job_application_id'];
        $jobApplicationAnswer->answer = $data['answer'];
        $jobApplicationAnswer->save();

        return new JsonResource($jobApplicationAnswer->fresh());
    }

    public function update(Request $request, JobApplicationAnswer $jobApplicationAnswer)
    {
        // Validate job application answer.
        $validatedData = $request->validate([
          'answer' => 'required|nullable|string',
        ]);

        // Update existing object with data and save to db.
        $jobApplicationAnswer->fill($validatedData);
        $jobApplicationAnswer->save();

        return new JsonResource($jobApplicationAnswer->fresh());
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Api;
4
5			use App\Http\Controllers\Controller;
6			use App\Http\Requests\StoreJobApplicationAnswer;
7			use App\Models\JobApplicationAnswer;
8			use Illuminate\Http\Request;
9			use Illuminate\Http\Resources\Json\JsonResource;
10
11			class JobApplicationAnswerController extends Controller
12			{
13
14			public function store(StoreJobApplicationAnswer $request)
15			{
16			// Validate job application answer.
17			$data = $request->validated();
18			// Create new object with data and save to db.
19			$jobApplicationAnswer = new JobApplicationAnswer($data);
20			$jobApplicationAnswer->job_poster_question_id = $data['job_poster_question_id'];
21			$jobApplicationAnswer->job_application_id = $data['job_application_id'];
22			$jobApplicationAnswer->answer = $data['answer'];
23			$jobApplicationAnswer->save();
24
25			return new JsonResource($jobApplicationAnswer->fresh());
26			}
27
28			public function update(Request $request, JobApplicationAnswer $jobApplicationAnswer)
29			{
30			// Validate job application answer.
31			$validatedData = $request->validate([
32			'answer' => 'required\|nullable\|string',
33			]);
34
35			// Update existing object with data and save to db.
36			$jobApplicationAnswer->fill($validatedData);
37			$jobApplicationAnswer->save();
38
39			return new JsonResource($jobApplicationAnswer->fresh());
40			}
41			}
42

GCTC-NTGC / TalentCloud

Push — task/refactor-application-data... ( 30e714...e7ce5c )

JobApplicationAnswerController::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like