App\Http\Controllers\SkillsController::updateAll()

Complexity

Conditions	14
Paths	12

Size

Total Lines	74
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	210

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	SkillsController::update()	0	5	1
A	SkillsController::updateSkillDeclaration()	0	34	2

<?php

Missing file doc comment

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Log;
use Illuminate\Http\Request;
use App\Models\Skill;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\SkillStatus;
use App\Models\SkillDeclaration;
use App\Models\Applicant;
use App\Http\Controllers\Controller;
use App\Services\Validation\BulkSkillDeclarationValidator;
use App\Services\Validation\SkillDeclarationValidator;

class SkillsController extends Controller

Missing doc comment for class SkillsController

{

    /**
     * Display the Skills page associated with the applicant.
     *
     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function show(Applicant $applicant)

The parameter $applicant is not used and could be removed.

    {
        //

    }

    /**
     * Show the form for editing the applicant's skills
     *
     * @param  Request  $request

Missing parameter comment

Expected 15 spaces after parameter type; 2 found

     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function edit(Request $request, Applicant $applicant)
    {
        $skills = Skill::all();

        return view('applicant/profile_03_skills', [

The opening parenthesis of a multi-line function call should be the last content on the line.

The expression return view('applicant/profile_03_skills', array('applicant' => $applicant, 'profile' => Illuminate\Support\Facades\Lang::get('applicant/profile_skills'), 'skills' => $skills)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_skills'),
            'skills' => $skills
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Create the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function create(Request $request)
    {
        $this->authorize('create', SkillDeclaration::class);

        $user = $request->user();
        $applicant = $user->applicant;

        //Get the default claim status id
        $claimedStatusId = SkillStatus::where('name', 'claimed')->firstOrFail()->id;

        // Create a new Skill Declaration
        // But don't save, as it hasn't been validated yet
        $skillDeclaration = new SkillDeclaration();
        $skillDeclaration->applicant_id = $applicant->id;
        $skillDeclaration->skill_id = $request->input('skill_id');
        $skillDeclaration->skill_status_id = $claimedStatusId;

        //Update variable fields in skill declaration
        return $this->updateSkillDeclaration($request, $skillDeclaration);

The expression return $this->updateSkillDeclaration($request, $skillDeclaration) returns the type Illuminate\Http\RedirectResponse|string which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 5 spaces after parameter type; 2 found

     * @param  \App\Models\SkillDeclaration  $skillDeclaration

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function update(Request $request, SkillDeclaration $skillDeclaration)
    {
        $this->authorize('update', $skillDeclaration);

        return $this->updateSkillDeclaration($request, $skillDeclaration);

The expression return $this->updateSkillDeclaration($request, $skillDeclaration) returns the type Illuminate\Http\RedirectResponse|string which is incompatible with the documented return type Illuminate\Http\Response.

    }

    protected function updateSkillDeclaration(Request $request, SkillDeclaration $skillDeclaration)

Missing doc comment for function updateSkillDeclaration()

    {
        //Fill variable values
        $skillDeclaration->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'description' => $request->input('description'),
            'skill_level_id' => $request->input('skill_level_id'),
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        //Validate before saving
        $validator = new SkillDeclarationValidator($request->user()->applicant);
        $validator->validate($skillDeclaration);

        //Save this skill declaration
        $skillDeclaration->save();

        //Attach relatives
        $referenceIds = $this->getRelativeIds($request->input(), 'references');
        $skillDeclaration->references()->sync($referenceIds);

        $sampleIds = $this->getRelativeIds($request->input(), 'samples');
        $skillDeclaration->work_samples()->sync($sampleIds);

        $skillDeclaration->save();

        // If an ajax request, return the new object
        if($request->ajax()) {

Expected "if (...) {\n"; found "if(...) {\n"

            $skillDeclaration->load('references');
            $skillDeclaration->load('work_samples');
            $skillDeclaration->load('skill');
            $skillDeclaration->load('skill_status');
            return $skillDeclaration->toJson();
        }

        return redirect()->back();
    }

    /**
     * Delete the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 5 spaces after parameter type; 2 found

     * @param  \App\Models\SkillDeclaration  $skillDeclaration

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function destroy(Request $request, SkillDeclaration $skillDeclaration)
    {
        $this->authorize('delete', $skillDeclaration);
        $skillDeclaration->delete();

        if($request->ajax()) {

Expected "if (...) {\n"; found "if(...) {\n"

            return ['message' => 'Skill deleted'];

The expression return array('message' => 'Skill deleted') returns the type array<string,string> which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

}