JobPosterStatusTransitionCrudController::setup() - Code Metrics - Inspection of "Allow client to use Job Status language from api" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job-status-transitions ( 5d9982...db421e )

by Tristan

created 2020-02-27 22:46 UTC

JobPosterStatusTransitionCrudController::setup() A

↳ Parent: JobPosterStatusTransitionCrudController

Complexity

Conditions	1
Paths	1

Size

Total Lines	59
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	43
c	1
b	0
f	0
dl	0
loc	59
rs	9.232
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace App\Http\Controllers\Admin;

use Backpack\CRUD\app\Http\Controllers\CrudController;
use Illuminate\Support\Facades\App;

class JobPosterStatusTransitionCrudController extends CrudController
{
    use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;
    use \Backpack\CRUD\app\Http\Controllers\Operations\DeleteOperation;

    /**
     * Prepare the admin interface by setting the associated
     * model, setting the route, and adding custom columns/fields.
     *
     * @return void
     */
    public function setup(): void
    {
        // Eloquent model to associate with this collection of views and controller actions.
        $this->crud->setModel('App\Models\Lookup\JobPosterStatusTransition');
        // Custom backpack route.
        $this->crud->setRoute('admin/job-poster-status-transition');
        // Custom strings to display within the backpack UI.
        $this->crud->setEntityNameStrings('job status transition', 'job status transitions');

        $this->crud->operation(['create', 'update'], function () {
            $this->crud->addField([
                'name' => 'key',
                'type' => 'text',
                'label' => 'Key',
            ]);

            $this->crud->addField([
                'name' => 'name',
                'type' => 'text',
                'label' => 'Name',
                'limit' => 120,
            ]);

            $this->crud->addField([  // Select
                'label' => 'Owner User Role',
                'type' => 'select',
                'name' => 'owner_user_role_id', // the db column for the foreign key
                'entity' => 'owner_user_role', // the method that defines the relationship in your Model
                'attribute' => 'key', // foreign key attribute that is shown to user
                'model' => \App\Models\UserRole::class, // foreign key model
            ]);

            $this->crud->addField([  // Select
                'label' => 'From Status',
                'type' => 'select',
                'name' => 'from_job_poster_status_id', // the db column for the foreign key
                'entity' => 'from', // the method that defines the relationship in your Model
                'attribute' => 'key', // foreign key attribute that is shown to user
                'model' => \App\Models\Lookup\JobPosterStatus::class, // foreign key model
            ]);

            $this->crud->addField([  // Select
                'label' => 'To Status',
                'type' => 'select',
                'name' => 'to_job_poster_status_id', // the db column for the foreign key
                'entity' => 'to', // the method that defines the relationship in your Model
                'attribute' => 'key', // foreign key attribute that is shown to user
                'model' => \App\Models\Lookup\JobPosterStatus::class, // foreign key model
            ]);

            $this->crud->addField([
                'name' => 'button_style',
                'label' => 'Button Style',
                'type' => 'select_from_array',
                'options' => ['default' => 'default', 'stop' => 'stop', 'go' => 'go'],
                'allows_null' => false,
                'default' => 'default',
                'fake' => true, // show the field, but don’t store it in the database column above
                'store_in' => 'metadata' // [optional] the database column name where you want the fake fields to ACTUALLY be stored as a JSON array
            ]);
        });
    }

    public function setupListOperation()
    {
        // Required for order logic.
        $locale = 'en';
        if (null !== $this->request->input('locale')) {
            $locale = $this->request->input('locale');
        }
        App::setLocale($locale);

        // Add custom columns to the Department index view.
        $this->crud->addColumn([
            'name' => 'id',
            'type' => 'text',
            'label' => 'ID',
            'orderable' => true,
        ]);

        $this->crud->addColumn([
            'name' => 'name',
            'type' => 'text',
            'label' => 'Name',
            'orderable' => true,
            'limit' => 70,
            'orderLogic' => function ($query, $column, $columnDirection) use ($locale) {
                return $query->orderBy('name->' . $locale, $columnDirection)->select('*');
            }
        ]);

        $this->crud->addColumn([
            'name' => 'from.key',
            'type' => 'text',
            'label' => 'From status',
            'orderable' => false,
        ]);

        $this->crud->addColumn([
            'name' => 'to.key',
            'type' => 'text',
            'label' => 'To status',
            'orderable' => false,
        ]);

        $this->crud->addColumn([
            'name' => 'owner_user_role.key',
            'type' => 'text',
            'label' => 'Onwer User Role',
            'orderable' => false,
        ]);
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Admin;
4
5			use Backpack\CRUD\app\Http\Controllers\CrudController;
6			use Illuminate\Support\Facades\App;
7
8			class JobPosterStatusTransitionCrudController extends CrudController
9			{
10			use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
11			use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
12			use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;
13			use \Backpack\CRUD\app\Http\Controllers\Operations\DeleteOperation;
14
15			/**
16			* Prepare the admin interface by setting the associated
17			* model, setting the route, and adding custom columns/fields.
18			*
19			* @return void
20			*/
21			public function setup(): void
22			{
23			// Eloquent model to associate with this collection of views and controller actions.
24			$this->crud->setModel('App\Models\Lookup\JobPosterStatusTransition');
25			// Custom backpack route.
26			$this->crud->setRoute('admin/job-poster-status-transition');
27			// Custom strings to display within the backpack UI.
28			$this->crud->setEntityNameStrings('job status transition', 'job status transitions');
29
30			$this->crud->operation(['create', 'update'], function () {
31			$this->crud->addField([
32			'name' => 'key',
33			'type' => 'text',
34			'label' => 'Key',
35			]);
36
37			$this->crud->addField([
38			'name' => 'name',
39			'type' => 'text',
40			'label' => 'Name',
41			'limit' => 120,
42			]);
43
44			$this->crud->addField([ // Select
45			'label' => 'Owner User Role',
46			'type' => 'select',
47			'name' => 'owner_user_role_id', // the db column for the foreign key
48			'entity' => 'owner_user_role', // the method that defines the relationship in your Model
49			'attribute' => 'key', // foreign key attribute that is shown to user
50			'model' => \App\Models\UserRole::class, // foreign key model
51			]);
52
53			$this->crud->addField([ // Select
54			'label' => 'From Status',
55			'type' => 'select',
56			'name' => 'from_job_poster_status_id', // the db column for the foreign key
57			'entity' => 'from', // the method that defines the relationship in your Model
58			'attribute' => 'key', // foreign key attribute that is shown to user
59			'model' => \App\Models\Lookup\JobPosterStatus::class, // foreign key model
60			]);
61
62			$this->crud->addField([ // Select
63			'label' => 'To Status',
64			'type' => 'select',
65			'name' => 'to_job_poster_status_id', // the db column for the foreign key
66			'entity' => 'to', // the method that defines the relationship in your Model
67			'attribute' => 'key', // foreign key attribute that is shown to user
68			'model' => \App\Models\Lookup\JobPosterStatus::class, // foreign key model
69			]);
70
71			$this->crud->addField([
72			'name' => 'button_style',
73			'label' => 'Button Style',
74			'type' => 'select_from_array',
75			'options' => ['default' => 'default', 'stop' => 'stop', 'go' => 'go'],
76			'allows_null' => false,
77			'default' => 'default',
78			'fake' => true, // show the field, but don’t store it in the database column above
79			'store_in' => 'metadata' // [optional] the database column name where you want the fake fields to ACTUALLY be stored as a JSON array
80			]);
81			});
82			}
83
84			public function setupListOperation()
85			{
86			// Required for order logic.
87			$locale = 'en';
88			if (null !== $this->request->input('locale')) {
89			$locale = $this->request->input('locale');
90			}
91			App::setLocale($locale);
92
93			// Add custom columns to the Department index view.
94			$this->crud->addColumn([
95			'name' => 'id',
96			'type' => 'text',
97			'label' => 'ID',
98			'orderable' => true,
99			]);
100
101			$this->crud->addColumn([
102			'name' => 'name',
103			'type' => 'text',
104			'label' => 'Name',
105			'orderable' => true,
106			'limit' => 70,
107			'orderLogic' => function ($query, $column, $columnDirection) use ($locale) {
108			return $query->orderBy('name->' . $locale, $columnDirection)->select('*');
109			}
110			]);
111
112			$this->crud->addColumn([
113			'name' => 'from.key',
114			'type' => 'text',
115			'label' => 'From status',
116			'orderable' => false,
117			]);
118
119			$this->crud->addColumn([
120			'name' => 'to.key',
121			'type' => 'text',
122			'label' => 'To status',
123			'orderable' => false,
124			]);
125
126			$this->crud->addColumn([
127			'name' => 'owner_user_role.key',
128			'type' => 'text',
129			'label' => 'Onwer User Role',
130			'orderable' => false,
131			]);
132			}
133			}
134

GCTC-NTGC / TalentCloud

Push — feature/job-status-transitions ( 5d9982...db421e )

JobPosterStatusTransitionCrudController::setup() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like