GCTC-NTGC /
TalentCloud
| Conditions | 9 |
| Paths | 4 |
| Total Lines | 55 |
| Code Lines | 33 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 17 | public function show(JobApplication $jobApplication, string $requestedStep = null) |
||
| 18 | { |
||
| 19 | $jobApplicationSteps = $jobApplication->jobApplicationSteps(); |
||
| 20 | $stepOrder = [ |
||
| 21 | 'basic', |
||
| 22 | 'experience', |
||
| 23 | 'skills', |
||
| 24 | 'fit', |
||
| 25 | 'review', |
||
| 26 | 'submission' |
||
| 27 | ]; |
||
| 28 | |||
| 29 | $lastTouchedStep = function () use ($stepOrder, $jobApplicationSteps) { |
||
| 30 | $reversedStepOrder = array_reverse($stepOrder); |
||
| 31 | foreach ($reversedStepOrder as $step) { |
||
| 32 | if ($jobApplicationSteps[$step] === 'complete' || |
||
| 33 | $jobApplicationSteps[$step] === 'error' |
||
| 34 | ) { |
||
| 35 | return $step; |
||
| 36 | } |
||
| 37 | } |
||
| 38 | |||
| 39 | return 'welcome'; |
||
| 40 | }; |
||
| 41 | |||
| 42 | if ($requestedStep === 'welcome') { |
||
| 43 | return view('applicant/application-timeline-root') |
||
|
Bug
introduced
by
|
|||
| 44 | ->with([ |
||
| 45 | 'title' => $jobApplication->job_poster->title, // TODO: Check with design what the title should be. |
||
| 46 | 'disable_clone_js' => true, |
||
| 47 | ]); |
||
| 48 | } |
||
| 49 | |||
| 50 | if ($requestedStep !== null) { |
||
| 51 | // Show the requested step if it has been touched before. |
||
| 52 | // Else, redirect the user to the last touched step. |
||
| 53 | // If no step has been touched, then take them to welcome step. |
||
| 54 | if (array_key_exists($requestedStep, $jobApplicationSteps) && |
||
| 55 | ($jobApplicationSteps[$requestedStep] === 'complete' || $jobApplicationSteps[$requestedStep] === 'error') |
||
| 56 | ) { |
||
| 57 | return view('applicant/application-timeline-root') |
||
| 58 | ->with([ |
||
| 59 | 'title' => $jobApplication->job_poster->title, // TODO: Check with design what the title should be. |
||
| 60 | 'disable_clone_js' => true, |
||
| 61 | ]); |
||
| 62 | } else { |
||
| 63 | return redirect( |
||
| 64 | route('applications.timeline.step', ['jobApplication' => $jobApplication, 'step' => $lastTouchedStep()]) |
||
| 65 | ); |
||
| 66 | } |
||
| 67 | } else { |
||
| 68 | // If no step has been entered (/application/id) then redirect user to the last touched step. |
||
| 69 | // If no step has been touched, then take them to welcome step. |
||
| 70 | return redirect( |
||
| 71 | route('applications.timeline.step', ['jobApplication' => $jobApplication, 'step' => $lastTouchedStep()]) |
||
| 72 | ); |
||
| 102 |
Loading history...
