SkillDeclarationAPI.populateApplicationUiSkillDeclarations - Code Metrics - Inspection of "Merge pull request #236 from GCTC-NTGC/forms_appli..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 401bbc...02c732 )

by Grant

created 2018-06-27 17:24 UTC

SkillDeclarationAPI.populateApplicationUiSkillDeclarations C

↳ Parent: Project

Complexity

Conditions	9
Paths	38

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
nc	38
nop	1
dl	0
loc	1
rs	6.6666
c	0
b	0
f	0

var SkillDeclarationAPI = {};

SkillDeclarationAPI.wrapperClass = "applicant-evidence__skill-attribute--required";

SkillDeclarationAPI.SkillDeclaration = function (criteriaId) {
        this.criteria_id = criteriaId;
        this.skill_declaration_id = null;
        this.skill = null;
        this.criteria_type = null;
        this.experience_level_id = null;
        this.skill_level_id = null;
        this.description = null;
        this.last_updated = null;

        /**
        * This is valid if experience_level_id, skill_level_id, and description
        * are not empty.
        *
        * @return {Boolean}
        */
        this.isComplete = function () {
            return (this.skill_level_id && this.experience_level_id && this.description );
        };
        
         /**
        * Return true if this object is ready to be saved to server
        * @return {Boolean}
        */
        this.isValid = function () {
            return this.criteria_id != false;

        };
        
        this.isEmpty = function () {
            return (this.skill_level_id == false && this.experience_level_id == false && this.description == false);

        };
        
        this.nullifyEmptyFields = function() {
            this.skill_level_id = this.skill_level_id ? this.skill_level_id : null;
            this.experience_level_id = this.experience_level_id ? this.experience_level_id : null;
            this.description = this.description ? this.description : null;
        };
    };

    SkillDeclarationAPI.loadSavedSkillDeclarationsForJobApplication = function (jobApplicationId) {
        DataAPI.getSkillDeclarationsForApplication(jobApplicationId, function (request) {

            //Check that request returned a valid response
            if (request.status === 200 && request.response) {
                var responseJson = JSON.parse(request.response);
                var declarations = [];
                for (var i = 0; i < responseJson.length; i++) {
                    var response = responseJson[i];
                    var declaration = new SkillDeclarationAPI.SkillDeclaration(response.criteria_id);
                    declaration.skill_declaration_id = response.skill_declaration_id;
                    declaration.skill = response.skill;
                    declaration.criteria_type = response.criteria_type;
                    declaration.experience_level_id = response.experience_level_id;
                    declaration.skill_level_id = response.skill_level_id;
                    declaration.description = response.description;
                    declaration.last_updated = response.last_updated;
                    
                    declarations.push(declaration);
                }
                
                SkillDeclarationAPI.populateApplicationUiSkillDeclarations(declarations);
            }
        });
    };

    SkillDeclarationAPI.populateApplicationUiSkillDeclarations = function (skillDeclarations) {
        for (var i=0; i<skillDeclarations.length; i++) {
            var declaration = skillDeclarations[i];
            //find appropriate Evidence Panel
            var panel = document.querySelector('.applicant-evidence__skill[data-criteria-id="' + declaration.criteria_id + '"][data-criteria-type="' + declaration.criteria_type + '"]');
            //if panel exists, set skill declaration values
            if (panel) {
                if (declaration.experience_level_id) {
                    var experienceSelect = panel.querySelector('input[type="radio"][name="experience"][value="' + declaration.experience_level_id + '"]');
                    if (experienceSelect) {
                        experienceSelect.checked = true;
                    }
                }
                if (declaration.skill_level_id) {
                    var skillLevelSelect = panel.querySelector('input[type="radio"][name="expertise"][value="' + declaration.skill_level_id + '"]');
                    if (skillLevelSelect) {
                        skillLevelSelect.checked = true;
                    }
                }

                var description = panel.querySelector('.applicant-evidence__skill-declaration-text');
                if (description) {
                    description.value = declaration.description;
                }

                //Run status change handler, because declartion may now be complete
                SkillDeclarationAPI.onStatusChange(declaration.criteria_id);
                
                //If not empty, show status as currently saved
                if (!declaration.isEmpty()) {
                    EvidenceAPI.setUiSaved(declaration.criteria_id, SkillDeclarationAPI, true);

                }
            }
        }
    };

    SkillDeclarationAPI.populateApplicationPreviewUiSkillDeclarations = function(skillDeclarations) {
        for (var i=0; i<skillDeclarations.length; i++) {
            var declaration = skillDeclarations[i];
            //find appropriate Evidence Panel
            var panel = document.querySelector('.applicant-evidence-preview__accordion-wrapper[data-criteria-id="' + declaration.criteria_id + '"]');
            //if panel exists, set skill declaration values
            if (panel) {
                var experience = panel.querySelector('.applicant-evidence-preview__experience');
                if (declaration.experience_level_id) {
                    experience.innerHTML = LookupAPI.getLocalizedLookupValue("experience_level", declaration.experience_level_id) + " Years";

                } else {
                    experience.innerHTML = null;
                }
                var skillLevel = panel.querySelector('.applicant-evidence-preview__expertise');
                if (declaration.skill_level_id) {
                    skillLevel.innerHTML = LookupAPI.getLocalizedLookupValue("skill_level", declaration.skill_level_id);
                } else {
                    skillLevel.innerHTML = null;
                }

                var description = panel.querySelector('.applicant-evidence-preview__experience-copy');
                if (declaration.description) {
                    description.innerHTML = declaration.description;
                } else {
                    description.innerHTML = null;
                }
            }
        }
    };

    /**
    * Saves all completed skill declarations of given type.
    * If criteriaType is undefined, it saves ALL completed skill declarations.
    *
    * Call onSuccess if application is saved successfully
    *
    * @param {string} criteriaType
    * @param {function} onSuccess
    * @return {undefined}
    */
    SkillDeclarationAPI.saveSkillDeclarations = function (criteriaType, onSuccess, onFailure) {
        if (criteriaType) {
            var evidencePanels = document.querySelectorAll(".applicant-evidence__skill[data-criteria-type=\"" + criteriaType + "\"]:not(.template)")

        } else if (criteriaType === undefined) {
            var evidencePanels = document.querySelectorAll(".applicant-evidence__skill:not(.template)")

        } else {
            Utilities.debug ? console.log("Cannot save Skill Declarations with given type.") : null;
function someFunction(x) {
    (x > 0) ? callFoo() : callBar();
}

// JSHint expects you to assign the result to a variable:
function someFunction(x) {
    var rs = (x > 0) ? callFoo() : callBar();
}

// If you do not use the result, you could also use if statements in the
// case above.
function someFunction(x) {
    if (x > 0) {
        callFoo();
    } else {
        callBar();
    }
}
            return;
        }

        var submittedRequests = 0; //to keep track of number of PUT calls in progress
        var requestsSuccessful = true;

        var applicationId = document.getElementById("jobApplicationJobApplicationId").value;

        for (var i=0; i<evidencePanels.length; i++) {
function someFunction() {
    (function() {
        var i = 0;
    })();

    // i is not defined.
    alert(i);
}

// This can be fixed by moving the var statement to the outer scope.

function someFunction() {
    var i;
    (function() {
        i = 1;
    })();

    alert(i);
};
            var panel = evidencePanels[i];
function someFunction() {
    (function() {
        var i = 0;
    })();

    // i is not defined.
    alert(i);
}

// This can be fixed by moving the var statement to the outer scope.

function someFunction() {
    var i;
    (function() {
        i = 1;
    })();

    alert(i);
};
            var newSkillDeclaration = new SkillDeclarationAPI.getSkillDeclarationFromEvidencePanel(panel);

            if (applicationId) {
                //Only save if this declaration is complete
                if (newSkillDeclaration.isValid()) {
                    submittedRequests = submittedRequests + 1;
                    DataAPI.saveSkillDeclaration(newSkillDeclaration, newSkillDeclaration.criteria_id, applicationId, function (response) {
var funcs = [];
for (var i=0; i<10; i++) {
    funcs.push(function() {
        alert(i);
    });
}

funcs[0](); // alert(10);
funcs[1](); // alert(10);
/// ...
funcs[9](); // alert(10);
                        if (response.status !== 200) {
                            requestsSuccessful = false;
                        }
                        submittedRequests = submittedRequests - 1;

                        if (submittedRequests === 0) {
                            if (onSuccess && requestsSuccessful) {

                                //Only call onSuccess if all requests have been successful
                                onSuccess();
                            } else if (onFailure && !requestsSuccessful) {
                                onFailure();
                            }
                        }
                    });
                } else {

                    //If declaration is not valid, do nothing
                }
            }
        }

        if (onSuccess && submittedRequests === 0) {
            //If no skills were even attempted to be saved, call onSuccess
            onSuccess();
        }
    };

    /**
    * Saves all completed skill declarations of given type.
    * If criteriaType is undefined, it saves ALL completed skill declarations.
    *
    * Call onSuccess if application is saved successfully
    *
    * @param {string} skillDeclarationId
    * @param {function} onSuccess
    * @return {undefined}
    */
    SkillDeclarationAPI.saveSingleSkillDeclaration = function (skillDeclarationId, onSuccess, onFailure) {

        var panel = document.querySelector(".applicant-evidence__skill[data-criteria-id=\"" + skillDeclarationId + "\"]:not(.template)")


        var applicationId = document.getElementById("jobApplicationJobApplicationId").value;

        var newSkillDeclaration = new SkillDeclarationAPI.getSkillDeclarationFromEvidencePanel(panel);

        if (applicationId) {
            //Only save if this declaration is complete
            if (newSkillDeclaration.isValid()) {
                DataAPI.saveSkillDeclaration(newSkillDeclaration, newSkillDeclaration.criteria_id, applicationId, function (response) {

                    if (response.status === 200) {
                        if (onSuccess)
                            onSuccess();
if (a > 0)
    b = 42;
                    } else {
                        if (onFailure) {
                            window.alert(response.response.message);
                            onFailure();
                        }
                    }

                });
            } else {
                window.alert("Skill declaration invalid, cannot save");
            }
        }
    };

    SkillDeclarationAPI.getSkillDeclarationFromEvidencePanel = function (panel) {
        
        var criteria_id = panel.getAttribute("data-criteria-id");;

        var skillDeclaration = new SkillDeclarationAPI.SkillDeclaration(criteria_id);

        skillDeclaration.criteria_type = panel.getAttribute("data-criteria-type");

        skillDeclaration.skill = panel.querySelector(".applicant-evidence__skill .applicant-evidence__skill-title").innerHTML;

        var experienceSelect = panel.querySelector('input[name="experience"]:checked'); //This will come back null, if no radio button has been selected yet
        skillDeclaration.experience_level_id = experienceSelect ? experienceSelect.value : ""; //Default to an empty string if nothing has been selected

        var skillLevelSelect = panel.querySelector('input[name="expertise"]:checked'); //This will come back null, if no radio button has been selected yet
        skillDeclaration.skill_level_id = skillLevelSelect ? skillLevelSelect.value : ""; //Default to an empty string if nothing has been selected

        skillDeclaration.description = panel.querySelector('.applicant-evidence__skill-declaration-text').value;
        
        skillDeclaration.nullifyEmptyFields();
        return skillDeclaration;
    };

    SkillDeclarationAPI.onStatusChange = function (criteriaId) {
        //If status changes, this can no longer be in a saved state
        EvidenceAPI.setUiSaved(criteriaId, SkillDeclarationAPI, false);


        var panel = document.querySelector(".applicant-evidence__skill[data-criteria-id=\"" + criteriaId + "\"]:not(.template)");

        var skillDeclaration = SkillDeclarationAPI.getSkillDeclarationFromEvidencePanel(panel);

        //Use validity to determine Completeness status
        EvidenceAPI.setUiComplete(criteriaId, SkillDeclarationAPI, skillDeclaration.isComplete());
        
        EvidenceAPI.onStatusUpdate();
    };


1			var SkillDeclarationAPI = {};
2
3			SkillDeclarationAPI.wrapperClass = "applicant-evidence__skill-attribute--required";
4
5			SkillDeclarationAPI.SkillDeclaration = function (criteriaId) {
6			this.criteria_id = criteriaId;
7			this.skill_declaration_id = null;
8			this.skill = null;
9			this.criteria_type = null;
10			this.experience_level_id = null;
11			this.skill_level_id = null;
12			this.description = null;
13			this.last_updated = null;
14
15			/**
16			* This is valid if experience_level_id, skill_level_id, and description
17			* are not empty.
18			*
19			* @return {Boolean}
20			*/
21			this.isComplete = function () {
22			return (this.skill_level_id && this.experience_level_id && this.description );
23			};
24
25			/**
26			* Return true if this object is ready to be saved to server
27			* @return {Boolean}
28			*/
29			this.isValid = function () {
30			return this.criteria_id != false;
			0 ignored issues – show Best Practice introduced 2018-06-27 17:26 UTC by Report Bug Copy Issue Report Comparing `this.criteria_id` to `false` using the `!=` operator is not safe. Consider using `!==` instead. Loading history... Coding Style introduced 2018-06-08 22:05 UTC by Report Bug Copy Issue Report It is recommended to use `!==` to compare with `false`. Generally, it is recommended to use strict comparison whenever possible and not to rely on the weaker type-juggling comparison operator. Read more about comparison operations. Loading history...
31			};
32
33			this.isEmpty = function () {
34			return (this.skill_level_id == false && this.experience_level_id == false && this.description == false);
			0 ignored issues – show Best Practice introduced 2018-06-27 17:26 UTC by Report Bug Copy Issue Report Comparing `this.experience_level_id` to `false` using the `==` operator is not safe. Consider using `===` instead. Loading history... Best Practice introduced 2018-06-27 17:26 UTC by Report Bug Copy Issue Report Comparing `this.skill_level_id` to `false` using the `==` operator is not safe. Consider using `===` instead. Loading history... Best Practice introduced 2018-06-27 17:26 UTC by Report Bug Copy Issue Report Comparing `this.description` to `false` using the `==` operator is not safe. Consider using `===` instead. Loading history... Coding Style introduced 2018-06-27 17:26 UTC by Report Bug Copy Issue Report It is recommended to use `===` to compare with `false`. Generally, it is recommended to use strict comparison whenever possible and not to rely on the weaker type-juggling comparison operator. Read more about comparison operations. Loading history...
35			};
36
37			this.nullifyEmptyFields = function() {
38			this.skill_level_id = this.skill_level_id ? this.skill_level_id : null;

GCTC-NTGC / TalentCloud

Push — master ( 401bbc...02c732 )

SkillDeclarationAPI.populateApplicationUiSkillDeclarations C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like