App\Http\Controllers\ApplicationByJobController

Complexity

Total Complexity

54

Size/Duplication

Total Lines	657
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	2	1
A	getApplicationFromJob()	0	11	2
A	show()	0	2	1
A	edit_asset_skills()	0	36	1
A	edit_basics()	0	34	3
A	edit_essential_skills()	0	36	1
A	preview()	0	38	1
A	edit_experience()	0	22	1
B	update_asset_skills()	0	65	10
A	complete()	0	23	1
D	update_experience()	0	128	16
A	submit()	0	35	1
A	update_basics()	0	32	5
B	update_essential_skills()	0	65	10

<?php

Missing file doc comment

namespace App\Http\Controllers;

use Barryvdh\Debugbar\Facade as Debugbar;
use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use App\Models\Lookup\ApplicationStatus;
use App\Models\Lookup\VeteranStatus;
use App\Models\Lookup\PreferredLanguage;
use App\Models\Lookup\CitizenshipDeclaration;
use App\Models\Applicant;
use App\Models\JobPoster;
use App\Models\JobApplication;
use App\Models\JobApplicationAnswer;
use App\Models\SkillDeclaration;
use App\Models\Skill;
use App\Models\Lookup\SkillStatus;
use App\Models\Degree;
use App\Models\Lookup\CriteriaType;
use App\Models\Criteria;
use App\Models\Course;
use App\Models\WorkExperience;
use App\Services\Validation\ApplicationValidator;
use Illuminate\Support\Facades\Auth;


class ApplicationByJobController extends Controller

Missing doc comment for class ApplicationByJobController

{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        //
    }

    /**
     * Display the Application for the specified job
     *
     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function show(JobPoster $jobPoster)

The parameter $jobPoster is not used and could be removed.

    {
        //
    }

    protected function getApplicationFromJob(JobPoster $jobPoster) {

Missing doc comment for function getApplicationFromJob()

        $application = JobApplication::where('applicant_id', Auth::user()->applicant->id)

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            ->where('job_poster_id', $jobPoster->id)->first();
        if ($application == null) {
            $application = new JobApplication();
            $application->job_poster_id = $jobPoster->id;
            $application->applicant_id = Auth::user()->applicant->id;
            $application->application_status_id = ApplicationStatus::where('name', 'draft')->firstOrFail()->id;
            $application->save();
        }
        return $application;
    }

    /**
     * Show the form for editing Application basics for the specified job.
     *
     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function edit_basics(JobPoster $jobPoster)

Public method name "ApplicationByJobController::edit_basics" is not in camel caps format

    {

        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

        //This is an alternative way of using policies instead of via middleware
        if (!Auth::user()->can('view', $application) ||
            !Auth::user()->can('update', $application)) {

Each line in a multi-line IF statement must begin with a boolean operator

Closing parenthesis of a multi-line IF statement must be on a new line

            abort(401);
        }

        return view('applicant/application_post_01', [

The expression return view('applicant/application_post_01', array('application_step' => 1, 'application_template' => Illuminate\Support\Facades\Lang::get('applicant/application_template'), 'language_options' => App\Models\Lookup\PreferredLanguage::all(), 'citizenship_options' => App\Models\Lookup\CitizenshipDeclaration::all(), 'veteran_options' => App\Models\Lookup\VeteranStatus::all(), 'preferred_language_template' => Illuminate\Support\Facades\Lang::get('common/preferred_language'), 'citizenship_declaration_template' => Illuminate\Support\Facades\Lang::get('common/citizenship_declaration'), 'veteran_status_template' => Illuminate\Support\Facades\Lang::get('common/veteran_status'), 'job' => $jobPoster, 'applicant' => $applicant, 'job_application' => $application, 'form_submit_action' => route('job.application.update.1', $jobPoster))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            /* Application Template Data */
                "application_step" => 1,
                "application_template" => Lang::get("applicant/application_template"),
                "language_options" => PreferredLanguage::all(),
                "citizenship_options" => CitizenshipDeclaration::all(),
                "veteran_options" => VeteranStatus::all(),
                "preferred_language_template" => Lang::get('common/preferred_language'),
                "citizenship_declaration_template" => Lang::get('common/citizenship_declaration'),
                "veteran_status_template" => Lang::get('common/veteran_status'),

            /* Job Data */
                "job" => $jobPoster,

            /* Applicant Data */
                "applicant" => $applicant,
                "job_application" => $application,

            /* Submission */
                "form_submit_action" => route('job.application.update.1', $jobPoster)

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Show the form for editing Application Experience for the specified job.
     *
     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function edit_experience(JobPoster $jobPoster)

Public method name "ApplicationByJobController::edit_experience" is not in camel caps format

    {

        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

        return view('applicant/application_post_02', [

The expression return view('applicant/application_post_02', array('application_step' => 2, 'application_template' => Illuminate\Support\Facades\Lang::get('applicant/application_template'), 'job' => $jobPoster, 'applicant' => $applicant, 'job_application' => $application, 'form_submit_action' => route('job.application.update.2', $jobPoster))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            /* Application Template Data */
                "application_step" => 2,
                "application_template" => Lang::get("applicant/application_template"),

            /* Job Data */
                "job" => $jobPoster,

            /* Applicant Data */
                "applicant" => $applicant,
                "job_application" => $application,

            /* Submission */
                "form_submit_action" => route('job.application.update.2', $jobPoster)

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Show the form for editing Application Essential Skills for the specified job.
     *
     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function edit_essential_skills(JobPoster $jobPoster)

Public method name "ApplicationByJobController::edit_essential_skills" is not in camel caps format

    {

        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

        $criteria = [
            'essential' => $jobPoster->criteria->filter(function($value, $key) {

The parameter $key is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $value->criteria_type->name == 'essential';
            }),

For multi-line function calls, the closing parenthesis should be on a new line.

            'asset' => $jobPoster->criteria->filter(function($value, $key) {

The parameter $key is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $value->criteria_type->name == 'asset';
            }),

For multi-line function calls, the closing parenthesis should be on a new line.

        ];

        return view('applicant/application_post_03', [

The expression return view('applicant/application_post_03', array('application_step' => 3, 'application_template' => Illuminate\Support\Facades\Lang::get('applicant/application_template'), 'job' => $jobPoster, 'skills' => App\Models\Skill::all(), 'skill_template' => Illuminate\Support\Facades\Lang::get('common/skills'), 'criteria' => $criteria, 'applicant' => $applicant, 'job_application' => $application, 'form_submit_action' => route('job.application.update.3', $jobPoster))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            
            /* Application Template Data */
                "application_step" => 3,
                "application_template" => Lang::get("applicant/application_template"),

            /* Job Data */
                "job" => $jobPoster,

            /* Skills Data */
                "skills" => Skill::all(),
                "skill_template" => Lang::get("common/skills"),
                "criteria" => $criteria,

            /* Applicant Data */
                "applicant" => $applicant,
                "job_application" => $application,

            /* Submission */
                "form_submit_action" => route('job.application.update.3', $jobPoster)

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Show the form for editing Application Asset Skills for the specified job.
     *
     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function edit_asset_skills(JobPoster $jobPoster)

Public method name "ApplicationByJobController::edit_asset_skills" is not in camel caps format

    {

        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

        $criteria = [
            'essential' => $jobPoster->criteria->filter(function($value, $key) {

The parameter $key is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $value->criteria_type->name == 'essential';
            }),

For multi-line function calls, the closing parenthesis should be on a new line.

            'asset' => $jobPoster->criteria->filter(function($value, $key) {

The parameter $key is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $value->criteria_type->name == 'asset';
            }),

For multi-line function calls, the closing parenthesis should be on a new line.

        ];

        return view('applicant/application_post_04', [

The expression return view('applicant/application_post_04', array('application_step' => 4, 'application_template' => Illuminate\Support\Facades\Lang::get('applicant/application_template'), 'job' => $jobPoster, 'skills' => App\Models\Skill::all(), 'skill_template' => Illuminate\Support\Facades\Lang::get('common/skills'), 'criteria' => $criteria, 'applicant' => $applicant, 'job_application' => $application, 'form_submit_action' => route('job.application.update.4', $jobPoster))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            /* Application Template Data */
                "application_step" => 4,
                "application_template" => Lang::get("applicant/application_template"),

            /* Job Data */
                "job" => $jobPoster,

            /* Skills Data */
                "skills" => Skill::all(),
                "skill_template" => Lang::get("common/skills"),
                "criteria" => $criteria,

            /* Applicant Data */
                "applicant" => $applicant,
                "job_application" => $application,

            /* Submission */
                "form_submit_action" => route('job.application.update.4', $jobPoster)

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Show the Application Preview for the application for the specified job.
     *
     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function preview(JobPoster $jobPoster) {

        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

        $criteria = [
            'essential' => $jobPoster->criteria->filter(function($value, $key) {

The parameter $key is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $value->criteria_type->name == 'essential';
            }),

For multi-line function calls, the closing parenthesis should be on a new line.

            'asset' => $jobPoster->criteria->filter(function($value, $key) {

The parameter $key is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $value->criteria_type->name == 'asset';
            }),

For multi-line function calls, the closing parenthesis should be on a new line.

        ];

        return view('applicant/application_post_05', [

The expression return view('applicant/application_post_05', array('application_step' => 5, 'application_template' => Illuminate\Support\Facades\Lang::get('applicant/application_template'), 'preferred_language_template' => Illuminate\Support\Facades\Lang::get('common/preferred_language'), 'citizenship_declaration_template' => Illuminate\Support\Facades\Lang::get('common/citizenship_declaration'), 'veteran_status_template' => Illuminate\Support\Facades\Lang::get('common/veteran_status'), 'job' => $jobPoster, 'skills' => App\Models\Skill::all(), 'skill_template' => Illuminate\Support\Facades\Lang::get('common/skills'), 'criteria' => $criteria, 'applicant' => $applicant, 'job_application' => $application, 'form_submit_action' => route('job.application.submit', $jobPoster))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            /* Application Template Data */
                "application_step" => 5,
                "application_template" => Lang::get("applicant/application_template"),
                "preferred_language_template" => Lang::get('common/preferred_language'),
                "citizenship_declaration_template" => Lang::get('common/citizenship_declaration'),
                "veteran_status_template" => Lang::get('common/veteran_status'),

            /* Job Data */
                "job" => $jobPoster,

            /* Skills Data */
                "skills" => Skill::all(),
                "skill_template" => Lang::get("common/skills"),
                "criteria" => $criteria,

            /* Applicant Data */
                "applicant" => $applicant,
                "job_application" => $application,

            /* Submission */
                "form_submit_action" => route('job.application.submit', $jobPoster)

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Show the application submission information.
     *
     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function complete(JobPoster $jobPoster) {

        /* Include Applicant Data */

            $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        /* Include Application Data */

            $application = $this->getApplicationFromJob($jobPoster);

        /* Return the Completion View */

            return view('applicant/application_post_complete', [

The opening parenthesis of a multi-line function call should be the last content on the line.

The expression return view('applicant/application_post_complete', array('application_template' => Illuminate\Support\Facades\Lang::get('applicant/application_template'), 'job' => $jobPoster, 'applicant' => $applicant, 'job_application' => $application)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

                /* Application Template Data */
                    "application_template" => Lang::get("applicant/application_template"),

                /* Job Data */
                    "job" => $jobPoster,

                /* Applicant Data */
                    "applicant" => $applicant,
                    "job_application" => $application

            ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Update the Application Basics in storage for the specified job.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 4 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function update_basics(Request $request, JobPoster $jobPoster)

Public method name "ApplicationByJobController::update_basics" is not in camel caps format

    {
        $input = $request->input();
        $applicant = Auth::user()->applicant;

The assignment to $applicant is dead and can be removed.

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

        $application->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'citizenship_declaration_id' => $input['citizenship_declaration_id'],
            'veteran_status_id' => $input['veteran_status_id'],
            'preferred_language_id' => $input['preferred_language_id'],
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $application->save();

        $questions = $jobPoster->job_poster_questions;
        foreach($questions as $question) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            $answer = null;
            if (isset($input['questions']) &&
                isset($input['questions'][$question->id])) {

Each line in a multi-line IF statement must begin with a boolean operator

Closing parenthesis of a multi-line IF statement must be on a new line

                $answer = $input['questions'][$question->id];
            }
            $answerObj = $application->job_application_answers
                ->firstWhere('job_poster_question_id', $question->id);
            if ($answerObj == null) {
                $answerObj = new JobApplicationAnswer();
                $answerObj->job_poster_question_id = $question->id;
                $answerObj->job_application_id = $application->id;
            }
            $answerObj->answer = $answer;
            $answerObj->save();
        }

        return redirect( route('job.application.edit.2', $jobPoster));

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

The expression return redirect(route('job.application.edit.2', $jobPoster)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the Application Basics in storage for the specified job.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 4 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function update_experience(Request $request, JobPoster $jobPoster)

Public method name "ApplicationByJobController::update_experience" is not in camel caps format

    {
        $input = $request->input();
        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

The assignment to $application is dead and can be removed.

        //TODO: save stuff to application

        //TODO: Note from Tristan: I did test this function, and it works as I expect,
        //TODO:     saving new/updated degrees, courses and work experiences
        //TODO:     to the profile.
        $degrees = $input['degrees'];

        //Save new degrees
        if (isset($degrees['new'])) {
            foreach($degrees['new'] as $degreeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $degree = new Degree();
                $degree->applicant_id = $applicant->id;
                $degree->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'degree_type_id' => $degreeInput['degree_type_id'],
                    'area_of_study' => $degreeInput['area_of_study'],
                    'institution' => $degreeInput['institution'],
                    'thesis' => $degreeInput['thesis'],
                    'start_date' => $degreeInput['start_date'],
                    'end_date' => $degreeInput['end_date']
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $degree->save();
            }
        }

        //Update old degrees
        if (isset($degrees['old'])) {
            foreach($degrees['old'] as $id=>$degreeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this degree belongs to this applicant
                $degree = $applicant->degrees->firstWhere('id', $id);
                if ($degree != null) {
                    $degree->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'degree_type_id' => $degreeInput['degree_type_id'],
                        'area_of_study' => $degreeInput['area_of_study'],
                        'institution' => $degreeInput['institution'],
                        'thesis' => $degreeInput['thesis'],
                        'start_date' => $degreeInput['start_date'],
                        'end_date' => $degreeInput['end_date']
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $degree->save();
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update degree with invalid id '.$id);
                }
            }
        }

        $courses = $input['courses'];

        //Save new courses
        if (isset($courses['new'])) {
            foreach($courses['new'] as $courseInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $course = new Course();
                $course->applicant_id = $applicant->id;
                $course->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'name' => $courseInput['name'],
                    'institution' => $courseInput['institution'],
                    'course_status_id' => $courseInput['course_status_id'],
                    'start_date' => $courseInput['start_date'],
                    'end_date' => $courseInput['end_date']
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $course->save();
            }
        }

        //Update old courses
        if (isset($courses['old'])) {
            foreach($courses['old'] as $id=>$courseInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this course belongs to this applicant
                $course = $applicant->courses->firstWhere('id', $id);
                if ($course != null) {
                    $course->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'name' => $courseInput['name'],
                        'institution' => $courseInput['institution'],
                        'course_status_id' => $courseInput['course_status_id'],
                        'start_date' => $courseInput['start_date'],
                        'end_date' => $courseInput['end_date']
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $course->save();
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update course with invalid id '.$id);
                }
            }
        }

        $work_experiences = $input['work_experiences'] ;

        //Save new work_experiences
        if (isset($work_experiences['new'])) {
            foreach($work_experiences['new'] as $workExperienceInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $workExperience = new WorkExperience();
                $workExperience->applicant_id = $applicant->id;
                $workExperience->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'role' => $workExperienceInput['role'],
                    'company' => $workExperienceInput['company'],
                    'description' => $workExperienceInput['description'],
                    'start_date' => $workExperienceInput['start_date'],
                    'end_date' => $workExperienceInput['end_date']
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $workExperience->save();
            }
        }

        //Update old work_experiences
        if (isset($work_experiences['old'])) {
            foreach($work_experiences['old'] as $id=>$workExperienceInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this work_experience belongs to this applicant
                $workExperience = $applicant->work_experiences->firstWhere('id', $id);
                if ($workExperience != null) {
                    $workExperience->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'role' => $workExperienceInput['role'],
                        'company' => $workExperienceInput['company'],
                        'description' => $workExperienceInput['description'],
                        'start_date' => $workExperienceInput['start_date'],
                        'end_date' => $workExperienceInput['end_date']
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $workExperience->save();
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update work_experience with invalid id '.$id);
                }
            }
        }

        return redirect( route('job.application.edit.3', $jobPoster));

The expression return redirect(route('job.application.edit.3', $jobPoster)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

    }

    /**
     * Update the Application Essential Skills in storage for the specified job.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 4 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function update_essential_skills(Request $request, JobPoster $jobPoster)

Public method name "ApplicationByJobController::update_essential_skills" is not in camel caps format

    {
        $input = $request->input();
        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

The assignment to $application is dead and can be removed.

        //TODO: save stuff to application

        //TODO: Note from Tristan: I haven't tested this. This was copied from the SkillsController.
        //TODO: But for now, if we're just updating the Applicant's Profile through this page,
        //TODO: then this same code, or something very close, should work.

        $skillDeclarations = $input['skill_declarations'];
        $claimedStatusId = SkillStatus::where('name', 'claimed')->firstOrFail()->id;

        //Save new skill declarartions
        if (isset($skillDeclarations['new'])) {
            foreach($skillDeclarations['new'] as $skillType => $typeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                foreach($typeInput as $criterion_id=>$skillDeclarationInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                    $skillDeclaration = new SkillDeclaration();
                    $skillDeclaration->applicant_id = $applicant->id;
                    $skillDeclaration->skill_id = Criteria::find($criterion_id)->skill->id;
                    $skillDeclaration->skill_status_id = $claimedStatusId;
                    $skillDeclaration->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'description' => $skillDeclarationInput['description'],
                        'skill_level_id' => isset($skillDeclarationInput['skill_level_id']) ? $skillDeclarationInput['skill_level_id'] : null,
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $skillDeclaration->save();

                    $referenceIds = $this->getRelativeIds($skillDeclarationInput, 'references');
                    $skillDeclaration->references()->sync($referenceIds);

                    $sampleIds = $this->getRelativeIds($skillDeclarationInput, 'samples');
                    $skillDeclaration->work_samples()->sync($sampleIds);
                }
            }
        }

        //Update old declarations
        if (isset($skillDeclarations['old'])) {
            foreach($skillDeclarations['old'] as $skillType => $typeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                foreach($typeInput as $id=>$skillDeclarationInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                    //Ensure this declaration belongs to this applicant
                    $skillDeclaration = $applicant->skill_declarations->firstWhere('id', $id);
                    if ($skillDeclaration != null) {
                        //skill_id and skill_status cannot be changed
                        $skillDeclaration->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                            'description' => $skillDeclarationInput['description'],
                            'skill_level_id' => isset($skillDeclarationInput['skill_level_id']) ? $skillDeclarationInput['skill_level_id'] : null,
                        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                        $skillDeclaration->save();

                        $referenceIds = $this->getRelativeIds($skillDeclarationInput, 'references');
                        $skillDeclaration->references()->sync($referenceIds);

                        $sampleIds = $this->getRelativeIds($skillDeclarationInput, 'samples');
                        $skillDeclaration->work_samples()->sync($sampleIds);
                    } else {
                        Debugbar::warning('Applicant '.$applicant->id.' attempted to update skill declaration with invalid id '.$id);
                    }
                }
            }
        }

        return redirect( route('job.application.edit.4', $jobPoster));

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

The expression return redirect(route('job.application.edit.4', $jobPoster)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the Application Asset Skills in storage for the specified job.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 4 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function update_asset_skills(Request $request, JobPoster $jobPoster)

Public method name "ApplicationByJobController::update_asset_skills" is not in camel caps format

    {
        $input = $request->input();
        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $application = $this->getApplicationFromJob($jobPoster);

The assignment to $application is dead and can be removed.

        //TODO: save stuff to application

        //TODO: Note from Tristan: I haven't tested this. This was copied from the SkillsController.
        //TODO: But for now, if we're just updating the Applicant's Profile through this page,
        //TODO: then this same code, or something very close, should work.

        $skillDeclarations = $input['skill_declarations'];
        $claimedStatusId = SkillStatus::where('name', 'claimed')->firstOrFail()->id;

        //Save new skill declarartions
        if (isset($skillDeclarations['new'])) {
            foreach($skillDeclarations['new'] as $skillType => $typeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                foreach($typeInput as $criterion_id=>$skillDeclarationInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                    $skillDeclaration = new SkillDeclaration();
                    $skillDeclaration->applicant_id = $applicant->id;
                    $skillDeclaration->skill_id = Criteria::find($criterion_id)->skill->id;
                    $skillDeclaration->skill_status_id = $claimedStatusId;
                    $skillDeclaration->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'description' => $skillDeclarationInput['description'],
                        'skill_level_id' => isset($skillDeclarationInput['skill_level_id']) ? $skillDeclarationInput['skill_level_id'] : null,
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $skillDeclaration->save();

                    $referenceIds = $this->getRelativeIds($skillDeclarationInput, 'references');
                    $skillDeclaration->references()->sync($referenceIds);

                    $sampleIds = $this->getRelativeIds($skillDeclarationInput, 'samples');
                    $skillDeclaration->work_samples()->sync($sampleIds);
                }
            }
        }

        //Update old declarations
        if (isset($skillDeclarations['old'])) {
            foreach($skillDeclarations['old'] as $skillType => $typeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                foreach($typeInput as $id=>$skillDeclarationInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                    //Ensure this declaration belongs to this applicant
                    $skillDeclaration = $applicant->skill_declarations->firstWhere('id', $id);
                    if ($skillDeclaration != null) {
                        //skill_id and skill_status cannot be changed
                        $skillDeclaration->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                            'description' => $skillDeclarationInput['description'],
                            'skill_level_id' => isset($skillDeclarationInput['skill_level_id']) ? $skillDeclarationInput['skill_level_id'] : null,
                        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                        $skillDeclaration->save();

                        $referenceIds = $this->getRelativeIds($skillDeclarationInput, 'references');
                        $skillDeclaration->references()->sync($referenceIds);

                        $sampleIds = $this->getRelativeIds($skillDeclarationInput, 'samples');
                        $skillDeclaration->work_samples()->sync($sampleIds);
                    } else {
                        Debugbar::warning('Applicant '.$applicant->id.' attempted to update skill declaration with invalid id '.$id);
                    }
                }
            }
        }

        return redirect( route('job.application.edit.5', $jobPoster));

The expression return redirect(route('job.application.edit.5', $jobPoster)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

    }

    /**
     * Submit the Application for the specified job.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 4 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function submit(Request $request, JobPoster $jobPoster)
    {
        $request->validate([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'submission_signature' => [
                'required',
                'string',
                'max:191',
            ],
            'submission_date' => [
                'required',
                'string',
                'max:191',
           ]
       ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $input = $request->input();
        $applicant = Auth::user()->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

The assignment to $applicant is dead and can be removed.

        $application = $this->getApplicationFromJob($jobPoster);

        //Save any final info
        $application->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'submission_signature' => $input['submission_signature'],
            'submission_date' => $input['submission_date'],
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        //TODO: Check that application is valid and complete
        $validator = new ApplicationValidator();
        $validator->validate($application);

        //Change status to 'submitted'
        $application->application_status_id = ApplicationStatus::where('name', 'submitted')->firstOrFail()->id;

        $application->save();

        return redirect( route('job.application.complete', $jobPoster));

The expression return redirect(route('job.application.complete', $jobPoster)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

$jobPoster of type App\Models\JobPoster is incompatible with the type array expected by parameter $parameters of route().

    }
}