App\Http\Controllers\Auth\FirstVisitController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	finishManagerRegistration()	0	29	4
A	showFirstVisitManagerForm()	0	12	1

<?php

namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Auth\AuthController;
use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use App\Models\Manager;
use App\Models\Lookup\Department;
use App\Services\Validation\RegistrationValidator;

class FirstVisitController extends AuthController
{
    /**
     * Show the form for completing Manager registration on first visit.
     *
     * @return \Illuminate\Http\Response
     */
    public function showFirstVisitManagerForm()
    {
        $routes = [
            'return' => route('home'),
            'continue' => route('manager.finish_registration'),
        ];

        return view('auth.first_visit_manager', [
            'routes' => $routes,
            'first_visit' => Lang::get('common/auth/first_manager_visit'),
            'departments' => Department::all(),
            'not_in_gov_option' => ['value' => 0, 'name' => Lang::get('common/auth/register.not_in_gov')],
        ]);
    }

    /**
     * Process the final data required for Managers.
     *
     * @param Request $request

Missing parameter comment

     * @return void

Function return type is void, but function contains return statement

     */
    public function finishManagerRegistration(Request $request)
    {
        $data = $request->all();
        $validator = RegistrationValidator::finalizeManagerValidator($data);
        $validator->validate();

        $user = $request->user();

        // Save manager specific fields to user
        $managerDepartment = Department::find($data['department']);
        $inGovernment = ($managerDepartment !== null);
        $user->not_in_gov = !$inGovernment;
        $user->gov_email = $inGovernment ? $data['gov_email'] : null;
        $user->save();
        $user->refresh();

        // Add (or update) manager profile
        // NOTE: modifying a field in $user, and saving it, appears to create Manager object. I don't know how. -- Tristan
        // That means that after setting not_in_gov or gov_email, a manager already exists here. Adding a new one will throw an exception.
        $department_id = $inGovernment ? $managerDepartment->id : null;
        if ($user->manager === null) {
            $user->applicant()->save(new Manager());
            $user->refresh();
        }
        $user->manager->department_id = $department_id;
        $user->manager->save();

        $user->refresh();
        return redirect(route('manager.home'));
    }
}