AssessmentType::getNameAttribute() - Code Metrics - Inspection of "Created Assessment models" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/screening-plan ( a30cac...87436a )

by Tristan

created 2018-12-19 22:10 UTC

AssessmentType::getNameAttribute() A

↳ Parent: AssessmentType

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php


namespace App\Models\Lookup;

use Illuminate\Database\Eloquent\Model;
use App\Models\Assessment;

/**
 * Class AssessmentType
 * Database columns:
 * @property int $id

 * @property string $key
 * @property \Jenssegers\Date\Date $created_at
 * @property \Jenssegers\Date\Date $updated_at
 * Relations:
 * @property Collection[Assessment] $assessments
 * Accessors:
 * @property string $name   The localized name for this type.
 */

class AssessmentType extends Model
{
    /**
     * The columns that can be filled with mass-assignment
     *
     * @var string[]
     */
    protected $fillable = [];

    /**
     * Get the collection of Assessments of this type.
     *
     * @return \Illuminate\Database\Eloquent\Collection
     */
    public function assessments() // phpcs:ignore
    {
        return $this->hasMany(Assessment::class);

    }

    /**
     * Get the localized name of this Type
     *
     * @return string
     */
    public function getNameAttribute(): string
    {
        return $this->key; //TODO: actually return a localized name

    }
}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3			namespace App\Models\Lookup;
4
5			use Illuminate\Database\Eloquent\Model;
6			use App\Models\Assessment;
7
8			/**
9			* Class AssessmentType
10			* Database columns:
11			* @property int $id
			0 ignored issues – show Coding Style introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report There must be exactly one blank line before the tags in a doc comment Loading history...
12			* @property string $key
13			* @property \Jenssegers\Date\Date $created_at
14			* @property \Jenssegers\Date\Date $updated_at
15			* Relations:
16			* @property Collection[Assessment] $assessments
17			* Accessors:
18			* @property string $name The localized name for this type.
19			*/
			0 ignored issues – show Documentation Bug introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report The doc comment `Collection[Assessment]` at position `1` could not be parsed: Expected ']' at position 1, but found '['. Loading history... Coding Style introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report Missing @package tag in class comment Loading history... Coding Style introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report Missing @author tag in class comment Loading history... Coding Style introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
20			class AssessmentType extends Model
21			{
22			/**
23			* The columns that can be filled with mass-assignment
24			*
25			* @var string[]
26			*/
27			protected $fillable = [];
28
29			/**
30			* Get the collection of Assessments of this type.
31			*
32			* @return \Illuminate\Database\Eloquent\Collection
33			*/
34			public function assessments() // phpcs:ignore
35			{
36			return $this->hasMany(Assessment::class);
			1 ignored issue – show Bug Best Practice introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report The expression `return $this->hasMany(Ap...dels\Assessment::class)` returns the type `Illuminate\Database\Eloquent\Relations\HasMany` which is incompatible with the documented return type `Illuminate\Database\Eloquent\Collection`. Loading history...
37			}
38
39			/**
40			* Get the localized name of this Type
41			*
42			* @return string
43			*/
44			public function getNameAttribute(): string
45			{
46			return $this->key; //TODO: actually return a localized name
			0 ignored issues – show Bug introduced 2018-12-19 22:17 UTC by Report Bug Copy Issue Report The property `key` does not seem to exist on `App\Models\Lookup\AssessmentType`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
47			}
48			}
49

GCTC-NTGC / TalentCloud

Push — feature/screening-plan ( a30cac...87436a )

AssessmentType::getNameAttribute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like