App\Services\Validation\Rules\PasswordFormatRule

Complexity

Total Complexity

2

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	passes()	0	3	1
A	message()	0	2	1

<?php

Missing file doc comment

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;

class PasswordFormatRule implements Rule

Missing doc comment for class PasswordFormatRule

{
    /**

Parameter $attribute should have a doc-comment as per coding-style.

Parameter $value should have a doc-comment as per coding-style.

     * This Password Validation rule should be referenced wherever we need the user input their password on the site.
     * The rules used on their passwords are;
     * 1) Password is required.
     * 2) Must be at least 8 characters
     * 3) The password must contain at least one character from the following categories:
     * lower-case characters (a-z), upper-case characters (A-Z),
     * digits (0-9), and non-alphanumeric symbols (%, $, !, etc.).
     * Guide used by Polivas Korop
     * https://laraveldaily.com/how-to-create-custom-validation-rules-laravel/
     */

There must be no blank lines after the function comment

Missing @return tag in function comment

    public function passes($attribute, $value) {
        $passwordPattern = "~^.*(?=.{3,})(?=.*[a-z])(?=.*[A-Z])(?=.*[0-9])(?=.*[.!@#$%^&*]).*$~";
        return preg_match($passwordPattern, $value);

The expression return preg_match($passwordPattern, $value) returns the type integer which is incompatible with the return type mandated by Illuminate\Contracts\Validation\Rule::passes() of boolean.

    }

    public function message() {

Missing doc comment for function message()

        return Lang::get('validation.custom.password');
    }

}