HandleOutput::getFunctions() - Code Metrics - Inspection of "Created new component that contains review section..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/hm-application-back-bu... ( 04fee5...e1ad94 )

by Tristan

created 2019-03-21 18:55 UTC

HandleOutput::getFunctions() A

↳ Parent: HandleOutput

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php namespace App\Utilities;

use Twig_Extension;
use Twig_SimpleFunction;
use Twig_SimpleFilter;

class HandleOutput extends Twig_Extension {
    /**
     * Functions
     * @return void

     */
    public function getFunctions() {

      return [

        new Twig_SimpleFunction('handleOutput', [$this, 'handleOutput']),
      ];
    }

    public function handleOutput($output, $outputHtml, $nullHtml) {

        if( !empty($output) ) {

          echo $outputHtml;
        } else {
          echo $nullHtml;
        }
    }
}
?>



1		<?php namespace App\Utilities;
2
3		use Twig_Extension;
4		use Twig_SimpleFunction;
5		use Twig_SimpleFilter;
6
7		class HandleOutput extends Twig_Extension {
8		/**
9		* Functions
10		* @return void
		1 ignored issue – show Coding Style introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Function return type is void, but function contains return statement Loading history...
11		*/
12	16	public function getFunctions() {
		0 ignored issues – show introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Method \App\Utilities\HandleOutput::getFunctions() does not have return type hint for its return value but it should be possible to add it based on @return annotation "void". Loading history...
13		return [
		1 ignored issue – show Bug Best Practice introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report The expression `return array(new Twig_Si...this, 'handleOutput')))` returns the type `array<integer,Twig_SimpleFunction>` which is incompatible with the documented return type `void`. Loading history...
14	16	new Twig_SimpleFunction('handleOutput', [$this, 'handleOutput']),
15		];
16		}
17
18	3	public function handleOutput($output, $outputHtml, $nullHtml) {
		1 ignored issue – show introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Method \App\Utilities\HandleOutput::handleOutput() does not have parameter type hint nor @param annotation for its parameter $output. Loading history... introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Method \App\Utilities\HandleOutput::handleOutput() does not have parameter type hint nor @param annotation for its parameter $outputHtml. Loading history... introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Method \App\Utilities\HandleOutput::handleOutput() does not have parameter type hint nor @param annotation for its parameter $nullHtml. Loading history... introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Method \App\Utilities\HandleOutput::handleOutput() does not have void return type hint. Loading history... Coding Style Documentation introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Missing doc comment for function handleOutput() Loading history...
19	3	if( !empty($output) ) {
		0 ignored issues – show Coding Style introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Expected 1 space(s) after IF keyword; 0 found Loading history... Coding Style introduced 2019-03-19 16:50 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history...
20	3	echo $outputHtml;
21		} else {
22		echo $nullHtml;
23		}
24	3	}
25		}
26		?>
		0 ignored issues – show Best Practice introduced 2019-03-07 20:56 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
27

GCTC-NTGC / TalentCloud

Push — feature/hm-application-back-bu... ( 04fee5...e1ad94 )

HandleOutput::getFunctions() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like