App\Http\Controllers\DemoController::reviewApplications()

Complexity

Conditions	2
Paths	2

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

0

<?php
    public function reviewApplications()

Method \App\Http\Controllers\DemoController::reviewApplications() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

    {
        if (\App::environment('local')) {

The call to Illuminate\Support\Facades\App::environment() has too many arguments starting with 'local'.

            $jobPoster = factory(JobPoster::class)->state('closed')->create();
            $applications = factory(JobApplication::class, 10)->create([
                'job_poster_id' => $jobPoster->id
            ]);
            $jobPoster->submitted_applications()->saveMany($applications);

            $applications->load(['veteran_status', 'citizenship_declaration', 'application_review', "applicant.user"]);
            return view('manager/review_applications', [

The expression return view('manager/review_applications', array('jobs_l10n' => Illuminate\Support\Facades\Lang::get('manager/job_index'), 'job' => $jobPoster, 'applications' => $applications, 'review_statuses' => App\Http\Controllers\ReviewStatus::all())) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

                /*Localization Strings*/
                'jobs_l10n' => Lang::get('manager/job_index'),

                /* Data */
                'job' => $jobPoster,
                'applications' => $applications,
                'review_statuses' => ReviewStatus::all(),
            ]);
        }
        return null;
    }