MenuComposer::compose() - Code Metrics - Inspection of "Merge branch 'dev' into feature/manager_localizati..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/manager_localization2 ( de29b5...0f36f8 )

by Xander

created 2019-02-05 14:54 UTC

MenuComposer::compose() F

↳ Parent: MenuComposer

Complexity

Conditions	53
Paths	198

Size

Total Lines	155
Code Lines	127

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	85
CRAP Score	126.9626

Importance

Changes

Metric	Value
eloc	127
dl	0
loc	155
ccs	85
cts	121
cp	0.7025
rs	2.6799
c	0
b	0
f	0
cc	53
nc	198
nop	1
crap	126.9626

How to fix Long Method Complexity

<?php


namespace App\Http\ViewComposers;

use Illuminate\View\View;
use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Route;
use Illuminate\Support\Facades\Auth;
use Facades\App\Services\WhichPortal;

class MenuComposer

{
    /**
     * Bind data to the view.
     *
     * @param  View  $view

     * @return void

     */
    public function compose(View $view)
    {
        if (WhichPortal::isApplicantPortal()) {
            $menu = Lang::get('applicant/menu');

            //Set active on the proper item
            switch(Route::currentRouteName()) {
                case 'home':
                    $menu['items']['home']['active'] = true;
                    break;
                case 'jobs.index':
                case 'jobs.show':
                case 'managers.show':
                    $menu['items']['jobs']['active'] = true;
                    break;
                case 'applications.index':
                case 'applications.edit':
                case 'applications.edit.1':
                case 'applications.edit.2':
                case 'applications.edit.3':
                case 'applications.edit.4':
                case 'applications.edit.5':
                case 'job.application.edit.1':
                case 'job.application.edit.2':
                case 'job.application.edit.3':
                case 'job.application.edit.4':
                case 'job.application.edit.5':
                case 'job.application.complete':
                    $menu['items']['applications']['active'] = true;
                    break;
                case 'profile':
                case 'profile.edit':
                case 'profile.show':
                case 'profile.about.edit':
                case 'profile.about.show':
                case 'profile.experience.edit':
                case 'profile.experience.show':
                case 'profile.references.edit':
                case 'profile.references.show':
                case 'profile.skills.edit':
                case 'profile.skills.show':
                case 'profile.work_samples.edit':
                case 'profile.work_samples.show':
                    $menu['items']['profile']['active'] = true;
                    break;
                case 'register':
                    $menu['items']['register']['active'] = true;
                    break;
                case 'login':
                    $menu['items']['login']['active'] = true;
                    break;
                case 'logout':
                    $menu['items']['logout']['active'] = true;
                    break;
                case 'faq':
                    $menu['items']['faq']['active'] = true;
                    break;
                default:
                    //No menu item will be active
                    break;
            }

            //Set route links
            $menu['items']['home']['link'] = route('home');
            $menu['items']['jobs']['link'] = route('jobs.index');
            $menu['items']['applications']['link'] = route('applications.index');
            $menu['items']['profile']['link'] = route('profile');
            $menu['items']['faq']['link'] = route('faq');

            //Check if use is logged in, and remove invalid menu items
            if (Auth::check()) {
                unset($menu['items']['login']);
                unset($menu['items']['register']);
                //TODO set profile like using user slug
            } else {
                unset($menu['items']['logout']);
                unset($menu['items']['applications']);
                unset($menu['items']['profile']);
            }
        } else if (WhichPortal::isManagerPortal()) {
            $menu = Lang::get('manager/menu');

            //Set active on the proper item
            switch(Route::currentRouteName()) {
                case 'manager.home':
                    $menu['items']['home']['active'] = true;
                    break;
                case 'manager.jobs.index':
                case 'manager.jobs.show':
                    $menu['items']['jobs']['active'] = true;
                    break;
                case 'manager.jobs.create':
                case 'manager.jobs.edit':
                case 'manager.jobs.update':
                    $menu['items']['create_job']['active'] = true;
                    break;
                case 'manager.profile':
                case 'manager.profile.edit':
                case 'manager.profile.show':
                    $menu['items']['profile']['active'] = true;
                    break;
                case 'register':
                    $menu['items']['register']['active'] = true;
                    break;
                case 'login':
                    $menu['items']['login']['active'] = true;
                    break;
                case 'logout':
                    $menu['items']['logout']['active'] = true;
                    break;
                case 'faq':
                    $menu['items']['faq']['active'] = true;
                    break;
                default:
                    //No menu item will be active
                    break;
            }

            //Set route links
            $menu['items']['home']['link'] = route('manager.home');
            $menu['items']['jobs']['link'] = route('manager.jobs.index');
            $menu['items']['create_job']['link'] = route('manager.jobs.create');
            $menu['items']['profile']['link'] = route('manager.profile');

            //Check if use is logged in, and remove invalid menu items
            if (Auth::check()) {
                unset($menu['items']['login']);
                unset($menu['items']['register']);
                //TODO set profile like using user slug
            } else {
                unset($menu['items']['logout']);
                unset($menu['items']['jobs']);
                unset($menu['items']['create_job']);
                unset($menu['items']['profile']);
            }
        }
        //Set login modals data
        if (WhichPortal::isManagerPortal()) {
            $loginModals = [
                'modals' => Lang::get('common/login_modals'),
                'register_link' => route('manager.register'),
                'login_link' => route('manager.login'),
                'logout_link' => route('manager.logout'),
            ];
        } else {
            $loginModals = [
                'modals' => Lang::get('common/login_modals'),
                'register_link' => route('register'),
                'login_link' => route('login'),
                'logout_link' => route('logout'),
            ];
        }

        $view->with('menu', $menu)

            ->with('login_modals', $loginModals);
    }
}


1		<?php
2
		0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3		namespace App\Http\ViewComposers;
4
5		use Illuminate\View\View;
6		use Illuminate\Support\Facades\Lang;
7		use Illuminate\Support\Facades\Route;
8		use Illuminate\Support\Facades\Auth;
9		use Facades\App\Services\WhichPortal;
10
11		class MenuComposer
		0 ignored issues – show Coding Style introduced 2018-08-28 21:44 UTC by Report Bug Copy Issue Report Missing doc comment for class MenuComposer Loading history...
12		{
13		/**
14		* Bind data to the view.
15		*
16		* @param View $view
		0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Expected 1 spaces after parameter type; 2 found Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
17		* @return void
		0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Tag cannot be grouped with parameter tags in a doc comment Loading history...
18		*/
19	28	public function compose(View $view)
20		{
21	28	if (WhichPortal::isApplicantPortal()) {
22	20	$menu = Lang::get('applicant/menu');
23
24		//Set active on the proper item
25	20	switch(Route::currentRouteName()) {
26	20	case 'home':
27	10	$menu['items']['home']['active'] = true;
28	10	break;
29	10	case 'jobs.index':
30	10	case 'jobs.show':
31	6	case 'managers.show':
32	4	$menu['items']['jobs']['active'] = true;
33	4	break;
34	6	case 'applications.index':
35	6	case 'applications.edit':
36	6	case 'applications.edit.1':
37	6	case 'applications.edit.2':
38	6	case 'applications.edit.3':
39	6	case 'applications.edit.4':
40	6	case 'applications.edit.5':
41	6	case 'job.application.edit.1':
42	6	case 'job.application.edit.2':
43	6	case 'job.application.edit.3':
44	6	case 'job.application.edit.4':
45	6	case 'job.application.edit.5':
46	6	case 'job.application.complete':
47		$menu['items']['applications']['active'] = true;
48		break;
49	6	case 'profile':
50	6	case 'profile.edit':
51	6	case 'profile.show':
52	6	case 'profile.about.edit':
53	6	case 'profile.about.show':
54	6	case 'profile.experience.edit':
55	6	case 'profile.experience.show':
56	6	case 'profile.references.edit':
57	6	case 'profile.references.show':
58	6	case 'profile.skills.edit':
59	6	case 'profile.skills.show':
60	6	case 'profile.work_samples.edit':
61	6	case 'profile.work_samples.show':
62		$menu['items']['profile']['active'] = true;
63		break;
64	6	case 'register':
65	2	$menu['items']['register']['active'] = true;
66	2	break;
67	4	case 'login':
68	4	$menu['items']['login']['active'] = true;
69	4	break;
70		case 'logout':
71		$menu['items']['logout']['active'] = true;
72		break;
73		case 'faq':
74		$menu['items']['faq']['active'] = true;
75		break;
76		default:
77		//No menu item will be active
78		break;
79		}
80
81		//Set route links
82	20	$menu['items']['home']['link'] = route('home');
83	20	$menu['items']['jobs']['link'] = route('jobs.index');
84	20	$menu['items']['applications']['link'] = route('applications.index');
85	20	$menu['items']['profile']['link'] = route('profile');
86	20	$menu['items']['faq']['link'] = route('faq');
87
88		//Check if use is logged in, and remove invalid menu items
89	20	if (Auth::check()) {
90	8	unset($menu['items']['login']);
91	8	unset($menu['items']['register']);
92		//TODO set profile like using user slug
93		} else {
94	16	unset($menu['items']['logout']);
95	16	unset($menu['items']['applications']);
96	20	unset($menu['items']['profile']);
97		}
98	8	} else if (WhichPortal::isManagerPortal()) {
99	8	$menu = Lang::get('manager/menu');
100
101		//Set active on the proper item
102	8	switch(Route::currentRouteName()) {
103	8	case 'manager.home':
104		$menu['items']['home']['active'] = true;
105		break;
106	8	case 'manager.jobs.index':
107	6	case 'manager.jobs.show':
108	4	$menu['items']['jobs']['active'] = true;
109	4	break;
110	4	case 'manager.jobs.create':
111	2	case 'manager.jobs.edit':
112		case 'manager.jobs.update':
113	4	$menu['items']['create_job']['active'] = true;
114	4	break;
115		case 'manager.profile':
116		case 'manager.profile.edit':
117		case 'manager.profile.show':
118		$menu['items']['profile']['active'] = true;
119		break;
120		case 'register':
121		$menu['items']['register']['active'] = true;
122		break;
123		case 'login':
124		$menu['items']['login']['active'] = true;
125		break;
126		case 'logout':
127		$menu['items']['logout']['active'] = true;
128		break;
129		case 'faq':
130		$menu['items']['faq']['active'] = true;
131		break;
132		default:
133		//No menu item will be active
134		break;
135		}
136
137		//Set route links
138	8	$menu['items']['home']['link'] = route('manager.home');
139	8	$menu['items']['jobs']['link'] = route('manager.jobs.index');
140	8	$menu['items']['create_job']['link'] = route('manager.jobs.create');
141	8	$menu['items']['profile']['link'] = route('manager.profile');
142
143		//Check if use is logged in, and remove invalid menu items
144	8	if (Auth::check()) {
145	8	unset($menu['items']['login']);
146	8	unset($menu['items']['register']);
147		//TODO set profile like using user slug
148		} else {
149		unset($menu['items']['logout']);
150		unset($menu['items']['jobs']);
151		unset($menu['items']['create_job']);
152		unset($menu['items']['profile']);
153		}
154		}
155		//Set login modals data
156	28	if (WhichPortal::isManagerPortal()) {
157		$loginModals = [
158	8	'modals' => Lang::get('common/login_modals'),
159	8	'register_link' => route('manager.register'),
160	8	'login_link' => route('manager.login'),
161	8	'logout_link' => route('manager.logout'),
162		];
163		} else {
164		$loginModals = [
165	20	'modals' => Lang::get('common/login_modals'),
166	20	'register_link' => route('register'),
167	20	'login_link' => route('login'),
168	20	'logout_link' => route('logout'),
169		];
170		}
171
172	28	$view->with('menu', $menu)
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-09-06 22:03 UTC by Report Bug Copy Issue Report The variable `$menu` does not seem to be defined for all execution paths leading up to this point. Loading history...
173	28	->with('login_modals', $loginModals);
174	28	}
175		}
176

GCTC-NTGC / TalentCloud

Push — feature/manager_localization2 ( de29b5...0f36f8 )

MenuComposer::compose() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like