PasswordFormatRule::message() - Code Metrics - Inspection of "Replace use of JobPosterValidator with UpdateJobPo..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job-env-culture ( 7a7dee...bc1cda )

by Tristan

created 2019-06-12 18:35 UTC

PasswordFormatRule::message() A

↳ Parent: PasswordFormatRule

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	2
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;

class PasswordFormatRule implements Rule
{
    /**

     * This Password Validation rule should be referenced wherever we need the user input their password on the site.
     * The rules used on their passwords are;
     * 1) Password is required.
     * 2) Must be at least 8 characters
     * 3) The password must contain at least one character from the following categories:
     * lower-case characters (a-z), upper-case characters (A-Z),
     * digits (0-9), and non-alphanumeric symbols (%, $, !, etc.).
     * Guide used by Polivas Korop
     * https://laraveldaily.com/how-to-create-custom-validation-rules-laravel/
     */


    public function passes($attribute, $value) {

        $passwordPattern = "~^.*(?=.{3,})(?=.*[a-z])(?=.*[A-Z])(?=.*[0-9])(?=.*[.!@#$%^&*]).*$~";
        return preg_match($passwordPattern, $value);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    public function message() {

        return Lang::get('validation.custom.password');
    }

}


1		<?php
2
3		namespace App\Services\Validation\Rules;
4
5		use Illuminate\Contracts\Validation\Rule;
6		use Illuminate\Support\Facades\Lang;
7
8		class PasswordFormatRule implements Rule
9		{
10		/**
		2 ignored issues – show Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Doc comment for parameter "$attribute" missing Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Doc comment for parameter "$value" missing Loading history...
11		* This Password Validation rule should be referenced wherever we need the user input their password on the site.
12		* The rules used on their passwords are;
13		* 1) Password is required.
14		* 2) Must be at least 8 characters
15		* 3) The password must contain at least one character from the following categories:
16		* lower-case characters (a-z), upper-case characters (A-Z),
17		* digits (0-9), and non-alphanumeric symbols (%, $, !, etc.).
18		* Guide used by Polivas Korop
19		* https://laraveldaily.com/how-to-create-custom-validation-rules-laravel/
20		*/
		1 ignored issue – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report There must be no blank lines after the function comment Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
21
22	8	public function passes($attribute, $value) {
		0 ignored issues – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\PasswordFormatRule::passes() does not have parameter type hint nor @param annotation for its parameter $attribute. Loading history... introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\PasswordFormatRule::passes() does not have parameter type hint nor @param annotation for its parameter $value. Loading history... introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\PasswordFormatRule::passes() does not have return type hint nor @return annotation for its return value. Loading history...
23	8	$passwordPattern = "~^.(?=.{3,})(?=.[a-z])(?=.[A-Z])(?=.[0-9])(?=.[.!@#$%^&]).*$~";
24	8	return preg_match($passwordPattern, $value);
		0 ignored issues – show Bug Best Practice introduced 2018-11-13 20:40 UTC by Report Bug Copy Issue Report The expression `return preg_match($passwordPattern, $value)` returns the type `integer` which is incompatible with the return type mandated by `Illuminate\Contracts\Validation\Rule::passes()` of `boolean`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
25		}
26
27	1	public function message() {
		1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\PasswordFormatRule::message() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function message() Loading history...
28	1	return Lang::get('validation.custom.password');
29		}
30
31		}
32

GCTC-NTGC / TalentCloud

Push — feature/job-env-culture ( 7a7dee...bc1cda )

PasswordFormatRule::message() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like