App\Http\Controllers\ExperienceController::update()

Complexity

Conditions	25
Paths	1728

Size

Total Lines	154
Code Lines	91

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	650

Importance

Changes

0

<?php
    public function update(Request $request, Applicant $applicant)
    {
        $input = $request->input();

        $degrees = $input['degrees'];

        //Delete old degrees that weren't resubmitted
        //Note: this must be done before adding new degrees, so we don't delete
        // them right after adding them
        foreach($applicant->degrees as $oldDegree) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            //Check if no degrees were resubmitted, or if this specific one wasn't
            if (!isset($degrees['old']) ||
                !isset($degrees['old'][$oldDegree->id])) {

Each line in a multi-line IF statement must begin with a boolean operator

Closing parenthesis of a multi-line IF statement must be on a new line

                $oldDegree->delete();
            }
        }

        //Save new degrees
        if (isset($degrees['new'])) {
            foreach($degrees['new'] as $degreeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $degree = new Degree();
                $degree->applicant_id = $applicant->id;
                $degree->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'degree_type_id' => $degreeInput['degree_type_id'],
                    'area_of_study' => $degreeInput['area_of_study'],
                    'institution' => $degreeInput['institution'],
                    'thesis' => $degreeInput['thesis'],
                    'start_date' => $degreeInput['start_date'],
                    'end_date' => $degreeInput['end_date']
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $degree->save();
            }
        }

        //Update old degrees
        if (isset($degrees['old'])) {
            foreach($degrees['old'] as $id=>$degreeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this degree belongs to this applicant
                $degree = $applicant->degrees->firstWhere('id', $id);
                if ($degree != null) {
                    $degree->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'degree_type_id' => $degreeInput['degree_type_id'],
                        'area_of_study' => $degreeInput['area_of_study'],
                        'institution' => $degreeInput['institution'],
                        'thesis' => $degreeInput['thesis'],
                        'start_date' => $degreeInput['start_date'],
                        'end_date' => $degreeInput['end_date']
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $degree->save();
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update degree with invalid id '.$id);
                }
            }
        }

        $courses = $input['courses'];

        //Delete old courses that weren't resubmitted
        //Note: this must be done before adding new ones, so we don't delete
        // them right after adding them
        foreach($applicant->courses as $oldCourse) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            //Check if no courses were resubmitted, or if this specific one wasn't
            if (!isset($courses['old']) ||
                !isset($courses['old'][$oldCourse->id])) {

Each line in a multi-line IF statement must begin with a boolean operator

Closing parenthesis of a multi-line IF statement must be on a new line

                $oldCourse->delete();
            }
        }

        //Save new courses
        if (isset($courses['new'])) {
            foreach($courses['new'] as $courseInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $course = new Course();
                $course->applicant_id = $applicant->id;
                $course->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'name' => $courseInput['name'],
                    'institution' => $courseInput['institution'],
                    'course_status_id' => $courseInput['course_status_id'],
                    'start_date' => $courseInput['start_date'],
                    'end_date' => $courseInput['end_date']
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $course->save();
            }
        }

        //Update old courses
        if (isset($courses['old'])) {
            foreach($courses['old'] as $id=>$courseInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this course belongs to this applicant
                $course = $applicant->courses->firstWhere('id', $id);
                if ($course != null) {
                    $course->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'name' => $courseInput['name'],
                        'institution' => $courseInput['institution'],
                        'course_status_id' => $courseInput['course_status_id'],
                        'start_date' => $courseInput['start_date'],
                        'end_date' => $courseInput['end_date']
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $course->save();
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update course with invalid id '.$id);
                }
            }
        }

        $work_experiences = $input['work_experiences'] ;

        //Delete old work_experiences that weren't resubmitted
        //Note: this must be done before adding new ones, so we don't delete
        // them right after adding them
        foreach($applicant->work_experiences as $oldWorkExperience) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            //Check if no work_experiences were resubmitted, or if this specific one wasn't
            if (!isset($work_experiences['old']) ||
                !isset($work_experiences['old'][$oldWorkExperience->id])) {

Each line in a multi-line IF statement must begin with a boolean operator

Closing parenthesis of a multi-line IF statement must be on a new line

                $oldWorkExperience->delete();
            }
        }

        //Save new work_experiences
        if (isset($work_experiences['new'])) {
            foreach($work_experiences['new'] as $workExperienceInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $workExperience = new WorkExperience();
                $workExperience->applicant_id = $applicant->id;
                $workExperience->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'role' => $workExperienceInput['role'],
                    'company' => $workExperienceInput['company'],
                    'description' => $workExperienceInput['description'],
                    'start_date' => $workExperienceInput['start_date'],
                    'end_date' => $workExperienceInput['end_date']
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $workExperience->save();
            }
        }

        //Update old work_experiences
        if (isset($work_experiences['old'])) {
            foreach($work_experiences['old'] as $id=>$workExperienceInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this work_experience belongs to this applicant
                $workExperience = $applicant->work_experiences->firstWhere('id', $id);
                if ($workExperience != null) {
                    $workExperience->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'role' => $workExperienceInput['role'],
                        'company' => $workExperienceInput['company'],
                        'description' => $workExperienceInput['description'],
                        'start_date' => $workExperienceInput['start_date'],
                        'end_date' => $workExperienceInput['end_date']
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $workExperience->save();
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update work_experience with invalid id '.$id);
                }
            }
        }

        return redirect( route('profile.experience.edit', $applicant) );

The expression return redirect(route('profile.experience.edit', $applicant)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

$applicant of type App\Models\Applicant is incompatible with the type array expected by parameter $parameters of route().

        // Debugbar::info($input);