App\Http\Controllers\ReferencesController

Complexity

Total Complexity

18

Size/Duplication

Total Lines	154
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
C	update()	0	113	16
A	show()	0	2	1
A	edit()	0	9	1

<?php

Missing file doc comment

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use Barryvdh\Debugbar\Facade as Debugbar;
use App\Http\Controllers\Controller;
use App\Models\Skill;
use App\Models\Applicant;
use App\Models\Reference;
use App\Models\Lookup\Relationship;
use App\Models\Project;

class ReferencesController extends Controller

Missing doc comment for class ReferencesController

{

    /**
     * Display the Skills page associated with the applicant.
     *
     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function show(Applicant $applicant)

The parameter $applicant is not used and could be removed.

    {
        //

    }

    /**
     * Show the form for editing the applicant's references
     *
     * @param  Request  $request

Missing parameter comment

Expected 15 spaces after parameter type; 2 found

     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function edit(Request $request, Applicant $applicant)
    {
        return view('applicant/profile_04_references', [

The expression return view('applicant/profile_04_references', array('applicant' => $applicant, 'profile' => Illuminate\Support\Facades\Lang::get('applicant/profile_references'), 'relative_template' => Illuminate\Support\Facades\Lang::get('common/relatives'), 'skills' => App\Models\Skill::all(), 'relationships' => App\Models\Lookup\Relationship::all(), 'form_submit_action' => route('profile.references.update', $applicant))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_references'),
            'relative_template' => Lang::get('common/relatives'),
            'skills' => Skill::all(),
            'relationships' => Relationship::all(),
            'form_submit_action' => route('profile.references.update', $applicant),

$applicant of type App\Models\Applicant is incompatible with the type array expected by parameter $parameters of route().

        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Update the applicant's references in storage.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 4 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function update(Request $request, Applicant $applicant)
    {
        $input = $request->input();

        Debugbar::info($input);

        $references = $input['references'];

        //Delete old references that weren't resubmitted
        //Note: this must be done before adding new references, so we don't delete
        // them right after adding them
        foreach($applicant->references as $oldReference) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            //Check if no references were resubmitted, or if this specific one wasn't
            if (!isset($references['old']) ||
                !isset($references['old'][$oldReference->id])) {

Each line in a multi-line IF statement must begin with a boolean operator

Closing parenthesis of a multi-line IF statement must be on a new line

                $oldReference->delete();
            }
        }

        //Save new references
        if (isset($references['new'])) {
            foreach($references['new'] as $referenceInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $reference = new Reference();
                $reference->applicant_id = $applicant->id;
                $reference->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'name' => $referenceInput['name'],
                    'email' => $referenceInput['email'],
                    'relationship_id' => $referenceInput['relationship_id'],
                    'description' => $referenceInput['description'],
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $reference->save();

                $projectIds = [];
                $projects = $referenceInput['projects'];
                if (isset($projects['new'])) {
                    foreach($projects['new'] as $projectInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                        $project = new Project();
                        $project->applicant_id = $applicant->id;
                        $project->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                            'name' => $projectInput['name'],
                            'start_date' => $projectInput['start_date'],
                            'end_date' => $projectInput['end_date'],
                        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                        $project->save();
                        $projectIds[] = $project->id;
                    }
                }
                //Sync attaches the specified ids, and detaches all others
                $reference->projects()->sync($projectIds);


                $skillDeclarationIds =$this->getRelativeIds($referenceInput, 'skills');
                $reference->skill_declarations()->sync($skillDeclarationIds);
            }
        }

        //Update old references
        if (isset($references['old'])) {
            foreach($references['old'] as $id=>$referenceInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this reference belongs to this applicant
                $reference = $applicant->references->firstWhere('id', $id);
                if ($reference != null) {
                    $reference->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'name' => $referenceInput['name'],
                        'email' => $referenceInput['email'],
                        'relationship_id' => $referenceInput['relationship_id'],
                        'description' => $referenceInput['description'],
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $reference->save();

                    $projectIds = [];
                    $projects = $referenceInput['projects'];
                    if (isset($projects['new'])) {
                        foreach($projects['new'] as $projectInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                            $project = new Project();
                            $project->applicant_id = $applicant->id;
                            $project->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                                'name' => $projectInput['name'],
                                'start_date' => $projectInput['start_date'],
                                'end_date' => $projectInput['end_date'],
                            ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                            $project->save();
                            $projectIds[] = $project->id;
                        }
                    }
                    if (isset($projects['old'])) {
                        foreach($projects['old'] as $projectId=>$projectInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                            //Ensure this project belongs to this applicant
                            $project = $applicant->projects->firstWhere('id', $projectId);
                            if ($project != null) {
                                $project->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                                    'name' => $projectInput['name'],
                                    'start_date' => $projectInput['start_date'],
                                    'end_date' => $projectInput['end_date'],
                                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                                $project->save();
                                $projectIds[] = $project->id;
                            }
                        }
                    }
                    //Sync attaches the specified ids, and detaches all others
                    $reference->projects()->sync($projectIds);

                    $skillDeclarationIds =$this->getRelativeIds($referenceInput, 'skills');
                    $reference->skill_declarations()->sync($skillDeclarationIds);
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update reference with invalid id '.$id);
                }
            }
        }

        return redirect( route('profile.references.edit', $applicant) );

The expression return redirect(route('profile.references.edit', $applicant)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

$applicant of type App\Models\Applicant is incompatible with the type array expected by parameter $parameters of route().

        // return view('applicant/profile_04_references', [
        //     'applicant' => $applicant,
        //     'profile' => Lang::get('applicant/profile_references'),
        //     'relative_template' => Lang::get('common/relatives'),
        //     'skills' => Skill::all(),
        //     'relationships' => Relationship::all(),
        //     'form_submit_action' => route('profile.references.update', $applicant),
        // ]);
    }

}