App\Services\Validation\Rules\FrequencyRule

Complexity

Total Complexity

3

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

71.43%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	message()	0	3	1
A	__construct()	0	3	1
A	passes()	0	3	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;
use App\Models\Lookup\Frequency;

/**
 * Validates that value is a valid department id
 */
class FrequencyRule implements Rule
{
    /**
     * Colaction of valid Frequency ids.
     *
     * @var Collection
     */
    protected $validIds;

    public function __construct()

Missing doc comment for function __construct()

    {
        $this->validIds = Frequency::all()->pluck('id');

It seems like App\Models\Lookup\Frequency::all()->pluck('id') of type Illuminate\Support\Collection is incompatible with the declared type App\Services\Validation\Rules\Collection of property $validIds.

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace

    public function passes($attribute, $value)

Method \App\Services\Validation\Rules\FrequencyRule::passes() does not have parameter type hint nor @param annotation for its parameter $attribute.

Method \App\Services\Validation\Rules\FrequencyRule::passes() does not have parameter type hint nor @param annotation for its parameter $value.

Method \App\Services\Validation\Rules\FrequencyRule::passes() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function passes()

    {
        return $this->validIds->contains($value);

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace

    public function message()

Method \App\Services\Validation\Rules\FrequencyRule::message() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function message()

    {
        return Lang::get('validation.invalid_id');
    }
}