App\Services\Validation\Rules\DepartmentRule

Complexity

Total Complexity

2

Size/Duplication

Total Lines	10
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	passes()	0	3	1
A	message()	0	3	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;
use App\Models\Lookup\Department;

/**
 * Validates that value is a valid department id
 */
class DepartmentRule implements Rule
{
    public function passes($attribute, $value)

Method \App\Services\Validation\Rules\DepartmentRule::passes() does not have parameter type hint nor @param annotation for its parameter $attribute.

Method \App\Services\Validation\Rules\DepartmentRule::passes() does not have parameter type hint nor @param annotation for its parameter $value.

Method \App\Services\Validation\Rules\DepartmentRule::passes() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function passes()

    {
        return Department::where('id', $value)->exists();

The expression return App\Models\Lookup\Department::where('id', $value)->exists() also could return the type Illuminate\Database\Eloquent\Builder which is incompatible with the return type mandated by Illuminate\Contracts\Validation\Rule::passes() of boolean.

    }

    public function message()

Method \App\Services\Validation\Rules\DepartmentRule::message() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function message()

    {
        return Lang::get('validation.invalid_id');
    }
}