Resource::setFileAttribute() - Code Metrics - Inspection of "Fix badly merged conflict" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — task/experience-education ( 788037...f8bedd )

by Tristan

created 2020-03-10 14:53 UTC

Resource::setFileAttribute() A

↳ Parent: Resource

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	5
c	2
b	0
f	0
dl	0
loc	9
rs	10
cc	2
nc	2
nop	1

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;
use Backpack\CRUD\app\Models\Traits\CrudTrait;
use Backpack\CRUD\app\Models\Traits\SpatieTranslatable\HasTranslations;
use Illuminate\Support\Facades\Storage;

/**
 * Class Resource
 *
 * @property int id
 * @property string name
 * @property string file
 */

class Resource extends Model
{
    use CrudTrait;
    use HasTranslations;

    /**
     * Delete file in resources folder
     *
     */
    public static function boot(): void
    {
        parent::boot();
        static::deleting(function ($obj): void {
            Storage::disk('public')->delete($obj->file);
        });
    }

    /**
     * The model's attibutes that admin cannot change.
     *
     * @var array
     */
    protected $guarded = ['id'];

    /**
     * The model's attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = ['name', 'file'];

    /**
     * The model's attributes that are translated.
     *
     * @var array
     */
    protected $translatable = ['name'];

    /**
     * Set the value of file name attribute in DB and upload file to disk.
     *
     * @param string $value Incoming value for 'file' attribute.
     */
    public function setFileAttribute(string $value): void
    {
        $request = \Request::instance();

        // Check if a new file has been uploaded if not then save value to file attribute
        if ($request->hasFile('file')) {
            $this->uploadFileToDisk($value, 'file', 'public', 'resources');
        } else {
            $this->attributes['file'] = $value;

        }
    }
}


1			<?php
2
3			namespace App\Models;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Backpack\CRUD\app\Models\Traits\CrudTrait;
7			use Backpack\CRUD\app\Models\Traits\SpatieTranslatable\HasTranslations;
8			use Illuminate\Support\Facades\Storage;
9
10			/**
11			* Class Resource
12			*
13			* @property int id
14			* @property string name
15			* @property string file
16			*/
17
18			class Resource extends Model
19			{
20			use CrudTrait;
21			use HasTranslations;
22
23			/**
24			* Delete file in resources folder
25			*
26			*/
27			public static function boot(): void
28			{
29			parent::boot();
30			static::deleting(function ($obj): void {
31			Storage::disk('public')->delete($obj->file);
32			});
33			}
34
35			/**
36			* The model's attibutes that admin cannot change.
37			*
38			* @var array
39			*/
40			protected $guarded = ['id'];
41
42			/**
43			* The model's attributes that are mass assignable.
44			*
45			* @var array
46			*/
47			protected $fillable = ['name', 'file'];
48
49			/**
50			* The model's attributes that are translated.
51			*
52			* @var array
53			*/
54			protected $translatable = ['name'];
55
56			/**
57			* Set the value of file name attribute in DB and upload file to disk.
58			*
59			* @param string $value Incoming value for 'file' attribute.
60			*/
61			public function setFileAttribute(string $value): void
62			{
63			$request = \Request::instance();
64
65			// Check if a new file has been uploaded if not then save value to file attribute
66			if ($request->hasFile('file')) {
67			$this->uploadFileToDisk($value, 'file', 'public', 'resources');
68			} else {
69			$this->attributes['file'] = $value;
			0 ignored issues – show Bug Best Practice introduced 2020-02-20 21:44 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
70			}
71			}
72			}
73

GCTC-NTGC / TalentCloud

Push — task/experience-education ( 788037...f8bedd )

Resource::setFileAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like