GCTC-NTGC /
TalentCloud
| Total Complexity | 45 |
| Total Lines | 326 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like JobApplication often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use JobApplication, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 56 | class JobApplication extends BaseModel |
||
| 57 | { |
||
| 58 | |||
| 59 | use Notifiable; |
||
| 60 | |||
| 61 | protected $dispatchesEvents = [ |
||
| 62 | 'retrieved' => ApplicationRetrieved::class, |
||
| 63 | 'saved' => ApplicationSaved::class, |
||
| 64 | ]; |
||
| 65 | |||
| 66 | protected $casts = [ |
||
| 67 | 'job_poster_id' => 'int', |
||
| 68 | 'application_status_id' => 'int', |
||
| 69 | 'citizenship_declaration_id' => 'int', |
||
| 70 | 'veteran_status_id' => 'int', |
||
| 71 | 'preferred_language_id' => 'int', |
||
| 72 | 'applicant_id' => 'int', |
||
| 73 | 'applicant_snapshot_id' => 'int', |
||
| 74 | 'submission_signature' => 'string', |
||
| 75 | 'submission_date' => 'string', |
||
| 76 | 'experience_saved' => 'boolean', |
||
| 77 | 'language_requirement_confirmed' => 'boolean', |
||
| 78 | 'version_id' |
||
| 79 | ]; |
||
| 80 | protected $fillable = [ |
||
| 81 | 'citizenship_declaration_id', |
||
| 82 | 'language_requirement_confirmed', |
||
| 83 | 'veteran_status_id', |
||
| 84 | 'preferred_language_id', |
||
| 85 | 'submission_signature', |
||
| 86 | 'submission_date', |
||
| 87 | 'experience_saved', |
||
| 88 | ]; |
||
| 89 | |||
| 90 | /** |
||
| 91 | * The accessors to append to the model's array/json form. |
||
| 92 | * |
||
| 93 | * @var array |
||
| 94 | */ |
||
| 95 | protected $appends = ['meets_essential_criteria']; |
||
| 96 | |||
| 97 | protected function createApplicantSnapshot($applicant_id) |
||
| 98 | { |
||
| 99 | $applicant = Applicant::where('id', $applicant_id)->firstOrFail(); |
||
| 100 | |||
| 101 | $snapshot = $applicant->replicate(); |
||
|
Unused Code
introduced
by
|
|||
| 102 | } |
||
| 103 | |||
| 104 | public function applicant() |
||
| 105 | { |
||
| 106 | return $this->belongsTo(\App\Models\Applicant::class); |
||
| 107 | } |
||
| 108 | |||
| 109 | public function applicant_snapshot() //phpcs:ignore |
||
| 110 | { |
||
| 111 | return $this->belongsTo(\App\Models\Applicant::class, 'applicant_snapshot_id'); |
||
| 112 | } |
||
| 113 | |||
| 114 | public function application_status() //phpcs:ignore |
||
| 115 | { |
||
| 116 | return $this->belongsTo(\App\Models\Lookup\ApplicationStatus::class); |
||
| 117 | } |
||
| 118 | |||
| 119 | public function citizenship_declaration() //phpcs:ignore |
||
| 120 | { |
||
| 121 | return $this->belongsTo(\App\Models\Lookup\CitizenshipDeclaration::class); |
||
| 122 | } |
||
| 123 | |||
| 124 | public function veteran_status() //phpcs:ignore |
||
| 125 | { |
||
| 126 | return $this->belongsTo(\App\Models\Lookup\VeteranStatus::class); |
||
| 127 | } |
||
| 128 | |||
| 129 | public function preferred_language() //phpcs:ignore |
||
| 130 | { |
||
| 131 | return $this->belongsTo(\App\Models\Lookup\PreferredLanguage::class); |
||
| 132 | } |
||
| 133 | |||
| 134 | public function job_poster() //phpcs:ignore |
||
| 135 | { |
||
| 136 | return $this->belongsTo(\App\Models\JobPoster::class); |
||
| 137 | } |
||
| 138 | |||
| 139 | public function job_application_answers() //phpcs:ignore |
||
| 140 | { |
||
| 141 | return $this->hasMany(\App\Models\JobApplicationAnswer::class); |
||
| 142 | } |
||
| 143 | |||
| 144 | public function skill_declarations() //phpcs:ignore |
||
| 145 | { |
||
| 146 | return $this->morphMany(\App\Models\SkillDeclaration::class, 'skillable'); |
||
| 147 | } |
||
| 148 | |||
| 149 | public function application_review() //phpcs:ignore |
||
| 150 | { |
||
| 151 | return $this->hasOne(ApplicationReview::class); |
||
| 152 | } |
||
| 153 | |||
| 154 | public function degrees() |
||
| 155 | { |
||
| 156 | return $this->morphMany(\App\Models\Degree::class, 'degreeable')->orderBy('end_date', 'desc'); |
||
| 157 | } |
||
| 158 | |||
| 159 | public function courses() |
||
| 160 | { |
||
| 161 | return $this->morphMany(\App\Models\Course::class, 'courseable')->orderBy('end_date', 'desc'); |
||
| 162 | } |
||
| 163 | |||
| 164 | public function work_experiences() //phpcs:ignore |
||
| 167 | } |
||
| 168 | |||
| 169 | public function references() |
||
| 170 | { |
||
| 171 | return $this->morphMany(\App\Models\Reference::class, 'referenceable'); |
||
| 172 | } |
||
| 173 | |||
| 174 | public function projects() |
||
| 177 | } |
||
| 178 | |||
| 179 | public function work_samples() //phpcs:ignore |
||
| 180 | { |
||
| 181 | return $this->morphMany(\App\Models\WorkSample::class, 'work_sampleable'); |
||
| 182 | } |
||
| 183 | |||
| 184 | public function job_application_version() //phpcs:ignore |
||
| 185 | { |
||
| 186 | return $this->hasOne(\App\Models\JobApplicationVersion::class); |
||
| 187 | } |
||
| 188 | |||
| 189 | /** |
||
| 190 | * Return either 'complete', 'incomplete' or 'error', depending on the |
||
| 191 | * status of the requested section. |
||
| 192 | * |
||
| 193 | * @param string $section Should be one of: |
||
| 194 | * 'basics' |
||
| 195 | * 'experience' |
||
| 196 | * 'essential_skills' |
||
| 197 | * 'asset_skills' |
||
| 198 | * 'preview' |
||
| 199 | * |
||
| 200 | * @return string $status 'complete', 'incomplete' or 'error' |
||
| 201 | */ |
||
| 202 | public function getSectionStatus(string $section) |
||
| 203 | { |
||
| 204 | // TODO: determine whether sections are complete or invalid |
||
| 205 | $validator = new ApplicationValidator(); |
||
| 206 | $status = 'incomplete'; |
||
| 207 | switch ($section) { |
||
| 208 | case 'basics': |
||
| 209 | if ($validator->basicsComplete($this)) { |
||
| 210 | $status = 'complete'; |
||
| 211 | } |
||
| 212 | break; |
||
| 213 | case 'experience': |
||
| 214 | if ($validator->experienceComplete($this)) { |
||
| 215 | $status = 'complete'; |
||
| 216 | } |
||
| 217 | break; |
||
| 218 | case 'essential_skills': |
||
| 219 | if ($validator->essentialSkillsComplete($this)) { |
||
| 220 | $status = 'complete'; |
||
| 221 | } |
||
| 222 | break; |
||
| 223 | case 'asset_skills': |
||
| 224 | if ($validator->assetSkillsComplete($this)) { |
||
| 225 | $status = 'complete'; |
||
| 226 | } |
||
| 227 | break; |
||
| 228 | case 'preview': |
||
| 229 | if ($validator->basicsComplete($this) && |
||
| 230 | $validator->experienceComplete($this) && |
||
| 231 | $validator->essentialSkillsComplete($this) && |
||
| 232 | $validator->assetSkillsComplete($this) |
||
| 233 | ) { |
||
| 234 | $status = 'complete'; |
||
| 235 | } |
||
| 236 | break; |
||
| 237 | case 'confirm': |
||
| 238 | if ($validator->affirmationComplete($this)) { |
||
| 239 | $status = 'complete'; |
||
| 240 | } |
||
| 241 | break; |
||
| 242 | default: |
||
| 243 | $status = 'error'; |
||
| 244 | break; |
||
| 245 | } |
||
| 246 | return $status; |
||
| 247 | } |
||
| 248 | |||
| 249 | /** |
||
| 250 | * Check if the status of the application is 'draft' |
||
| 251 | * |
||
| 252 | * @return boolean |
||
| 253 | */ |
||
| 254 | public function isDraft(): bool |
||
| 255 | { |
||
| 256 | return $this->application_status->name === 'draft'; |
||
| 257 | } |
||
| 258 | |||
| 259 | /** |
||
| 260 | * Returns true if this meets all the essential criteria. |
||
| 261 | * That means it has attached an SkillDeclaration for each essential criterion, |
||
| 262 | * with a level at least as high as the required level. |
||
| 263 | * NOTE: If this application is in draft status, it will use |
||
| 264 | * SkillDeclarations from the the applicants profile for this check. |
||
| 265 | * |
||
| 266 | * @return boolean |
||
| 267 | */ |
||
| 268 | public function meetsEssentialCriteria(): bool |
||
| 269 | { |
||
| 270 | $essentialCriteria = $this->job_poster->criteria->filter( |
||
| 271 | function ($value, $key) { |
||
| 272 | return $value->criteria_type->name == 'essential'; |
||
| 273 | } |
||
| 274 | ); |
||
| 275 | $source = $this->isDraft() ? $this->applicant : $this; |
||
| 276 | foreach ($essentialCriteria as $criterion) { |
||
| 277 | $skillDeclaration = $source->skill_declarations->where('skill_id', $criterion->skill_id)->first(); |
||
| 278 | if ($skillDeclaration === null || |
||
| 279 | $skillDeclaration->skill_level_id < $criterion->skill_level_id |
||
| 280 | ) { |
||
| 281 | return false; |
||
| 282 | } |
||
| 283 | } |
||
| 284 | return true; |
||
| 285 | } |
||
| 286 | |||
| 287 | /** |
||
| 288 | * Accessor for meetsEssentialCriteria function, which |
||
| 289 | * allows this value to be automatically appended to array/json representation. |
||
| 290 | * |
||
| 291 | * @return boolean |
||
| 292 | */ |
||
| 293 | public function getMeetsEssentialCriteriaAttribute(): bool |
||
| 294 | { |
||
| 295 | return $this->meetsEssentialCriteria(); |
||
| 296 | } |
||
| 297 | |||
| 298 | /** |
||
| 299 | * Save copies of all relevant profile data to this application. |
||
| 300 | * |
||
| 301 | * |
||
| 302 | * @return void |
||
| 303 | */ |
||
| 304 | public function saveProfileSnapshot(): void |
||
| 382 | } |
||
| 383 | } |
||
| 384 | } |
||
| 385 |
Loading history...