SkillDeclarationValidator::validator() - Code Metrics - Inspection of "Affirmation check finished" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/application_tracker_va... ( fa2127...f58e89 )

by Tristan

created 2018-12-13 20:45 UTC

SkillDeclarationValidator::validator() A

↳ Parent: SkillDeclarationValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	28
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	18
dl	0
loc	28
ccs	0
cts	15
cp	0
rs	9.6666
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php


namespace App\Services\Validation;

use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;
use App\Models\Skill;
use App\Models\SkillDeclaration;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\SkillStatus;
use App\Models\Applicant;
use App\Services\Validation\Rules\UniqueApplicantSkillRule;

class SkillDeclarationValidator

{

    protected $applicant;
    protected $skill_ids;
    protected $skill_status_ids;
    protected $skill_level_ids;


    public function __construct(Applicant $applicant)

    {
        $this->applicant = $applicant;
        $this->skill_ids = Skill::all()->pluck('id');
        $this->skill_status_ids = SkillStatus::all()->pluck('id');
        $this->skill_level_ids = SkillLevel::all()->pluck('id');

    }

    public function validator(SkillDeclaration $skillDeclaration) {

        $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);

        //This array is reset every time because applicants table can change frequently
        $applicant_ids = Applicant::all()->pluck('id');

        //Validate basic data is filled in
        $validator = Validator::make($skillDeclaration->getAttributes(), [

            'skill_id' => [
                'required',
                Rule::in($this->skill_ids->toArray()),
                $uniqueSkillRule,
            ],
            'applicant_id' => [
                'required',
                Rule::in($applicant_ids->toArray()),
            ],
            'skill_status_id' => [
                'required',
                Rule::in($this->skill_status_ids->toArray()),
            ],
            'skill_level_id' => [
                'required',
                Rule::in($this->skill_level_ids->toArray()),
            ],
            'description' => 'string|required',
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
        return $validator;
    }

    public function validate(SkillDeclaration $skillDeclaration)

    {
        return $this->validator($skillDeclaration)->validate();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }


}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2018-11-19 18:09 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3			namespace App\Services\Validation;
4
5			use Illuminate\Support\Facades\Validator;
6			use Illuminate\Validation\Rule;
7			use App\Models\Skill;
8			use App\Models\SkillDeclaration;
9			use App\Models\Lookup\SkillLevel;
10			use App\Models\Lookup\SkillStatus;
11			use App\Models\Applicant;
12			use App\Services\Validation\Rules\UniqueApplicantSkillRule;
13
14			class SkillDeclarationValidator
			0 ignored issues – show Coding Style introduced 2018-11-21 16:48 UTC by Report Bug Copy Issue Report Missing doc comment for class SkillDeclarationValidator Loading history...
15			{
16
17			protected $applicant;
18			protected $skill_ids;
19			protected $skill_status_ids;
20			protected $skill_level_ids;
21
22
23			public function __construct(Applicant $applicant)
			0 ignored issues – show Coding Style introduced 2018-11-28 21:00 UTC by Report Bug Copy Issue Report Missing doc comment for function __construct() Loading history...
24			{
25			$this->applicant = $applicant;
26			$this->skill_ids = Skill::all()->pluck('id');
27			$this->skill_status_ids = SkillStatus::all()->pluck('id');
28			$this->skill_level_ids = SkillLevel::all()->pluck('id');
29
30			}
31
32			public function validator(SkillDeclaration $skillDeclaration) {
			0 ignored issues – show Coding Style introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report Missing doc comment for function validator() Loading history...
33			$uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);
34
35			//This array is reset every time because applicants table can change frequently
36			$applicant_ids = Applicant::all()->pluck('id');
37
38			//Validate basic data is filled in
39			$validator = Validator::make($skillDeclaration->getAttributes(), [
			0 ignored issues – show Coding Style introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
40			'skill_id' => [
41			'required',
42			Rule::in($this->skill_ids->toArray()),
43			$uniqueSkillRule,
44			],
45			'applicant_id' => [
46			'required',
47			Rule::in($applicant_ids->toArray()),
48			],
49			'skill_status_id' => [
50			'required',
51			Rule::in($this->skill_status_ids->toArray()),
52			],
53			'skill_level_id' => [
54			'required',
55			Rule::in($this->skill_level_ids->toArray()),
56			],
57			'description' => 'string\|required',
58			]);
			0 ignored issues – show Coding Style introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
59			return $validator;
60			}
61
62			public function validate(SkillDeclaration $skillDeclaration)
			0 ignored issues – show Coding Style introduced 2018-12-13 15:22 UTC by Report Bug Copy Issue Report Missing doc comment for function validate() Loading history...
63			{
64			return $this->validator($skillDeclaration)->validate();
			0 ignored issues – show Bug introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->validator($skillDeclaration)->validate()` targeting `Illuminate\Validation\Validator::validate()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
65			}
66
67
68			}
69

GCTC-NTGC / TalentCloud

Push — feature/application_tracker_va... ( fa2127...f58e89 )

SkillDeclarationValidator::validator() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like