App\Http\Requests\UpdateManager

Complexity

Total Complexity

2

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	authorize()	0	3	1
A	rules()	0	51	1

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use App\Services\Validation\Rules\DepartmentRule;
use App\Services\Validation\Rules\FrequencyRule;

class UpdateManager extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool

Expected "boolean" but found "bool" for function return type

     */
    public function authorize()

Method \App\Http\Requests\UpdateManager::authorize() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array

@return annotation of method \App\Http\Requests\UpdateManager::rules() does not specify type hint for items of its traversable return value.

     */
    public function rules()

Method \App\Http\Requests\UpdateManager::rules() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array".

    {
        $frequencyRule = new FrequencyRule();
        return [
            'department_id' => ['nullable', new DepartmentRule()],
            /*
             * Twitters Terms of Service only allows ". A username can only contain
             * alphanumeric characters (letters A-Z, numbers 0-9) with the exception
             * of underscores"
             * This regex will allow only alphamumeric characters and the underscore.
             * Keep this handy if we need to validate other usernames.
             */
            'twitter_username' => [
                'nullable', //Some people may not have a handle.
                'max:15', //Per Twitter's Terms/Service.
                'regex:/^[A-Za-z0-9_]+$/',
            ],
            'linkedin_url' => [
                'nullable', // Some people may not be on LinkedIn
                'regex:/^(https:\\/\\/|http:\\/\\/)?www\\.linkedin\\.com\\/in\\/[^\\/]+(\\/)?$/', // Validation for linkedIn profile URLS only.
            ],
            'work_review_frequency_id' => ['nullable', $frequencyRule],
            'stay_late_frequency_id' => ['nullable', $frequencyRule],
            'engage_team_frequency_id' => ['nullable', $frequencyRule],
            'development_opportunity_frequency_id' => ['nullable', $frequencyRule],
            'refuse_low_value_work_frequency_id' => ['nullable', $frequencyRule],
            'years_experience' => 'nullable|numeric',

            'en.about_me' => 'nullable|string',
            'en.greatest_accomplishment' => 'nullable|string',
            'en.branch' => 'nullable|string',
            'en.division' => 'nullable|string',
            'en.position' => 'nullable|string',
            'en.leadership_style' => 'nullable|string',
            'en.employee_learning' => 'nullable|string',
            'en.expectations' => 'nullable|string',
            'en.education' => 'nullable|string',
            'en.career_journey' => 'nullable|string',
            'en.learning_path' => 'nullable|string',

            'fr.about_me' => 'nullable|string',
            'fr.greatest_accomplishment' => 'nullable|string',
            'fr.branch' => 'nullable|string',
            'fr.division' => 'nullable|string',
            'fr.position' => 'nullable|string',
            'fr.leadership_style' => 'nullable|string',
            'fr.employee_learning' => 'nullable|string',
            'fr.expectations' => 'nullable|string',
            'fr.education' => 'nullable|string',
            'fr.career_journey' => 'nullable|string',
            'fr.learning_path' => 'nullable|string',
        ];
    }
}