App\Http\Controllers\Api\ManagerApiController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Test Coverage

Coverage

66.67%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	destroy()	0	2	1
A	index()	0	2	1
A	store()	0	2	1
A	show()	0	3	1
A	__construct()	0	4	1
A	update()	0	6	1

<?php

namespace App\Http\Controllers\Api;

use App\Models\Manager;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use App\Http\Requests\UpdateManager;

class ManagerApiController extends Controller
{

    public function __construct()

Missing doc comment for function __construct()

    {
        // This applies the appropriate policy to each resource route
        $this->authorizeResource(Manager::class, 'manager');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response

Function return type is not void, but function has no return statement

     */
    public function index()
    {
        //TODO:
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Function return type is not void, but function has no return statement

     */
    public function store(Request $request)

The parameter $request is not used and could be removed.

    {
        //TODO:
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Models\Manager  $manager

Expected 1 spaces after parameter type; 2 found

Missing parameter comment

     * @return \Illuminate\Http\Response
     */
    public function show(Manager $manager)

Method \App\Http\Controllers\Api\ManagerApiController::show() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

    {
        return $manager->toApiArray();

The expression return $manager->toApiArray() returns the type array<mixed,mixed> which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  App\Http\Requests\UpdateManager  $request

The type App\Http\Controllers\Api\App\Http\Requests\UpdateManager was not found. Did you mean App\Http\Requests\UpdateManager? If so, make sure to prefix the type with \.

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\Manager  $manager

Expected 13 spaces after parameter type; 2 found

Missing parameter comment

     * @return \Illuminate\Http\Response
     */
    public function update(UpdateManager $request, Manager $manager)

Method \App\Http\Controllers\Api\ManagerApiController::update() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

    {
        $request->validated();
        $manager->fill($request->input());
        $manager->save();
        return $manager->toApiArray();

The expression return $manager->toApiArray() returns the type array<mixed,mixed> which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Models\Manager  $manager

Expected 1 spaces after parameter type; 2 found

Missing parameter comment

     * @return \Illuminate\Http\Response

Function return type is not void, but function has no return statement

     */
    public function destroy(Manager $manager)

The parameter $manager is not used and could be removed.

    {
        //TODO:
    }
}