MicroReferenceController::showSecondaryReferenceEmail() - Code Metrics - Inspection of "Set up micro reference emails that can be converte..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/micro-ref-email ( 897999 )

by Tristan

created 2020-03-26 21:17 UTC

showSecondaryReferenceEmail() A

↳ Parent: MicroReferenceController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	2
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
nc	1
nop	1

<?php

namespace App\Http\Controllers\Api;

use App\Http\Controllers\Controller;
use App\Mail\MicroReferenceMail;
use App\Models\JobApplication;
use Illuminate\Support\Facades\Mail;

class MicroReferenceController extends Controller
{

    /**
     * Get email created to be sent to an application's Director reference.
     *
     * @param JobApplication $application The application the reference is for.
     *
     * @return \Illuminate\Http\Response
     */
    public function showDirectorEmail(JobApplication $application)
    {
        $mail = new MicroReferenceMail($application, true);
        return response()->json($mail->build()->toArray());
        return /** @scrutinizer ignore-call */ response()->json($mail->build()->toArray());
    }

    public function sendDirectorEmail(JobApplication $application)
    {
        $mail = new MicroReferenceMail($application, true);
        Mail::send($mail->build());
        return response()->json($mail->build()->toArray());
        return /** @scrutinizer ignore-call */ response()->json($mail->build()->toArray());
    }

    /**
     * Get email created to be sent to an application's Secondary reference.
     *
     * @param JobApplication $application The application the reference is for.
     *
     * @return \Illuminate\Http\Response
     */
    public function showSecondaryReferenceEmail(JobApplication $application)
    {
        $mail = new MicroReferenceMail($application, false);
        return response()->json($mail->build()->toArray());
        return /** @scrutinizer ignore-call */ response()->json($mail->build()->toArray());
    }

    public function sendSecondaryReferenceEmail(JobApplication $application)
    {
        $mail = new MicroReferenceMail($application, false);
        Mail::send($mail->build());
        return response()->json($mail->build()->toArray());
        return /** @scrutinizer ignore-call */ response()->json($mail->build()->toArray());
    }
}


GCTC-NTGC / TalentCloud

Push — feature/micro-ref-email ( 897999 )

showSecondaryReferenceEmail() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like