ReferencesController::destroy() - Code Metrics - Inspection of "Removed refresh() calls which removed translations..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — bugfix/job_translation_fields ( dcec43...2ad85b )

by Tristan
created 2018-11-02 18:07 UTC
ReferencesController::destroy() A

↳ Parent: ReferencesController
Complexity

Conditions	3
Paths	4
Size

Total Lines	18
Code Lines	8
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	12
Importance

Changes
Metric	Value
eloc	8
dl	0
loc	18
rs	10
c	0
b	0
f	0
ccs	0
cts	0
cp	0
cc	3
nc	4
nop	2
crap	12
<?php


namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use Barryvdh\Debugbar\Facade as Debugbar;
use App\Http\Controllers\Controller;
use App\Models\Skill;
use App\Models\Applicant;
use App\Models\Reference;
use App\Models\Project;

class ReferencesController extends Controller

{

    /**
     * Display the Skills page associated with the applicant.
     *
     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function show(Applicant $applicant)
    public function show(/** @scrutinizer ignore-unused */ Applicant $applicant)
    {
        //

    }

    /**
     * Show the form for editing the applicant's references
     *
     * @param  Request  $request

     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function edit(Request $request, Applicant $applicant)
    {
        return view('applicant/profile_04_references', [

            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_references'),
            'form_submit_action' => route('profile.references.update', $applicant),
            'form_submit_action' => route('profile.references.update', /** @scrutinizer ignore-type */ $applicant),
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    /**
     * Update the applicant's references in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function update(Request $request, Applicant $applicant)
    {
        $input = $request->input();

        Debugbar::info($input);

        $references = $input['references'];

        //Delete old references that weren't resubmitted
        //Note: this must be done before adding new references, so we don't delete
        // them right after adding them
        foreach($applicant->references as $oldReference) {

            //Check if no references were resubmitted, or if this specific one wasn't
            if (!isset($references['old']) ||
                !isset($references['old'][$oldReference->id])) {

                $oldReference->delete();
            }
        }

        //Save new references
        if (isset($references['new'])) {
            foreach($references['new'] as $referenceInput) {

                $reference = new Reference();
                $reference->applicant_id = $applicant->id;
                $reference->fill([

                    'name' => $referenceInput['name'],
                    'email' => $referenceInput['email'],
                    'relationship_id' => $referenceInput['relationship_id'],
                    'description' => $referenceInput['description'],
                ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

                $reference->save();

                $projectIds = [];
                $projects = $referenceInput['projects'];
                if (isset($projects['new'])) {
                    foreach($projects['new'] as $projectInput) {

                        $project = new Project();
                        $project->applicant_id = $applicant->id;
                        $project->fill([

                            'name' => $projectInput['name'],
                            'start_date' => $projectInput['start_date'],
                            'end_date' => $projectInput['end_date'],
                        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                        $project->save();
                        $projectIds[] = $project->id;
                    }
                }
                //Sync attaches the specified ids, and detaches all others
                $reference->projects()->sync($projectIds);


                $skillDeclarationIds =$this->getRelativeIds($referenceInput, 'skills');
                $reference->skill_declarations()->sync($skillDeclarationIds);
            }
        }

        //Update old references
        if (isset($references['old'])) {
            foreach($references['old'] as $id=>$referenceInput) {

                //Ensure this reference belongs to this applicant
                $reference = $applicant->references->firstWhere('id', $id);
                if ($reference != null) {
                    $reference->fill([

                        'name' => $referenceInput['name'],
                        'email' => $referenceInput['email'],
                        'relationship_id' => $referenceInput['relationship_id'],
                        'description' => $referenceInput['description'],
                    ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                    $reference->save();

                    $projectIds = [];
                    $projects = $referenceInput['projects'];
                    if (isset($projects['new'])) {
                        foreach($projects['new'] as $projectInput) {

                            $project = new Project();
                            $project->applicant_id = $applicant->id;
                            $project->fill([

                                'name' => $projectInput['name'],
                                'start_date' => $projectInput['start_date'],
                                'end_date' => $projectInput['end_date'],
                            ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                            $project->save();
                            $projectIds[] = $project->id;
                        }
                    }
                    if (isset($projects['old'])) {
                        foreach($projects['old'] as $projectId=>$projectInput) {

                            //Ensure this project belongs to this applicant
                            $project = $applicant->projects->firstWhere('id', $projectId);
                            if ($project != null) {
                                $project->fill([

                                    'name' => $projectInput['name'],
                                    'start_date' => $projectInput['start_date'],
                                    'end_date' => $projectInput['end_date'],
                                ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                                $project->save();
                                $projectIds[] = $project->id;
                            }
                        }
                    }
                    //TODO: when projects exists independpently on profile, don't delete them Here
                    // Delete projects that will be detached from this reference
                    foreach($reference->projects as $project) {

                        if (!in_array($project->id, $projectIds)) {
                            $project->delete();
                        }
                    }

                    //Sync attaches the specified ids, and detaches all others
                    $reference->projects()->sync($projectIds);

                    $skillDeclarationIds =$this->getRelativeIds($referenceInput, 'skills');
                    $reference->skill_declarations()->sync($skillDeclarationIds);
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update reference with invalid id '.$id);
                }
            }
        }

        return redirect( route('profile.references.edit', $applicant) );
        return redirect( route('profile.references.edit', /** @scrutinizer ignore-type */ $applicant) );
    }

    /**
     * Delete the particular reference from storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\Reference  $reference

     * @return \Illuminate\Http\Response

     */
    public function destroy(Request $request, Reference $reference)
    {
        $this->authorize('delete', $reference);

        //TODO: when projects exist independently on profile, delete seperatley
        foreach($reference->projects as $project) {

            $project->delete();
        }

        $reference->delete();

        if($request->ajax()) {

            return [

                "message" => 'Reference deleted'
            ];
        }

        return redirect()->back();

    }

}

GCTC-NTGC / TalentCloud

Push — bugfix/job_translation_fields ( dcec43...2ad85b )

ReferencesController::destroy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
