ApplicationReviewController::updateForApplication()

Complexity

Conditions	3
Paths	4

Size

Total Lines	33
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

0

<?php
    public function updateForApplication(Request $request, JobApplication $application)
    {
        $request->validate([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'review_status' => [
                'required',
                Rule::in(ReviewStatus::all()->pluck('id')->toArray())
            ],
            'review_decision' => [
                'required',
                Rule::in(ReviewDecision::all()->pluck('id')->toArray())
            ],
            'reviewer' => 'required|string',
            'notes' => 'nullable|string'
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $review = $application->application_review;
        if ($review === null) {
            $review = new ApplicationReview();
            $review->job_application()->associate($application);
        }
        $review->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'review_status_id' => $request->input('review_status'),
            'review_decision_id' => $request->input('review_decision'),
            'reviewer' => $request->input('reviewer'),
            'notes' => $request->input('notes'),
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $review->save();

        if($request->ajax()) {

Expected "if (...) {\n"; found "if(...) {\n"

            return $review->toJson();

The expression return $review->toJson() returns the type string which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }