JobControllerTest::testManagerCreate() - Code Metrics - Inspection of "#423 Move JobController test to feature, add singl..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/preview-job-posters ( 85d5af )

unknown

created 2019-01-11 15:17 UTC

JobControllerTest::testManagerCreate() A

↳ Parent: JobControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	59
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	45
dl	0
loc	59
rs	9.2
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace Tests\Unit;

use Tests\TestCase;
use Illuminate\Foundation\Testing\WithFaker;
use Illuminate\Support\Facades\Lang;

use App\Models\Applicant;
use App\Models\Criteria;
use App\Models\Lookup\Department;
use App\Models\JobPoster;
use App\Models\JobPosterKeyTask;
use App\Models\JobPosterQuestion;
use App\Models\Lookup\LanguageRequirement;
use App\Models\Manager;
use App\Models\Lookup\Province;
use App\Models\Lookup\SecurityClearance;
use Doctrine\Common\Cache\VoidCache;

class JobControllerTest extends TestCase
{
    /**
     * Run parent setup and provide reusable factories.
     *
     * @return void
     */
    protected function setUp() : void
    {
        parent::setUp();

        $this->faker = \Faker\Factory::create();

        $this->faker_fr = \Faker\Factory::create('fr_FR');


        $this->manager = factory(Manager::class)->create();

        $this->jobPoster = factory(JobPoster::class)->create([

            'manager_id' => $this->manager->id
        ]);

        $this->jobPoster->criteria()->saveMany(factory(Criteria::class, 2)->make([
            'job_poster_id' => $this->jobPoster->id
        ]));
        $this->jobPoster->job_poster_key_tasks()->saveMany(factory(JobPosterKeyTask::class, 2)->make([
            'job_poster_id' => $this->jobPoster->id
        ]));
        $this->jobPoster->job_poster_questions()->saveMany(factory(JobPosterQuestion::class, 2)->make([
            'job_poster_id' => $this->jobPoster->id
        ]));

        $this->otherManager = factory(Manager::class)->create();

        $this->otherJobPoster = factory(JobPoster::class)->create([

            'manager_id' => $this->otherManager->id
        ]);

        $this->publishedJob = factory(JobPoster::class)->states('published')->create();

    }

    /**
     * Ensure an unauthorized user receives the correct job poster view.
     *
     * @return void
     */
    public function testGuestSingleView() : void
    {
        $response = $this->get('jobs/' . $this->publishedJob->id);
        $response->assertStatus(200);
        $response->assertSee(Lang::get('applicant/job_post')['apply']['login_link_title']);
    }

    /**
     * Ensure an authorized applicant receives the correct job poster view.
     *
     * @return void
     */
    public function testApplicantSingleView() : void
    {
        $applicant = factory(Applicant::class)->create();

        $response = $this->actingAs($applicant->user)
            ->get('jobs/' . $this->publishedJob->id);
        $response->assertStatus(200);
        $response->assertSee(Lang::get('applicant/job_post')['apply']['apply_link_title']);
    }

    /**
     * Ensure a manager can view their index page.
     *
     * @return void
     */
    public function testManagerIndexView() : void
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs');
        $response->assertStatus(200);

        $response->assertSee('<h3>' . $this->jobPoster->title . '</h3>');
        $response->assertDontSee('<h3>' . $this->otherJobPoster->title . '</h3>');
    }

    /**
     * Ensure a manager can view the create Job Poster form.
     *
     * @return void
     */
    public function testManagerCreateView() : void
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs/create');
        $response->assertStatus(200);

        $response->assertSee('<h2 class="heading--01">' . Lang::get('manager/job_create')['title'] . '</h2>');
        $response->assertViewIs('manager.job_create');
    }

    /**
     * Ensure a manager can create a Job Poster.
     *
     * @return void
     */
    public function testManagerCreate() : void
    {
        $newJob = [
            'term_qty' => $this->faker->numberBetween(1, 4),
            'salary_min' => $this->faker->numberBetween(60000, 80000),
            'salary_max' => $this->faker->numberBetween(80000, 100000),
            'noc' => $this->faker->numberBetween(1, 9999),
            'classification' => $this->faker->regexify('[A-Z]{2}-0[1-5]'),
            'manager_id' => $this->manager->id,
            'published' => false,
            'remote_work_allowed' => $this->faker->boolean(50),
            'open_date' => $this->faker->date('Y-m-d', strtotime('+1 day')),
            'open_time' => $this->faker->time(),
            'close_date' => $this->faker->date('Y-m-d', strtotime('+2 weeks')),
            'close_time' => $this->faker->time(),
            'start_date_time' => $this->faker->date('Y-m-d', strtotime('+2 weeks')) . ' ' . $this->faker->time(),
            'security_clearance' => SecurityClearance::inRandomOrder()->first()->id,
            'language_requirement' => LanguageRequirement::inRandomOrder()->first()->id,
            'department' => Department::inRandomOrder()->first()->id,
            'province' => Province::inRandomOrder()->first()->id,
            'city' => $this->faker->city,
            'title' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'impact' => [
                'en' => $this->faker->paragraphs(
                    2,
                    true
                ),
                'fr' => $this->faker_fr->paragraphs(
                    2,
                    true
                )
            ],
            'branch' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'division' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'education' => [
                'en' => $this->faker->sentence(),
                'fr' => $this->faker_fr->sentence()
            ],
            'submit' => '',
        ];

        $dbValues = array_slice($newJob, 0, 8);

        $response = $this->followingRedirects()
            ->actingAs($this->manager->user)
            ->post('manager/jobs/', $newJob);
        $response->assertStatus(200);
        $response->assertViewIs('applicant.job_post');
        $this->assertDatabaseHas('job_posters', $dbValues);
        $response->assertSee(Lang::get('applicant/job_post')['apply']['edit_link_title']);
    }

    /**
     * Ensure a manager can edit an unpublished Job Poster they created.
     *
     * @return void
     */
    public function testManagerEditView() : void
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs/' . $this->jobPoster->id . '/edit');

        $response->assertStatus(200);
        $response->assertViewIs('manager.job_create');
        // Check for a handful of properties
        $response->assertSee($this->jobPoster->city);
        $response->assertSee($this->jobPoster->education);
        $response->assertSee($this->jobPoster->title);
        $response->assertSee($this->jobPoster->impact);
        $response->assertSee($this->jobPoster->branch);
        $response->assertSee($this->jobPoster->division);
        $response->assertSee($this->jobPoster->education);
    }
}


1			<?php
2
3			namespace Tests\Unit;
4
5			use Tests\TestCase;
6			use Illuminate\Foundation\Testing\WithFaker;
7			use Illuminate\Support\Facades\Lang;
8
9			use App\Models\Applicant;
10			use App\Models\Criteria;
11			use App\Models\Lookup\Department;
12			use App\Models\JobPoster;
13			use App\Models\JobPosterKeyTask;
14			use App\Models\JobPosterQuestion;
15			use App\Models\Lookup\LanguageRequirement;
16			use App\Models\Manager;
17			use App\Models\Lookup\Province;
18			use App\Models\Lookup\SecurityClearance;
19			use Doctrine\Common\Cache\VoidCache;
20
21			class JobControllerTest extends TestCase
22			{
23			/**
24			* Run parent setup and provide reusable factories.
25			*
26			* @return void
27			*/
28			protected function setUp() : void
29			{
30			parent::setUp();
31
32			$this->faker = \Faker\Factory::create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `faker` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
33			$this->faker_fr = \Faker\Factory::create('fr_FR');
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `faker_fr` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
34
35			$this->manager = factory(Manager::class)->create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `manager` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
36			$this->jobPoster = factory(JobPoster::class)->create([
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `jobPoster` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
37			'manager_id' => $this->manager->id
38			]);
39
40			$this->jobPoster->criteria()->saveMany(factory(Criteria::class, 2)->make([
41			'job_poster_id' => $this->jobPoster->id
42			]));
43			$this->jobPoster->job_poster_key_tasks()->saveMany(factory(JobPosterKeyTask::class, 2)->make([
44			'job_poster_id' => $this->jobPoster->id
45			]));
46			$this->jobPoster->job_poster_questions()->saveMany(factory(JobPosterQuestion::class, 2)->make([
47			'job_poster_id' => $this->jobPoster->id
48			]));
49
50			$this->otherManager = factory(Manager::class)->create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `otherManager` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
51			$this->otherJobPoster = factory(JobPoster::class)->create([
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `otherJobPoster` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
52			'manager_id' => $this->otherManager->id
53			]);
54
55			$this->publishedJob = factory(JobPoster::class)->states('published')->create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-11 15:31 UTC by Report Bug Copy Issue Report The property `publishedJob` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
56			}
57
58			/**
59			* Ensure an unauthorized user receives the correct job poster view.
60			*
61			* @return void
62			*/
63			public function testGuestSingleView() : void
64			{
65			$response = $this->get('jobs/' . $this->publishedJob->id);
66			$response->assertStatus(200);
67			$response->assertSee(Lang::get('applicant/job_post')['apply']['login_link_title']);
68			}
69
70			/**
71			* Ensure an authorized applicant receives the correct job poster view.
72			*
73			* @return void
74			*/
75			public function testApplicantSingleView() : void
76			{
77			$applicant = factory(Applicant::class)->create();
78
79			$response = $this->actingAs($applicant->user)
80			->get('jobs/' . $this->publishedJob->id);
81			$response->assertStatus(200);
82			$response->assertSee(Lang::get('applicant/job_post')['apply']['apply_link_title']);
83			}
84
85			/**
86			* Ensure a manager can view their index page.
87			*
88			* @return void
89			*/
90			public function testManagerIndexView() : void
91			{
92			$response = $this->actingAs($this->manager->user)
93			->get('manager/jobs');
94			$response->assertStatus(200);
95
96			$response->assertSee('<h3>' . $this->jobPoster->title . '</h3>');
97			$response->assertDontSee('<h3>' . $this->otherJobPoster->title . '</h3>');
98			}
99
100			/**
101			* Ensure a manager can view the create Job Poster form.
102			*
103			* @return void
104			*/
105			public function testManagerCreateView() : void
106			{
107			$response = $this->actingAs($this->manager->user)
108			->get('manager/jobs/create');
109			$response->assertStatus(200);
110
111			$response->assertSee('<h2 class="heading--01">' . Lang::get('manager/job_create')['title'] . '</h2>');
112			$response->assertViewIs('manager.job_create');
113			}
114
115			/**
116			* Ensure a manager can create a Job Poster.
117			*
118			* @return void
119			*/
120			public function testManagerCreate() : void
121			{
122			$newJob = [
123			'term_qty' => $this->faker->numberBetween(1, 4),
124			'salary_min' => $this->faker->numberBetween(60000, 80000),
125			'salary_max' => $this->faker->numberBetween(80000, 100000),
126			'noc' => $this->faker->numberBetween(1, 9999),
127			'classification' => $this->faker->regexify('[A-Z]{2}-0[1-5]'),
128			'manager_id' => $this->manager->id,
129			'published' => false,
130			'remote_work_allowed' => $this->faker->boolean(50),
131			'open_date' => $this->faker->date('Y-m-d', strtotime('+1 day')),
132			'open_time' => $this->faker->time(),
133			'close_date' => $this->faker->date('Y-m-d', strtotime('+2 weeks')),
134			'close_time' => $this->faker->time(),
135			'start_date_time' => $this->faker->date('Y-m-d', strtotime('+2 weeks')) . ' ' . $this->faker->time(),
136			'security_clearance' => SecurityClearance::inRandomOrder()->first()->id,
137			'language_requirement' => LanguageRequirement::inRandomOrder()->first()->id,
138			'department' => Department::inRandomOrder()->first()->id,
139			'province' => Province::inRandomOrder()->first()->id,
140			'city' => $this->faker->city,
141			'title' => [
142			'en' => $this->faker->word,
143			'fr' => $this->faker_fr->word
144			],
145			'impact' => [
146			'en' => $this->faker->paragraphs(
147			2,
148			true
149			),
150			'fr' => $this->faker_fr->paragraphs(
151			2,
152			true
153			)
154			],
155			'branch' => [
156			'en' => $this->faker->word,
157			'fr' => $this->faker_fr->word
158			],
159			'division' => [
160			'en' => $this->faker->word,
161			'fr' => $this->faker_fr->word
162			],
163			'education' => [
164			'en' => $this->faker->sentence(),
165			'fr' => $this->faker_fr->sentence()
166			],
167			'submit' => '',
168			];
169
170			$dbValues = array_slice($newJob, 0, 8);
171
172			$response = $this->followingRedirects()
173			->actingAs($this->manager->user)
174			->post('manager/jobs/', $newJob);
175			$response->assertStatus(200);
176			$response->assertViewIs('applicant.job_post');
177			$this->assertDatabaseHas('job_posters', $dbValues);
178			$response->assertSee(Lang::get('applicant/job_post')['apply']['edit_link_title']);
179			}
180
181			/**
182			* Ensure a manager can edit an unpublished Job Poster they created.
183			*
184			* @return void
185			*/
186			public function testManagerEditView() : void
187			{
188			$response = $this->actingAs($this->manager->user)
189			->get('manager/jobs/' . $this->jobPoster->id . '/edit');
190
191			$response->assertStatus(200);
192			$response->assertViewIs('manager.job_create');
193			// Check for a handful of properties
194			$response->assertSee($this->jobPoster->city);
195			$response->assertSee($this->jobPoster->education);
196			$response->assertSee($this->jobPoster->title);
197			$response->assertSee($this->jobPoster->impact);
198			$response->assertSee($this->jobPoster->branch);
199			$response->assertSee($this->jobPoster->division);
200			$response->assertSee($this->jobPoster->education);
201			}
202			}
203

GCTC-NTGC / TalentCloud

Push — feature/preview-job-posters ( 85d5af )

JobControllerTest::testManagerCreate() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like