JobPoster::isOpen() - Code Metrics - Inspection of "#458 Applicants cannot modify or submit applicatio..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/delete_items ( 622067...f6d60d )

by Tristan

created 2018-10-30 16:43 UTC

JobPoster::isOpen() A

↳ Parent: JobPoster

Complexity

Conditions	3
Paths	3

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	0
crap	12

<?php

/**
 * Created by Reliese Model.
 * Date: Thu, 12 Jul 2018 22:39:27 +0000.
 */


namespace App\Models;

use App\Events\JobSaved;
use App\Models\JobApplication;
use Illuminate\Notifications\Notifiable;
use Jenssegers\Date\Date;

/**
 * Class JobPoster
 *
 * @property int $id
 * @property int $job_term_id
 * @property int $term_qty
 * @property \Jenssegers\Date\Date $open_date_time
 * @property \Jenssegers\Date\Date $close_date_time
 * @property \Jenssegers\Date\Date $start_date_time
 * @property int $department_id
 * @property int $province_id
 * @property int $salary_min
 * @property int $salary_max
 * @property int $noc
 * @property string $classification
 * @property int $security_clearance_id
 * @property int $language_requirement_id
 * @property int $manager_id
 * @property boolean $published
 * @property \Jenssegers\Date\Date $created_at
 * @property \Jenssegers\Date\Date $updated_at
 *
 * @property int $submitted_applications_count
 * @property int $days_remaining
 *
 * @property \App\Models\Lookup\Department $department
 * @property \App\Models\Lookup\JobTerm $job_term
 * @property \App\Models\Lookup\LanguageRequirement $language_requirement
 * @property \App\Models\Manager $manager
 * @property \App\Models\Lookup\Province $province
 * @property \App\Models\Lookup\SecurityClearance $security_clearance
 * @property \Illuminate\Database\Eloquent\Collection $criteria
 * @property \Illuminate\Database\Eloquent\Collection $job_applications
 * @property \Illuminate\Database\Eloquent\Collection $job_poster_key_tasks
 * @property \Illuminate\Database\Eloquent\Collection $job_poster_questions
 * @property \Illuminate\Database\Eloquent\Collection $job_poster_translations
 * @property \Illuminate\Database\Eloquent\Collection $submitted_applications
 *
 * Localized Properties:
 * @property string $city
 * @property string $title
 * @property string $impact
 * @property string $branch
 * @property string $division
 * @property string $education
 *
 * Methods
 * @method boolean isOpen()

 */

class JobPoster extends BaseModel {


    use \Dimsav\Translatable\Translatable;

    use Notifiable;


    public $translatedAttributes = ['city', 'title', 'impact', 'branch', 'division', 'education'];
    protected $casts = [
        'job_term_id' => 'int',
        'department_id' => 'int',
        'province_id' => 'int',
        'salary_min' => 'int',
        'salary_max' => 'int',
        'noc' => 'int',
        'security_clearance_id' => 'int',
        'language_requirement_id' => 'int',
        'manager_id' => 'int',
        'published' => 'boolean'
    ];
    protected $dates = [
        'open_date_time',
        'close_date_time',
        'start_date_time'
    ];
    protected $fillable = [
        'job_term_id',
        'term_qty',
        'open_date_time',
        'close_date_time',
        'start_date_time',
        'department_id',
        'province_id',
        'salary_min',
        'salary_max',
        'noc',
        'classification',
        'security_clearance_id',
        'language_requirement_id',
        'published'
    ];
    protected $withCount = ['submitted_applications'];

    protected $dispatchesEvents = [
        'saved' => JobSaved::class,
    ];

    public function department() {

        return $this->belongsTo(\App\Models\Lookup\Department::class);
    }

    public function job_term() {

        return $this->belongsTo(\App\Models\Lookup\JobTerm::class);
    }

    public function language_requirement() {

        return $this->belongsTo(\App\Models\Lookup\LanguageRequirement::class);
    }

    public function manager() {

        return $this->belongsTo(\App\Models\Manager::class);
    }

    public function province() {

        return $this->belongsTo(\App\Models\Lookup\Province::class);
    }

    public function security_clearance() {

        return $this->belongsTo(\App\Models\Lookup\SecurityClearance::class);
    }

    public function criteria() {

        return $this->hasMany(\App\Models\Criteria::class);
    }

    public function job_applications() {

        return $this->hasMany(\App\Models\JobApplication::class);
    }

    public function job_poster_key_tasks() {

        return $this->hasMany(\App\Models\JobPosterKeyTask::class);
    }

    public function job_poster_questions() {

        return $this->hasMany(\App\Models\JobPosterQuestion::class);
    }

    public function job_poster_translations() {

        return $this->hasMany(\App\Models\JobPosterTranslation::class);
    }

    // Artificial Relations

    public function submitted_applications() {

        return $this->hasMany(\App\Models\JobApplication::class)->whereHas('application_status', function ($query) {

            $query->where('name', '!=', 'draft');
        });
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    // Accessors

    public function getDaysRemainingAttribute() {

        $days_remaining = $this->close_date_time->diffInDays(Date::now());
        debugbar()->info($days_remaining);
        return $days_remaining;
    }

    // Methods

    public function isOpen() {

        return $this->published
            && $this->open_date_time->isPast()
            && $this->close_date_time->isFuture();
    }

}


1			<?php
2
3			/**
4			* Created by Reliese Model.
5			* Date: Thu, 12 Jul 2018 22:39:27 +0000.
6			*/
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing @link tag in file comment Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
7
8			namespace App\Models;
9
10			use App\Events\JobSaved;
11			use App\Models\JobApplication;
12			use Illuminate\Notifications\Notifiable;
13			use Jenssegers\Date\Date;
14
15			/**
16			* Class JobPoster
17			*
18			* @property int $id
19			* @property int $job_term_id
20			* @property int $term_qty
21			* @property \Jenssegers\Date\Date $open_date_time
22			* @property \Jenssegers\Date\Date $close_date_time
23			* @property \Jenssegers\Date\Date $start_date_time
24			* @property int $department_id
25			* @property int $province_id
26			* @property int $salary_min
27			* @property int $salary_max
28			* @property int $noc
29			* @property string $classification
30			* @property int $security_clearance_id
31			* @property int $language_requirement_id
32			* @property int $manager_id
33			* @property boolean $published
34			* @property \Jenssegers\Date\Date $created_at
35			* @property \Jenssegers\Date\Date $updated_at
36			*
37			* @property int $submitted_applications_count
38			* @property int $days_remaining
39			*
40			* @property \App\Models\Lookup\Department $department
41			* @property \App\Models\Lookup\JobTerm $job_term
42			* @property \App\Models\Lookup\LanguageRequirement $language_requirement
43			* @property \App\Models\Manager $manager
44			* @property \App\Models\Lookup\Province $province
45			* @property \App\Models\Lookup\SecurityClearance $security_clearance
46			* @property \Illuminate\Database\Eloquent\Collection $criteria
47			* @property \Illuminate\Database\Eloquent\Collection $job_applications
48			* @property \Illuminate\Database\Eloquent\Collection $job_poster_key_tasks
49			* @property \Illuminate\Database\Eloquent\Collection $job_poster_questions
50			* @property \Illuminate\Database\Eloquent\Collection $job_poster_translations
51			* @property \Illuminate\Database\Eloquent\Collection $submitted_applications
52			*
53			* Localized Properties:
54			* @property string $city
55			* @property string $title
56			* @property string $impact
57			* @property string $branch
58			* @property string $division
59			* @property string $education
60			*
61			* Methods
62			* @method boolean isOpen()
			0 ignored issues – show Coding Style introduced 2018-10-30 16:49 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 3 spaces but found 1 Loading history...
63			*/
			0 ignored issues – show Coding Style introduced 2018-10-30 16:49 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2018-10-30 16:49 UTC by Report Bug Copy Issue Report Missing @package tag in class comment Loading history... Coding Style introduced 2018-10-30 16:49 UTC by Report Bug Copy Issue Report Missing @author tag in class comment Loading history... Coding Style introduced 2018-10-30 16:49 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2018-10-30 16:49 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
64			class JobPoster extends BaseModel {
			0 ignored issues – show Coding Style introduced 2018-08-28 01:31 UTC by Report Bug Copy Issue Report Opening brace of a class must be on the line after the definition Loading history...
65
66			use \Dimsav\Translatable\Translatable;
			0 ignored issues – show introduced 2018-07-26 07:01 UTC by Report Bug Copy Issue Report The trait `Dimsav\Translatable\Translatable` requires some properties which are not provided by `App\Models\JobPoster`: `$translations`, `$useTranslationFallback`, `$translationModel`, `$localeKey`, `$translationForeignKey` Loading history...
67			use Notifiable;
			0 ignored issues – show introduced 2018-10-12 21:22 UTC by Report Bug Copy Issue Report The trait `Illuminate\Notifications\Notifiable` requires some properties which are not provided by `App\Models\JobPoster`: `$email`, `$phone_number` Loading history...
68
69			public $translatedAttributes = ['city', 'title', 'impact', 'branch', 'division', 'education'];
70			protected $casts = [
71			'job_term_id' => 'int',
72			'department_id' => 'int',
73			'province_id' => 'int',
74			'salary_min' => 'int',
75			'salary_max' => 'int',
76			'noc' => 'int',
77			'security_clearance_id' => 'int',
78			'language_requirement_id' => 'int',
79			'manager_id' => 'int',
80			'published' => 'boolean'
81			];
82			protected $dates = [
83			'open_date_time',
84			'close_date_time',
85			'start_date_time'
86			];
87			protected $fillable = [
88			'job_term_id',
89			'term_qty',
90			'open_date_time',
91			'close_date_time',
92			'start_date_time',
93			'department_id',
94			'province_id',
95			'salary_min',
96			'salary_max',
97			'noc',
98			'classification',
99			'security_clearance_id',
100			'language_requirement_id',
101			'published'
102			];
103			protected $withCount = ['submitted_applications'];
104
105			protected $dispatchesEvents = [
106			'saved' => JobSaved::class,
107			];
108
109			public function department() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function department() Loading history...
110			return $this->belongsTo(\App\Models\Lookup\Department::class);
111			}
112
113			public function job_term() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function job_term() Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Public method name "JobPoster::job_term" is not in camel caps format Loading history...
114			return $this->belongsTo(\App\Models\Lookup\JobTerm::class);
115			}
116
117			public function language_requirement() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function language_requirement() Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Public method name "JobPoster::language_requirement" is not in camel caps format Loading history...
118			return $this->belongsTo(\App\Models\Lookup\LanguageRequirement::class);
119			}
120
121			public function manager() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function manager() Loading history...
122			return $this->belongsTo(\App\Models\Manager::class);
123			}
124
125			public function province() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function province() Loading history...
126			return $this->belongsTo(\App\Models\Lookup\Province::class);
127			}
128
129			public function security_clearance() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function security_clearance() Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Public method name "JobPoster::security_clearance" is not in camel caps format Loading history...
130			return $this->belongsTo(\App\Models\Lookup\SecurityClearance::class);
131			}
132
133			public function criteria() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function criteria() Loading history...
134			return $this->hasMany(\App\Models\Criteria::class);
135			}
136
137			public function job_applications() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function job_applications() Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Public method name "JobPoster::job_applications" is not in camel caps format Loading history...
138			return $this->hasMany(\App\Models\JobApplication::class);
139			}
140
141			public function job_poster_key_tasks() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function job_poster_key_tasks() Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Public method name "JobPoster::job_poster_key_tasks" is not in camel caps format Loading history...
142			return $this->hasMany(\App\Models\JobPosterKeyTask::class);
143			}
144
145			public function job_poster_questions() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function job_poster_questions() Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Public method name "JobPoster::job_poster_questions" is not in camel caps format Loading history...
146			return $this->hasMany(\App\Models\JobPosterQuestion::class);
147			}
148
149			public function job_poster_translations() {
			0 ignored issues – show Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Missing doc comment for function job_poster_translations() Loading history... Coding Style introduced 2018-08-25 20:46 UTC by Report Bug Copy Issue Report Public method name "JobPoster::job_poster_translations" is not in camel caps format Loading history...
150			return $this->hasMany(\App\Models\JobPosterTranslation::class);
151			}
152
153			// Artificial Relations
154
155			public function submitted_applications() {
			0 ignored issues – show Coding Style introduced 2018-10-22 20:15 UTC by Report Bug Copy Issue Report You must use "/**" style comments for a function comment Loading history... Coding Style introduced 2018-10-22 20:15 UTC by Report Bug Copy Issue Report Public method name "JobPoster::submitted_applications" is not in camel caps format Loading history...
156			return $this->hasMany(\App\Models\JobApplication::class)->whereHas('application_status', function ($query) {
			0 ignored issues – show Coding Style introduced 2018-10-22 20:15 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
157			$query->where('name', '!=', 'draft');
158			});
			0 ignored issues – show Coding Style introduced 2018-10-22 20:15 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
159			}
160
161			// Accessors
162
163			public function getDaysRemainingAttribute() {
			0 ignored issues – show Coding Style introduced 2018-10-22 20:15 UTC by Report Bug Copy Issue Report You must use "/**" style comments for a function comment Loading history...
164			$days_remaining = $this->close_date_time->diffInDays(Date::now());
165			debugbar()->info($days_remaining);
166			return $days_remaining;
167			}
168
169			// Methods
170
171			public function isOpen() {
			0 ignored issues – show Coding Style introduced 2018-10-30 16:49 UTC by Report Bug Copy Issue Report You must use "/**" style comments for a function comment Loading history...
172			return $this->published
173			&& $this->open_date_time->isPast()
174			&& $this->close_date_time->isFuture();
175			}
176
177			}
178

GCTC-NTGC / TalentCloud

Push — feature/delete_items ( 622067...f6d60d )

JobPoster::isOpen() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like