SkillsController::update() - Code Metrics - Inspection of "Skill Declarations submit with ajax" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — dev (#515)

by Tristan
created 2018-12-11 16:30 UTC
SkillsController::update() A

↳ Parent: SkillsController
Complexity

Conditions	1
Paths	1
Size

Total Lines	5
Code Lines	2
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	2
Importance

Changes
Metric	Value
eloc	2
dl	0
loc	5
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	2
<?php


namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Log;
use Illuminate\Http\Request;
use App\Models\Skill;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\SkillStatus;
use App\Models\SkillDeclaration;
use App\Models\Applicant;
use App\Http\Controllers\Controller;
use App\Services\Validation\BulkSkillDeclarationValidator;
use App\Services\Validation\SkillDeclarationValidator;

class SkillsController extends Controller

{

    /**
     * Display the Skills page associated with the applicant.
     *
     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function show(Applicant $applicant)
    public function show(/** @scrutinizer ignore-unused */ Applicant $applicant)
    {
        //

    }

    /**
     * Show the form for editing the applicant's skills
     *
     * @param  Request  $request

     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function edit(Request $request, Applicant $applicant)
    {
        $skills = Skill::all();

        return view('applicant/profile_03_skills', [

            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_skills'),
            'form_submit_action' => route('profile.skills.update', $applicant),
            'form_submit_action' => route('profile.skills.update', /** @scrutinizer ignore-type */ $applicant),
            'skills' => $skills
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    /**
     * Update the applicant's profile in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function updateAll(Request $request, Applicant $applicant)
    {
        $input = $request->input();

        $validator = new BulkSkillDeclarationValidator($applicant, $input);
        $validator->validate($input);

        $skillDeclarations = $request->input('skill_declarations');
        $claimedStatusId = SkillStatus::where('name', 'claimed')->firstOrFail()->id;

        //Delete old skill declarations that weren't resubmitted
        //Note: this must be done before adding new ones, so we don't delete
        // them right after adding them
        foreach($applicant->skill_declarations as $oldDeclaration) {

            //Check if none were resubmitted, or if this specific one wasn't
            $type = $oldDeclaration->skill->skill_type->name;
            if (!isset($skillDeclarations['old']) ||
                !isset($skillDeclarations['old'][$type]) ||

                !isset($skillDeclarations['old'][$type][$oldDeclaration->id])) {

                $oldDeclaration->delete();
            }
        }

        //Save new skill declarartions
        if (isset($skillDeclarations['new'])) {
            foreach($skillDeclarations['new'] as $skillType => $typeInput) {

                foreach($typeInput as $skillDeclarationInput) {

                    $skillDeclaration = new SkillDeclaration();
                    $skillDeclaration->applicant_id = $applicant->id;
                    $skillDeclaration->skill_id = $skillDeclarationInput['skill_id'];
                    $skillDeclaration->skill_status_id = $claimedStatusId;
                    $skillDeclaration->fill([

                        'description' => $skillDeclarationInput['description'],
                        'skill_level_id' => isset($skillDeclarationInput['skill_level_id']) ? $skillDeclarationInput['skill_level_id'] : null,
                    ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                    $skillDeclaration->save();

                    $referenceIds = $this->getRelativeIds($skillDeclarationInput, 'references');
                    $skillDeclaration->references()->sync($referenceIds);

                    $sampleIds = $this->getRelativeIds($skillDeclarationInput, 'samples');
                    $skillDeclaration->work_samples()->sync($sampleIds);
                }
            }
        }

        //Update old declarations
        if (isset($skillDeclarations['old'])) {
            foreach($skillDeclarations['old'] as $skillType => $typeInput) {

                foreach($typeInput as $id=>$skillDeclarationInput) {

                    //Ensure this declaration belongs to this applicant
                    $skillDeclaration = $applicant->skill_declarations->firstWhere('id', $id);
                    if ($skillDeclaration != null) {
                        //skill_id and skill_status cannot be changed
                        $skillDeclaration->fill([

                            'description' => $skillDeclarationInput['description'],
                            'skill_level_id' => isset($skillDeclarationInput['skill_level_id']) ? $skillDeclarationInput['skill_level_id'] : null,
                        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
                        $skillDeclaration->save();

                        $referenceIds = $this->getRelativeIds($skillDeclarationInput, 'references');
                        $skillDeclaration->references()->sync($referenceIds);

                        $sampleIds = $this->getRelativeIds($skillDeclarationInput, 'samples');
                        $skillDeclaration->work_samples()->sync($sampleIds);
                    } else {
                        Log::warning('Applicant '.$applicant->id.' attempted to update skill declaration with invalid id '.$id);
                    }
                }
            }
        }


        return redirect( route('profile.skills.edit', $applicant) );
        return redirect( route('profile.skills.edit', /** @scrutinizer ignore-type */ $applicant) );
    }

    /**
     * Create the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @return \Illuminate\Http\Response

     */
    public function create(Request $request)
    {
        $this->authorize('create', SkillDeclaration::class);

        $user = $request->user();
        $applicant = $user->applicant;

        //Get the default claim status id
        $claimedStatusId = SkillStatus::where('name', 'claimed')->firstOrFail()->id;

        // Create a new Skill Declaration
        // But don't save, as it hasn't been validated yet
        $skillDeclaration = new SkillDeclaration();
        $skillDeclaration->applicant_id = $applicant->id;
        $skillDeclaration->skill_id = $request->input('skill_id');
        $skillDeclaration->skill_status_id = $claimedStatusId;

        //Update variable fields in skill declaration
        return $this->updateSkillDeclaration($request, $skillDeclaration);

    }

    /**
     * Update the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\SkillDeclaration  $skillDeclaration

     * @return \Illuminate\Http\Response

     */
    public function update(Request $request, SkillDeclaration $skillDeclaration)
    {
        $this->authorize('update', $skillDeclaration);

        return $this->updateSkillDeclaration($request, $skillDeclaration);

    }

    protected function updateSkillDeclaration(Request $request, SkillDeclaration $skillDeclaration)

    {
        //Fill variable values
        $skillDeclaration->fill([

            'description' => $request->input('description'),
            'skill_level_id' => $request->input('skill_level_id'),
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

        //Validate before saving
        $validator = new SkillDeclarationValidator($request->user()->applicant);
        $validator->validate($skillDeclaration);

        //Save this skill declaration
        $skillDeclaration->save();

        //Attach relatives
        $referenceIds = $this->getRelativeIds($request->input(), 'references');
        $skillDeclaration->references()->sync($referenceIds);

        $sampleIds = $this->getRelativeIds($request->input(), 'samples');
        $skillDeclaration->work_samples()->sync($sampleIds);

        // If an ajax request, return the new object
        if($request->ajax()) {

            $skillDeclaration->load('references');
            $skillDeclaration->load('work_samples');
            $skillDeclaration->load('skill');
            $skillDeclaration->load('skill_status');
            return $skillDeclaration->toJson();
        }

        return redirect()->back();
    }

    /**
     * Delete the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\SkillDeclaration  $skillDeclaration

     * @return \Illuminate\Http\Response

     */
    public function destroy(Request $request, SkillDeclaration $skillDeclaration)
    {
        $this->authorize('delete', $skillDeclaration);
        $skillDeclaration->delete();

        if($request->ajax()) {

            return ['message' => 'Skill deleted'];

        }

        return redirect()->back();

    }

}

GCTC-NTGC / TalentCloud

Pull Request — dev (#515)

SkillsController::update() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
