App\Services\Validation\SkillDeclarationValidator

Complexity

Total Complexity

2

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	validate()	0	28	1

<?php

Missing file doc comment

namespace App\Services\Validation;

use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;
use App\Models\Skill;
use App\Models\SkillDeclaration;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\SkillStatus;
use App\Models\Applicant;
use App\Services\Validation\Rules\UniqueApplicantSkillRule;

class SkillDeclarationValidator

Missing doc comment for class SkillDeclarationValidator

{

    protected $applicant;
    protected $skill_ids;
    protected $skill_status_ids;
    protected $skill_level_ids;


    public function __construct(Applicant $applicant)

Missing doc comment for function __construct()

    {
        $this->applicant = $applicant;
        $this->skill_ids = Skill::all()->pluck('id');
        $this->skill_status_ids = SkillStatus::all()->pluck('id');
        $this->skill_level_ids = SkillLevel::all()->pluck('id');

    }

    public function validate(SkillDeclaration $skillDeclaration)

Missing doc comment for function validate()

    {
        $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);

        //This array is reset every time because applicants table can change frequently
        $applicant_ids = Applicant::all()->pluck('id');

        //Validate basic data is filled in
        Validator::make($skillDeclaration->getAttributes(), [

The opening parenthesis of a multi-line function call should be the last content on the line.

            'skill_id' => [
                'required',
                Rule::in($this->skill_ids->toArray()),
                $uniqueSkillRule,
            ],
            'applicant_id' => [
                'required',
                Rule::in($applicant_ids->toArray()),
            ],
            'skill_status_id' => [
                'required',
                Rule::in($this->skill_status_ids->toArray()),
            ],
            'skill_level_id' => [
                'required',
                Rule::in($this->skill_level_ids->toArray()),
            ],
            'description' => 'string|required',
        ])->validate();

For multi-line function calls, the closing parenthesis should be on a new line.

    }
}