JobPolicy::delete() - Code Metrics - Inspection of "Merge branch 'dev' into feature/hidden-job-option" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/hidden-job-option ( da89d6...67bc2a )

by Yonathan

created 2020-02-06 21:17 UTC

JobPolicy::delete() A

↳ Parent: JobPolicy

Complexity

Conditions	3
Paths	3

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	7
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	2

<?php

namespace App\Policies;

use App\Models\User;
use App\Models\JobPoster;
use App\Policies\BasePolicy;
use Illuminate\Support\Facades\Log;

class JobPolicy extends BasePolicy
{

    /**
     * Determine whether the user can view the job poster.
     *
     * @param \App\Models\?User     $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return mixed
     */
    public function view(?User $user, JobPoster $jobPoster)
    {
        // Anyone can view a published job
        // Only the manager that created it can view an unpublished job
        // Hr Advisors can view all jobs.
        return $jobPoster->status() == 'published' ||
            $jobPoster->status() == 'closed' ||
            ($user &&
                $user->isManager() &&
                $jobPoster->manager->user_id == $user->id) ||
            ($user &&
                $user->isHrAdvisor() &&
                $user->hr_advisor->department_id === $jobPoster->department_id &&
                $jobPoster->isVisibleToHr());
    }

    /**
     * Any user is permitted to request a list of jobs,
     * but only the jobs they are permitted to *view* should be returned.
     *
     * @param \App\Models\?User $user User object making the request.
     * @return boolean
     */
    public function viewAny(?User $user)
    {
        return true;
    }

    /**
     * Determine whether the user can create job posters.
     *
     * @param  \App\Models\User $user User to test against.
     * @return mixed
     */
    public function create(User $user)
    {
        // Any manager can create a new job poster.
        return $user->isManager();
    }

    /**
     * Determine whether the user can update the job poster.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return mixed
     */
    public function update(User $user, JobPoster $jobPoster)
    {
        // Only managers can edit jobs, and only their own, managers can't publish jobs or edit published jobs.
        return $user->isManager() &&
            $jobPoster->manager->user->id == $user->id &&
            !$jobPoster->published;
    }

    /**
     * Determine whether the user can delete the job poster.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     *
     * @return boolean
     */
    public function delete(User $user, JobPoster $jobPoster): bool
    {
        // Jobs can only be deleted when they're in the 'draft'
        // state, and only by managers that created them.
        return $user->isManager() &&
            $jobPoster->manager->user->id == $user->id &&
            !$jobPoster->published;
    }

    /**
     * Determine whether the user can submit a job poster for review.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return mixed
     */
    public function submitForReview(User $user, JobPoster $jobPoster)
    {
        // Only upgradedManagers can submit jobs for review, only their own jobs, and only if they're still drafts.
        // NOTE: this is one of the only permissions to require an upgradedManager, as opposed to a demoManager.
        return $user->isUpgradedManager() &&
            $jobPoster->manager->user->id == $user->id &&
            $jobPoster->status() === 'draft';
    }
    /**
     * Determine whether the user can review applications to the job poster.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return mixed
     */
    public function reviewApplicationsFor(User $user, JobPoster $jobPoster)
    {
        // Managers can only review applications their own jobs.
        // HR Advisors can review applications for jobs they manage.
        // The job must always be closed.
        $authManager = $user->isManager() && $jobPoster->manager->user->id == $user->id;
        $authHr = $user->isHrAdvisor() && $this->manage($user, $jobPoster);

        return $jobPoster->isClosed() && ($authManager || $authHr);
    }

    /**
     * Determine whether the user is a Manager or an HR Advisor with permission to manage this job.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return boolean
     */
    public function manage(User $user, JobPoster $jobPoster)
    {
        return ($user->isManager() &&
            $jobPoster->manager->user->id == $user->id) ||
            ($user->isHrAdvisor()
                && $this->view($user, $jobPoster)
                && $user->hr_advisor->claimed_job_ids->contains($jobPoster->id));
    }

    /**
     * Determine whether the user can view the comments.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return boolean
     */
    public function viewComments(User $user, JobPoster $jobPoster): bool
    {
        // Only the manager that created the job can view the comment.
        // Only Hr advisors who have claimed a job can view the comments.
        return $this->manage($user, $jobPoster);
    }

    /**
     * Determine whether the user can create a comment
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return boolean
     */
    public function storeComment(User $user, JobPoster $jobPoster): bool
    {
        // Only the manager that created the job can view the comment.
        // Only Hr advisors who have claimed a job can view the comments.
        return $this->viewComments($user, $jobPoster);
    }

    /**
     * Determine whether the user can 'claim' this job.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return boolean
     */
    public function claim(User $user, JobPoster $jobPoster): bool
    {
        return $user->isHrAdvisor() && $this->view($user, $jobPoster);
    }

    /**
     * Determine whether the user can 'unclaim' this job.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return boolean
     */
    public function unClaim(User $user, JobPoster $jobPoster): bool
    {
        return $this->claim($user, $jobPoster);
    }

    /**
     * Determine whether the user can view assessment plan.
     *
     * @param \App\Models\User      $user      User object making the request.
     * @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
     * @return boolean
     */
    public function viewAssessmentPlan(User $user, JobPoster $jobPoster): bool
    {
        return $user->isAdmin() ||
        $user->isManager() && $jobPoster->manager->user_id === $user->id ||
        $user->isHrAdvisor() && $jobPoster->hr_advisors->contains('user_id', $user->id);
    }
}


1			<?php
2
3			namespace App\Policies;
4
5			use App\Models\User;
6			use App\Models\JobPoster;
7			use App\Policies\BasePolicy;
8			use Illuminate\Support\Facades\Log;
9
10			class JobPolicy extends BasePolicy
11			{
12
13			/**
14			* Determine whether the user can view the job poster.
15			*
16			* @param \App\Models\?User $user User object making the request.
17			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
18			* @return mixed
19			*/
20			public function view(?User $user, JobPoster $jobPoster)
21			{
22			// Anyone can view a published job
23			// Only the manager that created it can view an unpublished job
24			// Hr Advisors can view all jobs.
25			return $jobPoster->status() == 'published' \|\|
26			$jobPoster->status() == 'closed' \|\|
27			($user &&
28			$user->isManager() &&
29			$jobPoster->manager->user_id == $user->id) \|\|
30			($user &&
31			$user->isHrAdvisor() &&
32			$user->hr_advisor->department_id === $jobPoster->department_id &&
33			$jobPoster->isVisibleToHr());
34			}
35
36			/**
37			* Any user is permitted to request a list of jobs,
38			* but only the jobs they are permitted to view should be returned.
39			*
40			* @param \App\Models\?User $user User object making the request.
41			* @return boolean
42			*/
43			public function viewAny(?User $user)
44			{
45			return true;
46			}
47
48			/**
49			* Determine whether the user can create job posters.
50			*
51			* @param \App\Models\User $user User to test against.
52			* @return mixed
53			*/
54			public function create(User $user)
55			{
56			// Any manager can create a new job poster.
57			return $user->isManager();
58			}
59
60			/**
61			* Determine whether the user can update the job poster.
62			*
63			* @param \App\Models\User $user User object making the request.
64			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
65			* @return mixed
66			*/
67			public function update(User $user, JobPoster $jobPoster)
68			{
69			// Only managers can edit jobs, and only their own, managers can't publish jobs or edit published jobs.
70			return $user->isManager() &&
71			$jobPoster->manager->user->id == $user->id &&
72			!$jobPoster->published;
73			}
74
75			/**
76			* Determine whether the user can delete the job poster.
77			*
78			* @param \App\Models\User $user User object making the request.
79			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
80			*
81			* @return boolean
82			*/
83			public function delete(User $user, JobPoster $jobPoster): bool
84			{
85			// Jobs can only be deleted when they're in the 'draft'
86			// state, and only by managers that created them.
87			return $user->isManager() &&
88			$jobPoster->manager->user->id == $user->id &&
89			!$jobPoster->published;
90			}
91
92			/**
93			* Determine whether the user can submit a job poster for review.
94			*
95			* @param \App\Models\User $user User object making the request.
96			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
97			* @return mixed
98			*/
99			public function submitForReview(User $user, JobPoster $jobPoster)
100			{
101			// Only upgradedManagers can submit jobs for review, only their own jobs, and only if they're still drafts.
102			// NOTE: this is one of the only permissions to require an upgradedManager, as opposed to a demoManager.
103			return $user->isUpgradedManager() &&
104			$jobPoster->manager->user->id == $user->id &&
105			$jobPoster->status() === 'draft';
106			}
107			/**
108			* Determine whether the user can review applications to the job poster.
109			*
110			* @param \App\Models\User $user User object making the request.
111			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
112			* @return mixed
113			*/
114			public function reviewApplicationsFor(User $user, JobPoster $jobPoster)
115			{
116			// Managers can only review applications their own jobs.
117			// HR Advisors can review applications for jobs they manage.
118			// The job must always be closed.
119			$authManager = $user->isManager() && $jobPoster->manager->user->id == $user->id;
120			$authHr = $user->isHrAdvisor() && $this->manage($user, $jobPoster);
121
122			return $jobPoster->isClosed() && ($authManager \|\| $authHr);
123			}
124
125			/**
126			* Determine whether the user is a Manager or an HR Advisor with permission to manage this job.
127			*
128			* @param \App\Models\User $user User object making the request.
129			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
130			* @return boolean
131			*/
132			public function manage(User $user, JobPoster $jobPoster)
133			{
134			return ($user->isManager() &&
135			$jobPoster->manager->user->id == $user->id) \|\|
136			($user->isHrAdvisor()
137			&& $this->view($user, $jobPoster)
138			&& $user->hr_advisor->claimed_job_ids->contains($jobPoster->id));
139			}
140
141			/**
142			* Determine whether the user can view the comments.
143			*
144			* @param \App\Models\User $user User object making the request.
145			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
146			* @return boolean
147			*/
148			public function viewComments(User $user, JobPoster $jobPoster): bool
149			{
150			// Only the manager that created the job can view the comment.
151			// Only Hr advisors who have claimed a job can view the comments.
152			return $this->manage($user, $jobPoster);
153			}
154
155			/**
156			* Determine whether the user can create a comment
157			*
158			* @param \App\Models\User $user User object making the request.
159			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
160			* @return boolean
161			*/
162			public function storeComment(User $user, JobPoster $jobPoster): bool
163			{
164			// Only the manager that created the job can view the comment.
165			// Only Hr advisors who have claimed a job can view the comments.
166			return $this->viewComments($user, $jobPoster);
167			}
168
169			/**
170			* Determine whether the user can 'claim' this job.
171			*
172			* @param \App\Models\User $user User object making the request.
173			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
174			* @return boolean
175			*/
176			public function claim(User $user, JobPoster $jobPoster): bool
177			{
178			return $user->isHrAdvisor() && $this->view($user, $jobPoster);
179			}
180
181			/**
182			* Determine whether the user can 'unclaim' this job.
183			*
184			* @param \App\Models\User $user User object making the request.
185			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
186			* @return boolean
187			*/
188			public function unClaim(User $user, JobPoster $jobPoster): bool
189			{
190			return $this->claim($user, $jobPoster);
191			}
192
193			/**
194			* Determine whether the user can view assessment plan.
195			*
196			* @param \App\Models\User $user User object making the request.
197			* @param \App\Models\JobPoster $jobPoster Job Poster object being acted upon.
198			* @return boolean
199			*/
200			public function viewAssessmentPlan(User $user, JobPoster $jobPoster): bool
201			{
202			return $user->isAdmin() \|\|
203			$user->isManager() && $jobPoster->manager->user_id === $user->id \|\|
204			$user->isHrAdvisor() && $jobPoster->hr_advisors->contains('user_id', $user->id);
205			}
206			}
207

GCTC-NTGC / TalentCloud

Push — feature/hidden-job-option ( da89d6...67bc2a )

JobPolicy::delete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like