App\Services\Validation\SkillDeclarationValidator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	validator()	0	25	1
A	__construct()	0	6	1
A	validate()	0	3	1

<?php

namespace App\Services\Validation;

use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;
use App\Models\Skill;
use App\Models\SkillDeclaration;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\SkillStatus;
use App\Models\Applicant;
use App\Services\Validation\Rules\UniqueApplicantSkillRule;

class SkillDeclarationValidator
{

    protected $applicant;

Property \App\Services\Validation\SkillDeclarationValidator::$applicant does not have @var annotation.

Missing member variable doc comment

    protected $skill_ids;

Property \App\Services\Validation\SkillDeclarationValidator::$skill_ids does not have @var annotation.

Missing member variable doc comment

    protected $skill_status_ids;

Property \App\Services\Validation\SkillDeclarationValidator::$skill_status_ids does not have @var annotation.

Missing member variable doc comment

    protected $skill_level_ids;

Property \App\Services\Validation\SkillDeclarationValidator::$skill_level_ids does not have @var annotation.

Missing member variable doc comment

    public function __construct(Applicant $applicant)

Missing doc comment for function __construct()

    {
        $this->applicant = $applicant;
        $this->skill_ids = Skill::all()->pluck('id');
        $this->skill_status_ids = SkillStatus::all()->pluck('id');
        $this->skill_level_ids = SkillLevel::all()->pluck('id');

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace

    public function validator(SkillDeclaration $skillDeclaration) {

Method \App\Services\Validation\SkillDeclarationValidator::validator() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function validator()

        $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);

        //Validate basic data is filled in

No space found before comment text; expected "// Validate basic data is filled in" but found "//Validate basic data is filled in"

        $validator = Validator::make($skillDeclaration->getAttributes(), [
            'skill_id' => [
                'required',
                Rule::in($this->skill_ids->toArray()),
                $uniqueSkillRule,
            ],
            'applicant_id' => [
                'required',
                Rule::in([$this->applicant->id]),
            ],
            'skill_status_id' => [
                'required',
                Rule::in($this->skill_status_ids->toArray()),
            ],
            'skill_level_id' => [
                'required',
                Rule::in($this->skill_level_ids->toArray()),
            ],
            'description' => 'required|string',
        ]);
        return $validator;
    }

    public function validate(SkillDeclaration $skillDeclaration)

Method \App\Services\Validation\SkillDeclarationValidator::validate() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function validate()

    {
        return $this->validator($skillDeclaration)->validate();
    }


}