App\Services\Validation\Rules\UniqueApplicantSkillRule

Complexity

Total Complexity

5

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Test Coverage

Coverage

80%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	message()	0	3	1
A	__construct()	0	4	1
A	passes()	0	6	3

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Lang;
use App\Models\Applicant;

class UniqueApplicantSkillRule implements Rule
{

    protected $applicant;

Property \App\Services\Validation\Rules\UniqueApplicantSkillRule::$applicant does not have @var annotation.

Missing member variable doc comment

    protected $skill_declaration_id;

Property \App\Services\Validation\Rules\UniqueApplicantSkillRule::$skill_declaration_id does not have @var annotation.

Missing member variable doc comment

    /**

Doc comment for parameter "$applicant" missing

Doc comment for parameter "$skill_declaration_id" missing

     * Create a new rule instance.
     *
     * @param  App\Models\Applicant  $user

The type App\Services\Validation\Rules\App\Models\Applicant was not found. Did you mean App\Models\Applicant? If so, make sure to prefix the type with \.

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

Doc comment for parameter $user does not match actual variable name $applicant

     * @return void
     */
    public function __construct(Applicant $applicant, $skill_declaration_id = null)

Method \App\Services\Validation\Rules\UniqueApplicantSkillRule::__construct() does not have parameter type hint nor @param annotation for its parameter $skill_declaration_id.

    {
        $this->applicant = $applicant;
        $this->skill_declaration_id = $skill_declaration_id;
    }

    /**
     * This check passes if this applicant has no previous declaration for this skill,
     * or if they are updating a previously existing declaration
     * @param  [type] $attribute [description]

The doc comment [type] at position 0 could not be parsed: Unknown type name '[' at position 0 in [type].

Parameter comment must start with a capital letter

Parameter comment must end with a full stop

     * @param  [type] $value     [description]

Parameter comment must start with a capital letter

Parameter comment must end with a full stop

     * @return [type]            [description]

The doc comment [type] at position 0 could not be parsed: Unknown type name '[' at position 0 in [type].

     */
    public function passes($attribute, $value)

Method \App\Services\Validation\Rules\UniqueApplicantSkillRule::passes() does not have parameter type hint for its parameter $attribute but it should be possible to add it based on @param annotation "[type]".

Method \App\Services\Validation\Rules\UniqueApplicantSkillRule::passes() does not have parameter type hint for its parameter $value but it should be possible to add it based on @param annotation "[type]".

Method \App\Services\Validation\Rules\UniqueApplicantSkillRule::passes() does not have return type hint for its return value but it should be possible to add it based on @return annotation "[type]".

Type hint "[type]" missing for $attribute

Type hint "[type]" missing for $value

    {
        $prev_skills = $this->applicant->skill_declarations->where('skill_id', $value)->pluck('id');

        return $prev_skills->isEmpty() ||
            ($this->skill_declaration_id != null && $prev_skills->contains($this->skill_declaration_id));
    }

    public function message()

Method \App\Services\Validation\Rules\UniqueApplicantSkillRule::message() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function message()

    {
        return Lang::get('validation.user_skill_unique');
    }
}