ApplicantPolicy::managerCanViewApplicant() - Code Metrics - Inspection of "Modified Applicant policy to allow viewing from ap..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/manager_view_app_profi... ( 2cfdc8...dfb5c0 )

by Tristan

created 2018-11-06 22:31 UTC

ApplicantPolicy::managerCanViewApplicant() A

↳ Parent: ApplicantPolicy

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	7
ccs	0
cts	7
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	2

<?php


namespace App\Policies;

use App\Models\User;
use App\Models\Manager;
use App\Models\Applicant;
use App\Models\JobPoster;
use App\Policies\BasePolicy;
use Barryvdh\Debugbar\Facade as Debugbar;

class ApplicantPolicy extends BasePolicy

{

    /**
     * Returns true if $manager owns a job to which $applicant has applied
     * @param  Manager   $manager   [description]

     * @param  Applicant $applicant [description]
     * @return [type]               [description]

     */
    protected function managerCanViewApplicant(Manager $manager, Applicant $applicant) {
        $applicant_id = $applicant->id;
        return JobPoster::where('manager_id', $manager->id)
            ->whereHas('submitted_applications', function ($q) use ($applicant_id){

                $q->where('applicant_id', $applicant_id);
            })
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
            ->get()->isNotEmpty();
    }

    /**
     * Determine whether the user can view the applicant.
     *
     * @param  \App\Models\User  $user

     * @param  \App\Models\Applicant  $applicant

     * @return mixed

     */
    public function view(User $user, Applicant $applicant)
    {
        $authApplicant =  $user->user_role->name === "applicant" &&
            $applicant->user_id === $user->id;
        $authManager = $user->hasRole('manager') && $this->managerCanViewApplicant($user->manager, $applicant);
        return $authApplicant || $authManager;
    }

    /**
     * Determine whether the user can create applicants.
     *
     * @param  \App\Models\User  $user

     * @return mixed

     */
    public function create(User $user)
    public function create(/** @scrutinizer ignore-unused */ User $user)
    {
        //
    }

    /**
     * Determine whether the user can update the applicant.
     *
     * @param  \App\Models\User  $user

     * @param  \App\Models\Applicant  $applicant

     * @return mixed

     */
    public function update(User $user, Applicant $applicant)
    {
        return $user->user_role->name === "applicant" &&
            $applicant->user_id === $user->id;
    }

    /**
     * Determine whether the user can delete the applicant.
     *
     * @param  \App\Models\User  $user

     * @param  \App\Models\Applicant  $applicant

     * @return mixed

     */
    public function delete(User $user, Applicant $applicant)
    public function delete(/** @scrutinizer ignore-unused */ User $user, Applicant $applicant)
    {
        //
    }

    /**
     * Determine whether the user can restore the applicant.
     *
     * @param  \App\Models\User  $user

     * @param  \App\Models\Applicant  $applicant

     * @return mixed

     */
    public function restore(User $user, Applicant $applicant)
    public function restore(/** @scrutinizer ignore-unused */ User $user, Applicant $applicant)
    {
        //
    }

    /**
     * Determine whether the user can permanently delete the applicant.
     *
     * @param  \App\Models\User  $user

     * @param  \App\Models\Applicant  $applicant

     * @return mixed

     */
    public function forceDelete(User $user, Applicant $applicant)
    public function forceDelete(User $user, /** @scrutinizer ignore-unused */ Applicant $applicant)
    {
        //
    }
}


GCTC-NTGC / TalentCloud

Push — feature/manager_view_app_profi... ( 2cfdc8...dfb5c0 )

ApplicantPolicy::managerCanViewApplicant() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like