ApplicantProfileController::show() - Code Metrics - Inspection of "3059632d8472e5ca0213996a5386a5f6e029b428" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Branch — feature/job-builder/work-env-r... (305963)

by Grant

created 2019-07-09 19:05 UTC

ApplicantProfileController::show() A

↳ Parent: ApplicantProfileController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	26
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	2
dl	26
loc	26
ccs	0
cts	7
cp	0
crap	2
rs	9.504
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use App\Models\Lookup\ApplicantProfileQuestion;
use App\Models\Applicant;
use App\Models\ApplicantProfileAnswer;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Hash;
use App\Services\Validation\Requests\UpdateApplicationProfileValidator;

class ApplicantProfileController extends Controller
{
    /**
     * @var string
     */
    protected $answerFormInputName = 'applicantProfileAnswer';

    /**
     * Display the specified resource.
     *
     * @param  \Illuminate\Http\Request $request   Incoming Request object.
     * @param  \App\Models\Applicant    $applicant Incoming Applicant object.
     * @return \Illuminate\Http\Response
     */
    public function show(Request $request, Applicant $applicant)

    {
        /*
         * TODO:
         * Josh, to loop through answers&question data, leverage this data structure:
         * applicant
         *     [applicant_profile_answers]
         *         answer
         *         applicant_profile_question
         *             id
         *             value // The question text
         *             description // Question description text
         */

        return view(
            'manager/applicant_profile',
            [
                // Localization Strings.
                'profile' => Lang::get('manager/applicant_profile'), // Change text
                // User Data.
                'user' => $applicant->user,
                'applicant' => $applicant,
                'profile_photo_url' => '/images/user.png', // TODO: get real photos.
            ]
        );
    }

    /**
     * Show the form for editing the logged-in applicant's profile
     *
     * @param  \Illuminate\Http\Request $request Incoming request.
     * @return \Illuminate\Http\Response
     */
    public function editAuthenticated(Request $request)
    {
        $applicant = $request->user()->applicant;
        return redirect(route('profile.about.edit', $applicant));
    }

    /**
     * Show the form for editing an applicant profile
     *
     * @param  \Illuminate\Http\Request $request   Incoming request object.
     * @param  \App\Models\Applicant    $applicant Applicant to view and edit.
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, Applicant $applicant)

    {
        $profileQuestions = ApplicantProfileQuestion::all();

        $profileText = Lang::get('applicant/applicant_profile');

        $profileQuestionForms = [];
        foreach ($profileQuestions as $question) {
            $answerObj = $applicant->applicant_profile_answers
                ->where('applicant_profile_question_id', $question->id)->first();
            $answer = $answerObj ? $answerObj->answer : null;

            $formValues = [
                'id' => $question->id,
                'question' => $question->question,
                'description' => $question->description,
                'answer' => $answer,
                'answer_label' => $profileText['about_section']['answer_label'],
                'input_name' => $this->answerFormInputName.'['.$question->id.']'
            ];
            array_push($profileQuestionForms, $formValues);
        }

        return view(
            'applicant/profile_01_about',
            [
                // Localized strings.
                'profile' => $profileText,
                // Applicant Profile Questions.
                'applicant_profile_questions' => $profileQuestionForms,
                // User Data.
                'user' => $applicant->user,
                'applicant' => $applicant,
                'profile_photo_url' => '/images/user.png', // TODO: get real photos.
                'form_submit_action' => route('profile.about.update', $applicant)
            ]
        );
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request   Incoming request.
     * @param  \App\Models\Applicant    $applicant Applicant object to update.
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, Applicant $applicant)
    {
        $questions = ApplicantProfileQuestion::all();

        $validator = new UpdateApplicationProfileValidator($applicant);
        $validator->validate($request->all());

        foreach ($questions as $question) {
            $answerName = $this->answerFormInputName . '.' . $question->id;
            if ($request->has($answerName)) {
                $answer = ApplicantProfileAnswer::where(
                    [
                        'applicant_id' => $applicant->id,
                        'applicant_profile_question_id' => $question->id
                    ]
                )->first();
                if ($answer == null) {
                    $answer = new ApplicantProfileAnswer();
                    $answer->applicant_id =$applicant->id;
                    $answer->applicant_profile_question_id = $question->id;
                }
                $answer->answer = $request->input($answerName);
                $answer->save();
            }
        }

        $input = $request->input();
        $applicant->fill(
            [
                'tagline' => $input['tagline'],
                'twitter_username' => $input['twitter_username'],
                'linkedin_url' => $input['linkedin_url'],
            ]
        );
        $applicant->save();

        $user = $applicant->user;
        $user->fill(
            [
                'name' => $input['profile_name'],
                'email' => $input['profile_email'], // TODO make changing email harder!
            ]
        );
        if ($input['new_password']) {
            $user->password =  Hash::make($input['new_password']); // TODO: change password in seperate form!
        }
        $user->save();

        return redirect()->route('profile.about.edit', $applicant);
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use Illuminate\Support\Facades\Lang;
6		use Illuminate\Http\Request;
7		use App\Models\Lookup\ApplicantProfileQuestion;
8		use App\Models\Applicant;
9		use App\Models\ApplicantProfileAnswer;
10		use App\Http\Controllers\Controller;
11		use Illuminate\Support\Facades\Hash;
12		use App\Services\Validation\Requests\UpdateApplicationProfileValidator;
13
14		class ApplicantProfileController extends Controller
15		{
16		/**
17		* @var string
18		*/
19		protected $answerFormInputName = 'applicantProfileAnswer';
20
21		/**
22		* Display the specified resource.
23		*
24		* @param \Illuminate\Http\Request $request Incoming Request object.
25		* @param \App\Models\Applicant $applicant Incoming Applicant object.
26		* @return \Illuminate\Http\Response
27		*/
28	View Code Duplication	public function show(Request $request, Applicant $applicant)
		0 ignored issues – show Unused Code introduced 2019-07-09 12:53 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2019-07-09 12:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		/*
31		* TODO:
32		* Josh, to loop through answers&question data, leverage this data structure:
33		* applicant
34		* [applicant_profile_answers]
35		* answer
36		* applicant_profile_question
37		* id
38		* value // The question text
39		* description // Question description text
40		*/
41
42		return view(
43		'manager/applicant_profile',
44		[
45		// Localization Strings.
46		'profile' => Lang::get('manager/applicant_profile'), // Change text
47		// User Data.
48		'user' => $applicant->user,
49		'applicant' => $applicant,
50		'profile_photo_url' => '/images/user.png', // TODO: get real photos.
51		]
52		);
53		}
54
55		/**
56		* Show the form for editing the logged-in applicant's profile
57		*
58		* @param \Illuminate\Http\Request $request Incoming request.
59		* @return \Illuminate\Http\Response
60		*/
61		public function editAuthenticated(Request $request)
62		{
63		$applicant = $request->user()->applicant;
64		return redirect(route('profile.about.edit', $applicant));
65		}
66
67		/**
68		* Show the form for editing an applicant profile
69		*
70		* @param \Illuminate\Http\Request $request Incoming request object.
71		* @param \App\Models\Applicant $applicant Applicant to view and edit.
72		* @return \Illuminate\Http\Response
73		*/
74		public function edit(Request $request, Applicant $applicant)
		0 ignored issues – show Unused Code introduced 2019-07-09 12:53 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
75		{
76		$profileQuestions = ApplicantProfileQuestion::all();
77
78		$profileText = Lang::get('applicant/applicant_profile');
79
80		$profileQuestionForms = [];
81		foreach ($profileQuestions as $question) {
82		$answerObj = $applicant->applicant_profile_answers
83		->where('applicant_profile_question_id', $question->id)->first();
84		$answer = $answerObj ? $answerObj->answer : null;
85
86		$formValues = [
87		'id' => $question->id,
88		'question' => $question->question,
89		'description' => $question->description,
90		'answer' => $answer,
91		'answer_label' => $profileText['about_section']['answer_label'],
92		'input_name' => $this->answerFormInputName.'['.$question->id.']'
93		];
94		array_push($profileQuestionForms, $formValues);
95		}
96
97		return view(
98		'applicant/profile_01_about',
99		[
100		// Localized strings.
101		'profile' => $profileText,
102		// Applicant Profile Questions.
103		'applicant_profile_questions' => $profileQuestionForms,
104		// User Data.
105		'user' => $applicant->user,
106		'applicant' => $applicant,
107		'profile_photo_url' => '/images/user.png', // TODO: get real photos.
108		'form_submit_action' => route('profile.about.update', $applicant)
109		]
110		);
111		}
112
113		/**
114		* Update the specified resource in storage.
115		*
116		* @param \Illuminate\Http\Request $request Incoming request.
117		* @param \App\Models\Applicant $applicant Applicant object to update.
118		* @return \Illuminate\Http\Response
119		*/
120		public function update(Request $request, Applicant $applicant)
121		{
122		$questions = ApplicantProfileQuestion::all();
123
124		$validator = new UpdateApplicationProfileValidator($applicant);
125		$validator->validate($request->all());
126
127		foreach ($questions as $question) {
128		$answerName = $this->answerFormInputName . '.' . $question->id;
129		if ($request->has($answerName)) {
130		$answer = ApplicantProfileAnswer::where(
131		[
132		'applicant_id' => $applicant->id,
133		'applicant_profile_question_id' => $question->id
134		]
135		)->first();
136		if ($answer == null) {
137		$answer = new ApplicantProfileAnswer();
138		$answer->applicant_id =$applicant->id;
139		$answer->applicant_profile_question_id = $question->id;
140		}
141		$answer->answer = $request->input($answerName);
142		$answer->save();
143		}
144		}
145
146		$input = $request->input();
147		$applicant->fill(
148		[
149		'tagline' => $input['tagline'],
150		'twitter_username' => $input['twitter_username'],
151		'linkedin_url' => $input['linkedin_url'],
152		]
153		);
154		$applicant->save();
155
156		$user = $applicant->user;
157		$user->fill(
158		[
159		'name' => $input['profile_name'],
160		'email' => $input['profile_email'], // TODO make changing email harder!
161		]
162		);
163		if ($input['new_password']) {
164		$user->password = Hash::make($input['new_password']); // TODO: change password in seperate form!
165		}
166		$user->save();
167
168		return redirect()->route('profile.about.edit', $applicant);
169		}
170		}
171

GCTC-NTGC / TalentCloud

Branch — feature/job-builder/work-env-r... (305963)

ApplicantProfileController::show() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like