UpdateWorkSampleValidator::rules() - Code Metrics - Inspection of "Added validation for saved reference and work samp..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/ajax_ref_and_projects ( edf85c...426ffa )

by Tristan

created 2019-02-04 19:56 UTC

UpdateWorkSampleValidator::rules() A

↳ Parent: UpdateWorkSampleValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	9
dl	0
loc	13
ccs	0
cts	7
cp	0
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php


namespace App\Services\Validation\Requests;

use App\Services\Validation\BaseDataValidator;
use App\Services\Validation\Contracts\DataValidator;
use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;
use App\Models\Lookup\FileType;
use App\Models\Skill;

class UpdateWorkSampleValidator extends BaseDataValidator implements DataValidator

{

    /**
     * Array of all possible FileType ids.
     *
     * @var int[]
     */
    protected $fileTypeIds;

    /**
     * Array of all possible skill ids.
     *
     * @var int[]
     */
    protected $skillIds;

    /**
     * Construct a new UpdateWorkSampleValidator
     */
    public function __construct()
    {
        $this->fileTypeIds = FileType::all()->pluck('id')->toArray();
        $this->skillIds = Skill::all()->pluck('id')->toArray();
    }
    /**
     * Get the validation rules that apply to the request.
     *
     * @return mixed[]
     */
    public function rules() : array
    {
        return [
            // Name validation
            'name' => 'required|string|max:191',
            'file_type_id' => [
                'required',
                Rule::in($this->fileTypeIds)
            ],
            'url' => 'required|url',
            'description' => 'nullable|string',
            'relatives.skills.*.id' => [
                Rule::in($this->skillIds)
            ],
        ];
    }

    /**
     * Returns a validator made with this data
     *
     * @param  mixed[] $data Data to validate.
     * @return Validator

     */
    public function validator(array $data) : \Illuminate\Validation\Validator
    {
        return Validator::make($data, $this->rules());

    }
}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2019-01-15 23:07 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3			namespace App\Services\Validation\Requests;
4
5			use App\Services\Validation\BaseDataValidator;
6			use App\Services\Validation\Contracts\DataValidator;
7			use Illuminate\Support\Facades\Validator;
8			use Illuminate\Validation\Rule;
9			use App\Models\Lookup\FileType;
10			use App\Models\Skill;
11
12			class UpdateWorkSampleValidator extends BaseDataValidator implements DataValidator
			0 ignored issues – show Coding Style introduced 2019-02-04 20:06 UTC by Report Bug Copy Issue Report Missing doc comment for class UpdateWorkSampleValidator Loading history...
13			{
14
15			/**
16			* Array of all possible FileType ids.
17			*
18			* @var int[]
19			*/
20			protected $fileTypeIds;
21
22			/**
23			* Array of all possible skill ids.
24			*
25			* @var int[]
26			*/
27			protected $skillIds;
28
29			/**
30			* Construct a new UpdateWorkSampleValidator
31			*/
32			public function __construct()
33			{
34			$this->fileTypeIds = FileType::all()->pluck('id')->toArray();
35			$this->skillIds = Skill::all()->pluck('id')->toArray();
36			}
37			/**
38			* Get the validation rules that apply to the request.
39			*
40			* @return mixed[]
41			*/
42			public function rules() : array
43			{
44			return [
45			// Name validation
46			'name' => 'required\|string\|max:191',
47			'file_type_id' => [
48			'required',
49			Rule::in($this->fileTypeIds)
50			],
51			'url' => 'required\|url',
52			'description' => 'nullable\|string',
53			'relatives.skills.*.id' => [
54			Rule::in($this->skillIds)
55			],
56			];
57			}
58
59			/**
60			* Returns a validator made with this data
61			*
62			* @param mixed[] $data Data to validate.
63			* @return Validator
			0 ignored issues – show Coding Style introduced 2019-02-04 20:06 UTC by Report Bug Copy Issue Report Tag cannot be grouped with parameter tags in a doc comment Loading history...
64			*/
65			public function validator(array $data) : \Illuminate\Validation\Validator
66			{
67			return Validator::make($data, $this->rules());
			0 ignored issues – show Bug Best Practice introduced 2019-02-04 20:06 UTC by Report Bug Copy Issue Report The expression `return Illuminate\Suppor...($data, $this->rules())` returns the type `Illuminate\Contracts\Validation\Validator` which includes types incompatible with the type-hinted return `Illuminate\Validation\Validator`. Loading history...
68			}
69			}
70

GCTC-NTGC / TalentCloud

Push — feature/ajax_ref_and_projects ( edf85c...426ffa )

UpdateWorkSampleValidator::rules() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like