DemoController::reviewApplications() - Code Metrics - Inspection of "Created a stub component for ReviewApplicants, and..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/review_applications ( ea5c91 )

by Tristan

created 2019-02-13 18:15 UTC

DemoController::reviewApplications() A

↳ Parent: DemoController

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	10
ccs	0
cts	6
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php


namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use App\Models\JobPoster;

class DemoController extends Controller

{
    /**
     * Display a listing of the applicants to specified job.
     *
     * @return \Illuminate\Http\Response
     */
    public function reviewApplications()
    {
        $jobPoster = factory(JobPoster::class)->create();
        return view('manager/review_applications', [

            /*Localization Strings*/
            'jobs_l10n' => Lang::get('manager/job_index'),

            /* Data */
            'job' => $jobPoster,
            'applications' => $jobPoster->submitted_applications,
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }
}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2019-01-29 19:46 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3			namespace App\Http\Controllers;
4
5			use Illuminate\Support\Facades\Lang;
6			use App\Models\JobPoster;
7
8			class DemoController extends Controller
			0 ignored issues – show Coding Style introduced 2019-02-13 18:23 UTC by Report Bug Copy Issue Report Missing doc comment for class DemoController Loading history...
9			{
10			/**
11			* Display a listing of the applicants to specified job.
12			*
13			* @return \Illuminate\Http\Response
14			*/
15			public function reviewApplications()
16			{
17			$jobPoster = factory(JobPoster::class)->create();
18			return view('manager/review_applications', [
			1 ignored issue – show Bug Best Practice introduced 2019-02-13 18:23 UTC by Report Bug Copy Issue Report The expression `return view('manager/rev...ubmitted_applications))` returns the type `Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history... Coding Style introduced 2019-02-13 18:23 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
19			/Localization Strings/
20			'jobs_l10n' => Lang::get('manager/job_index'),
21
22			/* Data */
23			'job' => $jobPoster,
24			'applications' => $jobPoster->submitted_applications,
25			]);
			0 ignored issues – show Coding Style introduced 2019-02-13 18:23 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
26			}
27			}
28

GCTC-NTGC / TalentCloud

Push — feature/review_applications ( ea5c91 )

DemoController::reviewApplications() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like