GCTC-NTGC / TalentCloud

app/Models/Lookup/PreferredLanguage.php

Spacing +2 added lines, -2 removed lines

@@ -15,11 +15,11 @@
  * @property \Illuminate\Database\Eloquent\Collection $job_applications
  *
  */
-class PreferredLanguage extends BaseModel {
+class PreferredLanguage extends BaseModel{
 
     protected $fillable = [];
 
-    public function job_applications() {
+    public function job_applications(){
         return $this->hasMany(\App\Models\JobApplication::class);
     }
 

Braces +4 added lines, -2 removed lines

@@ -15,11 +15,13 @@
  * @property \Illuminate\Database\Eloquent\Collection $job_applications
  *
  */
-class PreferredLanguage extends BaseModel {
+class PreferredLanguage extends BaseModel
+{
 
     protected $fillable = [];
 
-    public function job_applications() {
+    public function job_applications()
+    {
         return $this->hasMany(\App\Models\JobApplication::class);
     }
 

app/Policies/ApplicantPolicy.php

Spacing +3 added lines, -3 removed lines

@@ -23,12 +23,12 @@ 
         $user_id = $user->id;
         return JobPoster::whereHas(
             'manager',
-            function ($q) use ($user_id) {
+            function($q) use ($user_id) {
                 $q->where('user_id', $user_id);
             }
         )->whereHas(
             'submitted_applications',
-            function ($q) use ($applicant_id) {
+            function($q) use ($applicant_id) {
                     $q->where('applicant_id', $applicant_id);
             }
         )->get()->isNotEmpty();
@@ -43,7 +43,7 @@ 
      */
     public function view(User $user, Applicant $applicant)
     {
-        $authApplicant =  $user->isApplicant() &&
+        $authApplicant = $user->isApplicant() &&
             $applicant->user->is($user);
         $authManager = $user->isManager() && $this->ownsJobApplicantAppliedTo($user, $applicant);
         return $authApplicant || $authManager;

Braces +2 added lines, -2 removed lines

@@ -23,12 +23,12 @@
         $user_id = $user->id;
         return JobPoster::whereHas(
             'manager',
-            function ($q) use ($user_id) {
+            function ($q) use ($user_id){
                 $q->where('user_id', $user_id);
             }
         )->whereHas(
             'submitted_applications',
-            function ($q) use ($applicant_id) {
+            function ($q) use ($applicant_id){
                     $q->where('applicant_id', $applicant_id);
             }
         )->get()->isNotEmpty();

app/Policies/BasePolicy.php

Spacing +2 added lines, -2 removed lines

@@ -12,8 +12,8 @@
     public function before($user, $ability)
     {
         if ($user->isAdmin()) {
-            $userText = '{id='.$user->id.'}';
-            Log::notice('User '.$userText.' has bypassed policy as an Admin');
+            $userText = '{id=' . $user->id . '}';
+            Log::notice('User ' . $userText . ' has bypassed policy as an Admin');
             return true;
         }
     }

app/Policies/ApplicationPolicy.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
         $authManager = ($user->isManager() &&
             $jobApplication->job_poster->manager->user->is($user));
 
-        return $authApplicant||$authManager;
+        return $authApplicant || $authManager;
     }
 
     /**

database/factories/JobPosterFactory.php

Spacing +8 added lines, -8 removed lines

@@ -17,7 +17,7 @@ 
 
 $faker_fr = Faker\Factory::create('fr');
 
-$factory->define(JobPoster::class, function (Faker\Generator $faker) use ($faker_fr) {
+$factory->define(JobPoster::class, function(Faker\Generator $faker) use ($faker_fr) {
     $closeDate = $faker->dateTimeBetween('now', '1 months')->format('Y-m-d');
     $openDate = $faker->dateTimeBetween('-1 months', 'now')->format('Y-m-d');
     $startDate = $faker->dateTimeBetween('1 months', '2 months')->format('Y-m-d');
@@ -60,7 +60,7 @@ 
         'security_clearance_id' => SecurityClearance::inRandomOrder()->first()->id,
         'language_requirement_id' => LanguageRequirement::inRandomOrder()->first()->id,
         'remote_work_allowed' => $faker->boolean(50),
-        'manager_id' => function () {
+        'manager_id' => function(){
             return factory(Manager::class)->create()->id;
         },
         'team_size' => $faker->numberBetween(5, 30),
@@ -118,7 +118,7 @@ 
     ];
 });
 
-$factory->afterCreating(JobPoster::class, function ($jp) : void {
+$factory->afterCreating(JobPoster::class, function($jp) : void {
     $jp->criteria()->saveMany(factory(Criteria::class, 5)->make([
         'job_poster_id' => $jp->id
     ]));
@@ -133,7 +133,7 @@ 
 $factory->state(
     JobPoster::class,
     'byUpgradedManager',
-    ['manager_id' => function () {
+    ['manager_id' => function(){
             return factory(Manager::class)->state('upgraded')->create()->id;
     }]
 );
@@ -141,7 +141,7 @@ 
 $factory->state(
     JobPoster::class,
     'published',
-    function (Faker\Generator $faker) {
+    function(Faker\Generator $faker){
         return [
             'published' => true,
             'published_at' => $faker->dateTimeBetween('-1 months', '-3 weeks')
@@ -152,7 +152,7 @@ 
 $factory->state(
     JobPoster::class,
     'closed',
-    function (Faker\Generator $faker) {
+    function(Faker\Generator $faker){
         return [
             'published' => true,
             'published_at' => $faker->dateTimeBetween('-1 months', '-3 weeks'),
@@ -164,7 +164,7 @@ 
 $factory->state(
     JobPoster::class,
     'draft',
-    function (Faker\Generator $faker) {
+    function(Faker\Generator $faker){
         return [
             'published' => false,
             'open_date_time' => ptDayStartToUtcTime($faker->dateTimeBetween('5 days', '10 days')->format('Y-m-d')),
@@ -178,7 +178,7 @@ 
 $factory->state(
     JobPoster::class,
     'review_requested',
-    function (Faker\Generator $faker) {
+    function(Faker\Generator $faker){
         return [
             'published' => false,
             'open_date_time' => ptDayStartToUtcTime($faker->dateTimeBetween('5 days', '10 days')->format('Y-m-d')),

Braces +7 added lines, -7 removed lines

@@ -17,7 +17,7 @@ 
 
 $faker_fr = Faker\Factory::create('fr');
 
-$factory->define(JobPoster::class, function (Faker\Generator $faker) use ($faker_fr) {
+$factory->define(JobPoster::class, function (Faker\Generator $faker) use ($faker_fr){
     $closeDate = $faker->dateTimeBetween('now', '1 months')->format('Y-m-d');
     $openDate = $faker->dateTimeBetween('-1 months', 'now')->format('Y-m-d');
     $startDate = $faker->dateTimeBetween('1 months', '2 months')->format('Y-m-d');
@@ -60,7 +60,7 @@ 
         'security_clearance_id' => SecurityClearance::inRandomOrder()->first()->id,
         'language_requirement_id' => LanguageRequirement::inRandomOrder()->first()->id,
         'remote_work_allowed' => $faker->boolean(50),
-        'manager_id' => function () {
+        'manager_id' => function (){
             return factory(Manager::class)->create()->id;
         },
         'team_size' => $faker->numberBetween(5, 30),
@@ -133,7 +133,7 @@ 
 $factory->state(
     JobPoster::class,
     'byUpgradedManager',
-    ['manager_id' => function () {
+    ['manager_id' => function (){
             return factory(Manager::class)->state('upgraded')->create()->id;
     }]
 );
@@ -141,7 +141,7 @@ 
 $factory->state(
     JobPoster::class,
     'published',
-    function (Faker\Generator $faker) {
+    function (Faker\Generator $faker){
         return [
             'published' => true,
             'published_at' => $faker->dateTimeBetween('-1 months', '-3 weeks')
@@ -152,7 +152,7 @@ 
 $factory->state(
     JobPoster::class,
     'closed',
-    function (Faker\Generator $faker) {
+    function (Faker\Generator $faker){
         return [
             'published' => true,
             'published_at' => $faker->dateTimeBetween('-1 months', '-3 weeks'),
@@ -164,7 +164,7 @@ 
 $factory->state(
     JobPoster::class,
     'draft',
-    function (Faker\Generator $faker) {
+    function (Faker\Generator $faker){
         return [
             'published' => false,
             'open_date_time' => ptDayStartToUtcTime($faker->dateTimeBetween('5 days', '10 days')->format('Y-m-d')),
@@ -178,7 +178,7 @@ 
 $factory->state(
     JobPoster::class,
     'review_requested',
-    function (Faker\Generator $faker) {
+    function (Faker\Generator $faker){
         return [
             'published' => false,
             'open_date_time' => ptDayStartToUtcTime($faker->dateTimeBetween('5 days', '10 days')->format('Y-m-d')),

database/factories/RatingGuideQuestionFactory.php

Spacing +2 added lines, -2 removed lines

@@ -5,9 +5,9 @@
 use App\Models\RatingGuideQuestion;
 use App\Models\JobPoster;
 
-$factory->define(RatingGuideQuestion::class, function (Faker\Generator $faker) {
+$factory->define(RatingGuideQuestion::class, function(Faker\Generator $faker){
     return [
-        'job_poster_id' => function () {
+        'job_poster_id' => function(){
             return factory(JobPoster::class)->create()->id;
         },
         'assessment_type_id' => AssessmentType::inRandomOrder()->first()->id,

Braces +2 added lines, -2 removed lines

@@ -5,9 +5,9 @@
 use App\Models\RatingGuideQuestion;
 use App\Models\JobPoster;
 
-$factory->define(RatingGuideQuestion::class, function (Faker\Generator $faker) {
+$factory->define(RatingGuideQuestion::class, function (Faker\Generator $faker){
     return [
-        'job_poster_id' => function () {
+        'job_poster_id' => function (){
             return factory(JobPoster::class)->create()->id;
         },
         'assessment_type_id' => AssessmentType::inRandomOrder()->first()->id,

database/factories/SkillDeclarationFactory.php

Spacing +2 added lines, -2 removed lines

@@ -6,12 +6,12 @@
 use App\Models\Lookup\SkillLevel;
 use App\Models\Applicant;
 
-$factory->define(SkillDeclaration::class, function (Faker\Generator $faker) {
+$factory->define(SkillDeclaration::class, function(Faker\Generator $faker){
     return [
         'skill_id' => Skill::inRandomOrder()->first()->id,
         'skill_status_id' => SkillStatus::inRandomOrder()->first()->id,
         'skill_level_id' => SkillLevel::inRandomOrder()->first()->id,
-        'applicant_id' => function () {
+        'applicant_id' => function(){
             return factory(Applicant::class)->create()->id;
         },
         'description' => $faker->paragraphs(3, true),

Braces +2 added lines, -2 removed lines

@@ -6,12 +6,12 @@
 use App\Models\Lookup\SkillLevel;
 use App\Models\Applicant;
 
-$factory->define(SkillDeclaration::class, function (Faker\Generator $faker) {
+$factory->define(SkillDeclaration::class, function (Faker\Generator $faker){
     return [
         'skill_id' => Skill::inRandomOrder()->first()->id,
         'skill_status_id' => SkillStatus::inRandomOrder()->first()->id,
         'skill_level_id' => SkillLevel::inRandomOrder()->first()->id,
-        'applicant_id' => function () {
+        'applicant_id' => function (){
             return factory(Applicant::class)->create()->id;
         },
         'description' => $faker->paragraphs(3, true),

database/factories/UserFactory.php

Spacing +8 added lines, -8 removed lines

@@ -23,7 +23,7 @@ 
 
 $faker_fr = Faker\Factory::create('fr');
 
-$factory->define(User::class, function (Faker\Generator $faker) {
+$factory->define(User::class, function(Faker\Generator $faker){
     static $password;
 
     return [
@@ -38,7 +38,7 @@ 
     ];
 });
 
-$factory->state(User::class, 'upgradedManager', function (Faker\Generator $faker) {
+$factory->state(User::class, 'upgradedManager', function(Faker\Generator $faker){
     return [
         'user_role_id' => UserRole::where('name', 'upgradedManager')->first()->id,
         'gov_email' => $faker->unique()->safeEmail(),
@@ -57,20 +57,20 @@ 
     'is_priority' => true
 ]);
 
-$factory->define(Applicant::class, function (Faker\Generator $faker) {
+$factory->define(Applicant::class, function(Faker\Generator $faker){
     return [
         'twitter_username' => $faker->firstName(),
         'linkedin_url' => null,
         'tagline' => $faker->paragraph(),
         'personal_website' => $faker->url(),
         'is_snapshot' => false,
-        'user_id' => function () {
+        'user_id' => function(){
             return factory(User::class)->states('applicant')->create()->id;
         },
     ];
 });
 
-$factory->define(Manager::class, function (Faker\Generator $faker) use ($faker_fr) {
+$factory->define(Manager::class, function(Faker\Generator $faker) use ($faker_fr) {
     return [
         'twitter_username' => $faker->firstName(),
         'linkedin_url' => null,
@@ -81,7 +81,7 @@ 
         'development_opportunity_frequency_id' => Frequency::inRandomOrder()->first()->id,
         'refuse_low_value_work_frequency_id' => Frequency::inRandomOrder()->first()->id,
         'years_experience' => $faker->numberBetween(2, 25),
-        'user_id' => function () use ($faker) {
+        'user_id' => function() use ($faker) {
             return factory(User::class)->create([
                 'gov_email' => $faker->unique()->safeEmail(),
             ])->id;
@@ -130,12 +130,12 @@ 
 });
 
 $factory->state(Manager::class, 'upgraded', [
-    'user_id' => function () {
+    'user_id' => function(){
         return factory(User::class)->state('upgradedManager')->create()->id;
     },
 ]);
 
-$factory->afterCreating(Manager::class, function ($manager) : void {
+$factory->afterCreating(Manager::class, function($manager) : void {
     $manager->team_culture()->save(factory(TeamCulture::class)->create([
         'manager_id' => $manager->id,
     ]));

Braces +7 added lines, -7 removed lines

@@ -23,7 +23,7 @@ 
 
 $faker_fr = Faker\Factory::create('fr');
 
-$factory->define(User::class, function (Faker\Generator $faker) {
+$factory->define(User::class, function (Faker\Generator $faker){
     static $password;
 
     return [
@@ -38,7 +38,7 @@ 
     ];
 });
 
-$factory->state(User::class, 'upgradedManager', function (Faker\Generator $faker) {
+$factory->state(User::class, 'upgradedManager', function (Faker\Generator $faker){
     return [
         'user_role_id' => UserRole::where('name', 'upgradedManager')->first()->id,
         'gov_email' => $faker->unique()->safeEmail(),
@@ -57,20 +57,20 @@ 
     'is_priority' => true
 ]);
 
-$factory->define(Applicant::class, function (Faker\Generator $faker) {
+$factory->define(Applicant::class, function (Faker\Generator $faker){
     return [
         'twitter_username' => $faker->firstName(),
         'linkedin_url' => null,
         'tagline' => $faker->paragraph(),
         'personal_website' => $faker->url(),
         'is_snapshot' => false,
-        'user_id' => function () {
+        'user_id' => function (){
             return factory(User::class)->states('applicant')->create()->id;
         },
     ];
 });
 
-$factory->define(Manager::class, function (Faker\Generator $faker) use ($faker_fr) {
+$factory->define(Manager::class, function (Faker\Generator $faker) use ($faker_fr){
     return [
         'twitter_username' => $faker->firstName(),
         'linkedin_url' => null,
@@ -81,7 +81,7 @@ 
         'development_opportunity_frequency_id' => Frequency::inRandomOrder()->first()->id,
         'refuse_low_value_work_frequency_id' => Frequency::inRandomOrder()->first()->id,
         'years_experience' => $faker->numberBetween(2, 25),
-        'user_id' => function () use ($faker) {
+        'user_id' => function () use ($faker){
             return factory(User::class)->create([
                 'gov_email' => $faker->unique()->safeEmail(),
             ])->id;
@@ -130,7 +130,7 @@ 
 });
 
 $factory->state(Manager::class, 'upgraded', [
-    'user_id' => function () {
+    'user_id' => function (){
         return factory(User::class)->state('upgradedManager')->create()->id;
     },
 ]);

database/factories/ApplicationFactory.php

Spacing +4 added lines, -4 removed lines

@@ -10,9 +10,9 @@ 
 use App\Models\JobApplicationAnswer;
 use App\Models\SkillDeclaration;
 
-$factory->define(JobApplication::class, function (Faker\Generator $faker) {
+$factory->define(JobApplication::class, function(Faker\Generator $faker){
     return [
-        'job_poster_id' => function () {
+        'job_poster_id' => function(){
             return factory(JobPoster::class)->states('published')->create()->id;
         },
         'application_status_id' => ApplicationStatus::where('name', 'submitted')->firstOrFail()->id,
@@ -21,7 +21,7 @@ 
         'preferred_language_id' => PreferredLanguage::inRandomOrder()->first()->id,
         'submission_signature' => $faker->name(),
         'submission_date' => $faker->dateTimeBetween('yesterday', 'tomorrow')->format('Y-m-d H:i:s'),
-        'applicant_id' => function () {
+        'applicant_id' => function(){
             return factory(Applicant::class)->create()->id;
         }
     ];
@@ -33,7 +33,7 @@ 
     'submission_date' => null
 ]);
 
-$factory->afterCreating(JobApplication::class, function ($application) : void {
+$factory->afterCreating(JobApplication::class, function($application) : void {
     foreach ($application->job_poster->job_poster_questions as $question) {
         $answer = factory(JobApplicationAnswer::class)->create([
             'job_poster_question_id' => $question->id,

Braces +3 added lines, -3 removed lines

@@ -10,9 +10,9 @@ 
 use App\Models\JobApplicationAnswer;
 use App\Models\SkillDeclaration;
 
-$factory->define(JobApplication::class, function (Faker\Generator $faker) {
+$factory->define(JobApplication::class, function (Faker\Generator $faker){
     return [
-        'job_poster_id' => function () {
+        'job_poster_id' => function (){
             return factory(JobPoster::class)->states('published')->create()->id;
         },
         'application_status_id' => ApplicationStatus::where('name', 'submitted')->firstOrFail()->id,
@@ -21,7 +21,7 @@ 
         'preferred_language_id' => PreferredLanguage::inRandomOrder()->first()->id,
         'submission_signature' => $faker->name(),
         'submission_date' => $faker->dateTimeBetween('yesterday', 'tomorrow')->format('Y-m-d H:i:s'),
-        'applicant_id' => function () {
+        'applicant_id' => function (){
             return factory(Applicant::class)->create()->id;
         }
     ];