GCTC-NTGC / TalentCloud

app/Services/Validation/Rules/ContainsObjectWithAttributeRule.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         // debugbar()->debug($value);
         // debugbar()->debug($this->attributeName);
         // debugbar()->debug($this->attributeValue);
-        return $this->array_any($value, function ($object) {
+        return $this->array_any($value, function($object){
             return $object[$this->attributeName] == $this->attributeValue;
         });
     }

Braces +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         // debugbar()->debug($value);
         // debugbar()->debug($this->attributeName);
         // debugbar()->debug($this->attributeValue);
-        return $this->array_any($value, function ($object) {
+        return $this->array_any($value, function ($object){
             return $object[$this->attributeName] == $this->attributeValue;
         });
     }

app/Services/Validation/Rules/CourseValidator.php

Indentation +5 added lines, -5 removed lines

@@ -25,13 +25,13 @@
         //Validate basic data is filled in
         Validator::make($courseValidator->getAttributes(), [ 
             'applicant_id' => [
-             'required',
+                'required',
                 Rule::in($applicant_ids->toArray()),
-       ],
-             'course_status_id' => [
-             'required',
+        ],
+                'course_status_id' => [
+                'required',
                 Rule::in($this->course_status_ids->toArray()),    
-     ]
+        ]
          
         ])->validate();
     }

Braces +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 use App\Models\Applicant;
 use App\Services\Validation\Rules\UniqueApplicantSkillRule;
 class CourseValidator
-{ 
+{
     
     protected $applicant;
     protected $course_status_id;

app/Services/Validation/JobApplicationAnswerValidator.php

Spacing +6 added lines, -6 removed lines

@@ -7,17 +7,17 @@ 
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;
 
-class JobApplicationAnswerValidator {
+class JobApplicationAnswerValidator{
 
     protected $application;
     protected $questionIds;
 
-    public function __construct(JobApplication $application) {
+    public function __construct(JobApplication $application){
         $this->application = $application;
         $this->questionIds = $application->job_poster->job_poster_questions->pluck('id')->toArray();
     }
 
-    public function rules() {
+    public function rules(){
         $rules = [
             'answer' => 'required|string',
             'job_poster_question_id' => [
@@ -32,17 +32,17 @@ 
         return $rules;
     }
 
-    public function validator(JobApplicationAnswer $answer) {
+    public function validator(JobApplicationAnswer $answer){
 
 
         return Validator::make($answer->toArray(), $this->rules());
     }
 
-    public function validate(JobApplicationAnswer $answer) {
+    public function validate(JobApplicationAnswer $answer){
         return $this->validator($answer)->validate();
     }
 
-    public function isComplete(JobApplicationAnswer $answer) {
+    public function isComplete(JobApplicationAnswer $answer){
         return $this->validator($answer)->passes();
     }
 }

Braces +12 added lines, -6 removed lines

@@ -7,17 +7,20 @@ 
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;
 
-class JobApplicationAnswerValidator {
+class JobApplicationAnswerValidator
+{
 
     protected $application;
     protected $questionIds;
 
-    public function __construct(JobApplication $application) {
+    public function __construct(JobApplication $application)
+    {
         $this->application = $application;
         $this->questionIds = $application->job_poster->job_poster_questions->pluck('id')->toArray();
     }
 
-    public function rules() {
+    public function rules()
+    {
         $rules = [
             'answer' => 'required|string',
             'job_poster_question_id' => [
@@ -32,17 +35,20 @@ 
         return $rules;
     }
 
-    public function validator(JobApplicationAnswer $answer) {
+    public function validator(JobApplicationAnswer $answer)
+    {
 
 
         return Validator::make($answer->toArray(), $this->rules());
     }
 
-    public function validate(JobApplicationAnswer $answer) {
+    public function validate(JobApplicationAnswer $answer)
+    {
         return $this->validator($answer)->validate();
     }
 
-    public function isComplete(JobApplicationAnswer $answer) {
+    public function isComplete(JobApplicationAnswer $answer)
+    {
         return $this->validator($answer)->passes();
     }
 }

app/Services/Validation/PasswordValidator.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         ];
     }
 
-    public function messages() {
+    public function messages(){
         return Lang::get('validation.custom.password');
     }
 }

Braces +2 added lines, -1 removed lines

@@ -21,7 +21,8 @@
         ];
     }
 
-    public function messages() {
+    public function messages()
+    {
         return Lang::get('validation.custom.password');
     }
 }

app/Services/Validation/SkillDeclarationValidator.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 
     }
 
-    public function validator(SkillDeclaration $skillDeclaration) {
+    public function validator(SkillDeclaration $skillDeclaration){
         $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);
 
         //Validate basic data is filled in

Braces +2 added lines, -1 removed lines

@@ -29,7 +29,8 @@
 
     }
 
-    public function validator(SkillDeclaration $skillDeclaration) {
+    public function validator(SkillDeclaration $skillDeclaration)
+    {
         $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);
 
         //Validate basic data is filled in

app/Services/Validation/ApplicationValidator.php

Spacing +19 added lines, -19 removed lines

@@ -13,19 +13,19 @@ 
 use App\Services\Validation\Rules\ContainsObjectWithAttributeRule;
 use App\Services\Validation\JobApplicationAnswerValidator;
 
-class ApplicationValidator {
+class ApplicationValidator{
 
     protected $citizenship_ids;
     protected $veteran_status_ids;
     protected $preferred_language_ids;
 
-    public function __construct() {
+    public function __construct(){
         $this->citizenship_ids = CitizenshipDeclaration::all()->pluck('id')->toArray();
         $this->veteran_status_ids = VeteranStatus::all()->pluck('id')->toArray();
         $this->preferred_language_ids = PreferredLanguage::all()->pluck('id')->toArray();
     }
 
-    public function validate(JobApplication $application) {
+    public function validate(JobApplication $application){
 
         $backendRules = [
             'job_poster_id' => 'required',
@@ -75,7 +75,7 @@ 
         return $newArray;
     }
 
-    protected function addNestedValidatorRules($nestedAttribute, $validatorRules, $rules = []) {
+    protected function addNestedValidatorRules($nestedAttribute, $validatorRules, $rules = []){
         // prepend the attribute name of each validator rule with the nested attribute name
         $newRules = $this->arrayMapKeys(function($key) use ($nestedAttribute) {
                 return implode('.', [$nestedAttribute, $key]);
@@ -86,7 +86,7 @@ 
         return $rules;
     }
 
-    public function basicsValidator(JobApplication $application) {
+    public function basicsValidator(JobApplication $application){
         // Validate the fields common to every application
         $rules = [
             'language_requirement_confirmed' => ['required', 'boolean'],
@@ -100,14 +100,14 @@ 
 
         // Validate that each question has been answered
         $jobPosterQuestionRules = [];
-        foreach($application->job_poster->job_poster_questions as $question) {
+        foreach ($application->job_poster->job_poster_questions as $question) {
             $jobPosterQuestionRules[] = new ContainsObjectWithAttributeRule('job_poster_question_id', $question->id);
         }
         $rules['job_application_answers'] = $jobPosterQuestionRules;
         $answerValidatorFactory = new JobApplicationAnswerValidator($application);
 
         //Validate that each answer is complete
-        foreach($application->job_application_answers as $key=>$answer) {
+        foreach ($application->job_application_answers as $key=>$answer) {
             $attribute = implode('.', ['job_application_answers', $key]);
             $rules = $this->addNestedValidatorRules($attribute, $answerValidatorFactory->rules(), $rules);
         }
@@ -116,26 +116,26 @@ 
         return $validator;
     }
 
-    public function basicsComplete(JobApplication $application) {
+    public function basicsComplete(JobApplication $application){
         $validator = $this->basicsValidator($application);
         return $validator->passes();
     }
 
-    public function experienceValidator(JobApplication $application) {
+    public function experienceValidator(JobApplication $application){
         $rules = ['experience_saved' => 'required|boolean|accepted'];
         return Validator::make($application->toArray(), $rules);
     }
 
-    public function experienceComplete(JobApplication $application) {
+    public function experienceComplete(JobApplication $application){
         return $this->experienceValidator($application)->passes();
     }
 
-    protected function skillsValidator(JobApplication $application, $criteria_type) {
+    protected function skillsValidator(JobApplication $application, $criteria_type){
         $rules = [];
 
         $skillDeclarationRules = [];
         $criteriaTypeId = CriteriaType::where('name', $criteria_type)->firstOrFail()->id;
-        foreach($application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId) as $criteria) {
+        foreach ($application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId) as $criteria) {
             //Validate that every essential skill has a corresponding declaration
             $skillDeclarationRules[] = new ContainsObjectWithAttributeRule('skill_id', $criteria->skill_id);
         }
@@ -145,7 +145,7 @@ 
         //Validate that those declarations are complete
         $skilDeclarationValidatorFactory = new SkillDeclarationValidator($application->applicant);
         $relevantSkillIds = $application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId)->pluck('skill_id');
-        foreach( $application->skill_declarations as $key=>$declaration) {
+        foreach ($application->skill_declarations as $key=>$declaration) {
             if ($relevantSkillIds->contains($declaration->skill_id)) {
                 $attribute = implode('.', ['skill_declarations', $key]);
                 $skillDeclarationValidator = $skilDeclarationValidatorFactory->validator($declaration);
@@ -157,23 +157,23 @@ 
         return $validator;
     }
 
-    public function essentialSkillsValidator(JobApplication $application) {
+    public function essentialSkillsValidator(JobApplication $application){
         return $this->skillsValidator($application, 'essential');
     }
 
-    public function essentialSkillsComplete(JobApplication $application) {
+    public function essentialSkillsComplete(JobApplication $application){
         return $this->essentialSkillsValidator($application)->passes();
     }
 
-    public function assetSkillsValidator(JobApplication $application) {
+    public function assetSkillsValidator(JobApplication $application){
         return $this->skillsValidator($application, 'asset');
     }
 
-    public function assetSkillsComplete(JobApplication $application) {
+    public function assetSkillsComplete(JobApplication $application){
         return $this->assetSkillsValidator($application)->passes();
     }
 
-    public function affirmationValidator(JobApplication $application) {
+    public function affirmationValidator(JobApplication $application){
         $rules = [
             'submission_signature' => [
                 'required',
@@ -189,7 +189,7 @@ 
         return Validator::make($application->toArray(), $rules);
     }
 
-    public function affirmationComplete(JobApplication $application) {
+    public function affirmationComplete(JobApplication $application){
         return $this->affirmationValidator($application)->passes();
     }
 }

Braces +31 added lines, -16 removed lines

@@ -13,19 +13,22 @@ 
 use App\Services\Validation\Rules\ContainsObjectWithAttributeRule;
 use App\Services\Validation\JobApplicationAnswerValidator;
 
-class ApplicationValidator {
+class ApplicationValidator
+{
 
     protected $citizenship_ids;
     protected $veteran_status_ids;
     protected $preferred_language_ids;
 
-    public function __construct() {
+    public function __construct()
+    {
         $this->citizenship_ids = CitizenshipDeclaration::all()->pluck('id')->toArray();
         $this->veteran_status_ids = VeteranStatus::all()->pluck('id')->toArray();
         $this->preferred_language_ids = PreferredLanguage::all()->pluck('id')->toArray();
     }
 
-    public function validate(JobApplication $application) {
+    public function validate(JobApplication $application)
+    {
 
         $backendRules = [
             'job_poster_id' => 'required',
@@ -75,9 +78,10 @@ 
         return $newArray;
     }
 
-    protected function addNestedValidatorRules($nestedAttribute, $validatorRules, $rules = []) {
+    protected function addNestedValidatorRules($nestedAttribute, $validatorRules, $rules = [])
+    {
         // prepend the attribute name of each validator rule with the nested attribute name
-        $newRules = $this->arrayMapKeys(function($key) use ($nestedAttribute) {
+        $newRules = $this->arrayMapKeys(function($key) use ($nestedAttribute){
                 return implode('.', [$nestedAttribute, $key]);
             },
             $validatorRules);
@@ -86,7 +90,8 @@ 
         return $rules;
     }
 
-    public function basicsValidator(JobApplication $application) {
+    public function basicsValidator(JobApplication $application)
+    {
         // Validate the fields common to every application
         $rules = [
             'language_requirement_confirmed' => ['required', 'boolean'],
@@ -116,21 +121,25 @@ 
         return $validator;
     }
 
-    public function basicsComplete(JobApplication $application) {
+    public function basicsComplete(JobApplication $application)
+    {
         $validator = $this->basicsValidator($application);
         return $validator->passes();
     }
 
-    public function experienceValidator(JobApplication $application) {
+    public function experienceValidator(JobApplication $application)
+    {
         $rules = ['experience_saved' => 'required|boolean|accepted'];
         return Validator::make($application->toArray(), $rules);
     }
 
-    public function experienceComplete(JobApplication $application) {
+    public function experienceComplete(JobApplication $application)
+    {
         return $this->experienceValidator($application)->passes();
     }
 
-    protected function skillsValidator(JobApplication $application, $criteria_type) {
+    protected function skillsValidator(JobApplication $application, $criteria_type)
+    {
         $rules = [];
 
         $skillDeclarationRules = [];
@@ -157,23 +166,28 @@ 
         return $validator;
     }
 
-    public function essentialSkillsValidator(JobApplication $application) {
+    public function essentialSkillsValidator(JobApplication $application)
+    {
         return $this->skillsValidator($application, 'essential');
     }
 
-    public function essentialSkillsComplete(JobApplication $application) {
+    public function essentialSkillsComplete(JobApplication $application)
+    {
         return $this->essentialSkillsValidator($application)->passes();
     }
 
-    public function assetSkillsValidator(JobApplication $application) {
+    public function assetSkillsValidator(JobApplication $application)
+    {
         return $this->skillsValidator($application, 'asset');
     }
 
-    public function assetSkillsComplete(JobApplication $application) {
+    public function assetSkillsComplete(JobApplication $application)
+    {
         return $this->assetSkillsValidator($application)->passes();
     }
 
-    public function affirmationValidator(JobApplication $application) {
+    public function affirmationValidator(JobApplication $application)
+    {
         $rules = [
             'submission_signature' => [
                 'required',
@@ -189,7 +203,8 @@ 
         return Validator::make($application->toArray(), $rules);
     }
 
-    public function affirmationComplete(JobApplication $application) {
+    public function affirmationComplete(JobApplication $application)
+    {
         return $this->affirmationValidator($application)->passes();
     }
 }

app/Utilities/HandleNullState.php

Indentation +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     public function getFunctions(): array
     {
         return [
-          new Twig_SimpleFunction('handleNullState', [$this, 'handleNullState']),
+            new Twig_SimpleFunction('handleNullState', [$this, 'handleNullState']),
         ];
     }
 

app/Models/WorkplacePhoto.php

Spacing +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
  * 
  * @property \App\Models\WorkplacePhotoCaption $workplace_photo_caption
  */
-class WorkplacePhoto extends BaseModel {
+class WorkplacePhoto extends BaseModel{
 
     protected $casts = [
         'image' => 'boolean',
@@ -29,7 +29,7 @@ 
         'image'
     ];
 
-    public function workplace_photo_caption() {
+    public function workplace_photo_caption(){
         return $this->hasOne(\App\Models\WorkplacePhotoCaption::class);
     }
 

Braces +4 added lines, -2 removed lines

@@ -19,7 +19,8 @@ 
  * 
  * @property \App\Models\WorkplacePhotoCaption $workplace_photo_caption
  */
-class WorkplacePhoto extends BaseModel {
+class WorkplacePhoto extends BaseModel
+{
 
     protected $casts = [
         'image' => 'boolean',
@@ -29,7 +30,8 @@ 
         'image'
     ];
 
-    public function workplace_photo_caption() {
+    public function workplace_photo_caption()
+    {
         return $this->hasOne(\App\Models\WorkplacePhotoCaption::class);
     }
 

app/Models/JobApplication.php

Spacing +15 added lines, -15 removed lines

@@ -46,7 +46,7 @@ 
  * @property \Illuminate\Database\Eloquent\Collection $skill_declarations
  * @property \App\Models\ApplicationReview $application_review
  */
-class JobApplication extends BaseModel {
+class JobApplication extends BaseModel{
 
     use Notifiable;
 
@@ -85,51 +85,51 @@ 
      */
     protected $appends = ['meets_essential_criteria'];
 
-    protected function createApplicantSnapshot($applicant_id) {
+    protected function createApplicantSnapshot($applicant_id){
         $applicant = Applicant::where('id', $applicant_id)->firstOrFail();
 
         $snapshot = $applicant->replicate();
 
     }
 
-    public function applicant() {
+    public function applicant(){
         return $this->belongsTo(\App\Models\Applicant::class);
     }
 
-    public function applicant_snapshot() {
+    public function applicant_snapshot(){
         return $this->belongsTo(\App\Models\Applicant::class, 'applicant_snapshot_id');
     }
 
-    public function application_status() {
+    public function application_status(){
         return $this->belongsTo(\App\Models\Lookup\ApplicationStatus::class);
     }
 
-    public function citizenship_declaration() {
+    public function citizenship_declaration(){
         return $this->belongsTo(\App\Models\Lookup\CitizenshipDeclaration::class);
     }
 
-    public function veteran_status() {
+    public function veteran_status(){
         return $this->belongsTo(\App\Models\Lookup\VeteranStatus::class);
     }
 
-    public function preferred_language() {
+    public function preferred_language(){
         return $this->belongsTo(\App\Models\Lookup\PreferredLanguage::class);
     }
 
-    public function job_poster() {
+    public function job_poster(){
         return $this->belongsTo(\App\Models\JobPoster::class);
     }
 
-    public function job_application_answers() {
+    public function job_application_answers(){
         return $this->hasMany(\App\Models\JobApplicationAnswer::class);
     }
 
-    public function skill_declarations() {
+    public function skill_declarations(){
         return $this->applicant->skill_declarations()
             ->whereIn('skill_id', $this->job_poster->criteria->pluck('skill_id'));
     }
 
-    public function application_review() {
+    public function application_review(){
         return $this->hasOne(ApplicationReview::class);
     }
 
@@ -146,11 +146,11 @@ 
      *
      * @return string $status   'complete', 'incomplete' or 'error'
      */
-    public function getSectionStatus(string $section) {
+    public function getSectionStatus(string $section){
         //TODO: determine whether sections are complete or invalid
         $validator = new ApplicationValidator();
         $status = 'incomplete';
-        switch($section) {
+        switch ($section) {
             case 'basics':
                 if ($validator->basicsComplete($this)) {
                     $status = 'complete';
@@ -201,7 +201,7 @@ 
     public function meetsEssentialCriteria(): bool
     {
         $essentialCriteria = $this->job_poster->criteria->filter(
-            function ($value, $key) {
+            function($value, $key){
                 return $value->criteria_type->name == 'essential';
             }
         );

Braces +27 added lines, -14 removed lines

@@ -46,7 +46,8 @@ 
  * @property \Illuminate\Database\Eloquent\Collection $skill_declarations
  * @property \App\Models\ApplicationReview $application_review
  */
-class JobApplication extends BaseModel {
+class JobApplication extends BaseModel
+{
 
     use Notifiable;
 
@@ -85,51 +86,62 @@ 
      */
     protected $appends = ['meets_essential_criteria'];
 
-    protected function createApplicantSnapshot($applicant_id) {
+    protected function createApplicantSnapshot($applicant_id)
+    {
         $applicant = Applicant::where('id', $applicant_id)->firstOrFail();
 
         $snapshot = $applicant->replicate();
 
     }
 
-    public function applicant() {
+    public function applicant()
+    {
         return $this->belongsTo(\App\Models\Applicant::class);
     }
 
-    public function applicant_snapshot() {
+    public function applicant_snapshot()
+    {
         return $this->belongsTo(\App\Models\Applicant::class, 'applicant_snapshot_id');
     }
 
-    public function application_status() {
+    public function application_status()
+    {
         return $this->belongsTo(\App\Models\Lookup\ApplicationStatus::class);
     }
 
-    public function citizenship_declaration() {
+    public function citizenship_declaration()
+    {
         return $this->belongsTo(\App\Models\Lookup\CitizenshipDeclaration::class);
     }
 
-    public function veteran_status() {
+    public function veteran_status()
+    {
         return $this->belongsTo(\App\Models\Lookup\VeteranStatus::class);
     }
 
-    public function preferred_language() {
+    public function preferred_language()
+    {
         return $this->belongsTo(\App\Models\Lookup\PreferredLanguage::class);
     }
 
-    public function job_poster() {
+    public function job_poster()
+    {
         return $this->belongsTo(\App\Models\JobPoster::class);
     }
 
-    public function job_application_answers() {
+    public function job_application_answers()
+    {
         return $this->hasMany(\App\Models\JobApplicationAnswer::class);
     }
 
-    public function skill_declarations() {
+    public function skill_declarations()
+    {
         return $this->applicant->skill_declarations()
             ->whereIn('skill_id', $this->job_poster->criteria->pluck('skill_id'));
     }
 
-    public function application_review() {
+    public function application_review()
+    {
         return $this->hasOne(ApplicationReview::class);
     }
 
@@ -146,7 +158,8 @@ 
      *
      * @return string $status   'complete', 'incomplete' or 'error'
      */
-    public function getSectionStatus(string $section) {
+    public function getSectionStatus(string $section)
+    {
         //TODO: determine whether sections are complete or invalid
         $validator = new ApplicationValidator();
         $status = 'incomplete';
@@ -201,7 +214,7 @@ 
     public function meetsEssentialCriteria(): bool
     {
         $essentialCriteria = $this->job_poster->criteria->filter(
-            function ($value, $key) {
+            function ($value, $key){
                 return $value->criteria_type->name == 'essential';
             }
         );