GCTC-NTGC / TalentCloud

app/Notifications/ResetPasswordNotification.php

Doc Comments +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
      * Get the notification's delivery channels.
      *
      * @param  mixed  $notifiable
-     * @return array
+     * @return string[]
      */
     public function via($notifiable)
     {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Bus\Queueable;
 use Illuminate\Notifications\Notification;
-use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Notifications\Messages\MailMessage;
 use Illuminate\Support\Facades\Lang;
 

app/Policies/ApplicantPolicy.php

Doc Comments +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
      *
      * @param  \App\Models\User  $user
      * @param  \App\Models\Applicant  $applicant
-     * @return mixed
+     * @return boolean
      */
     public function view(User $user, Applicant $applicant)
     {
@@ -45,7 +45,7 @@ 
      * Determine whether the user can create applicants.
      *
      * @param  \App\Models\User  $user
-     * @return mixed
+     * @return boolean
      */
     public function create(User $user)
     {
@@ -57,7 +57,7 @@ 
      *
      * @param  \App\Models\User  $user
      * @param  \App\Models\Applicant  $applicant
-     * @return mixed
+     * @return boolean
      */
     public function update(User $user, Applicant $applicant)
     {

app/Policies/ApplicationPolicy.php

Doc Comments +9 added lines, -9 removed lines

@@ -15,8 +15,8 @@ 
      * Determine whether the user can view the jobApplication.
      *
      * @param  \App\Models\User  $user
-     * @param  \App\JobApplication  $jobApplication
-     * @return mixed
+     * @param  JobApplication  $jobApplication
+     * @return boolean
      */
     public function view(User $user, JobApplication $jobApplication)
     {
@@ -32,7 +32,7 @@ 
      * Determine whether the user can create jobApplications.
      *
      * @param  \App\Models\User  $user
-     * @return mixed
+     * @return boolean
      */
     public function create(User $user)
     {
@@ -43,8 +43,8 @@ 
      * Determine whether the user can update the jobApplication.
      *
      * @param  \App\Models\User  $user
-     * @param  \App\JobApplication  $jobApplication
-     * @return mixed
+     * @param  JobApplication  $jobApplication
+     * @return boolean
      */
     public function update(User $user, JobApplication $jobApplication)
     {
@@ -58,8 +58,8 @@ 
      * Determine whether the user can delete the jobApplication.
      *
      * @param  \App\Models\User  $user
-     * @param  \App\JobApplication  $jobApplication
-     * @return mixed
+     * @param  JobApplication  $jobApplication
+     * @return boolean
      */
     public function delete(User $user, JobApplication $jobApplication)
     {
@@ -72,8 +72,8 @@ 
      * Determine whether the user can review the jobApplication.
      *
      * @param  \App\Models\User  $user
-     * @param  \App\JobApplication  $jobApplication
-     * @return mixed
+     * @param  JobApplication  $jobApplication
+     * @return boolean
      */
     public function review(User $user, JobApplication $jobApplication)
     {

app/Services/Validation/ApplicationValidator.php

Doc Comments +7 added lines, -1 removed lines

@@ -62,7 +62,7 @@ 
     /**
      * Return a copy of $array, with function $fn applied to each key, but values left unchanged.
      *
-     * @param function $fn    Function applied to each key.
+     * @param \Closure $fn    Function applied to each key.
      * @param array    $array Array to operate on.
      * @return array
      */
@@ -75,6 +75,9 @@ 
         return $newArray;
     }
 
+    /**
+     * @param string $nestedAttribute
+     */
     protected function addNestedValidatorRules($nestedAttribute, $validatorRules, $rules = []) {
         // prepend the attribute name of each validator rule with the nested attribute name
         $newRules = $this->arrayMapKeys(function($key) use ($nestedAttribute) {
@@ -130,6 +133,9 @@ 
         return $this->experienceValidator($application)->passes();
     }
 
+    /**
+     * @param string $criteria_type
+     */
     protected function skillsValidator(JobApplication $application, $criteria_type) {
         $rules = [];
 

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use App\Models\JobApplication;
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;
-use Illuminate\Validation\Validator as BaseValidator;
 use App\Models\Lookup\CitizenshipDeclaration;
 use App\Models\Lookup\CriteriaType;
 use App\Models\Lookup\VeteranStatus;

app/Services/Validation/Rules/ApplicantHasRelationRule.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace App\Services\Validation\Rules;
 
 use Illuminate\Contracts\Validation\Rule;
-use Illuminate\Support\Facades\Hash;
-use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Lang;
 use App\Models\Applicant;
 

app/Services/Validation/Rules/ContainsObjectWithAttributeRule.php

Doc Comments +1 added lines, -2 removed lines

@@ -14,8 +14,7 @@
     /**
      * Create a new rule instance.
      *
-     * @param  App\Models\Applicant  $applicant
-     * @param  string  $relation
+     * @param string $attributeName
      * @return void
      */
     public function __construct($attributeName, $attributeValue)

app/Services/Validation/Rules/CourseValidator.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace App\Services\Validation;
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;
-use App\Models\Course;
 use App\Models\Lookup\CourseStatus;
 use App\Models\Applicant;
 use App\Services\Validation\Rules\UniqueApplicantSkillRule;

app/Services/Validation/Rules/DegreeValidator.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace App\Services\Validation;
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;
-use App\Models\Degree;
 use App\Models\Lookup\DegreeType;
 use App\Models\Applicant;
 use App\Services\Validation\Rules\UniqueApplicantSkillRule;

app/Services/Validation/Rules/PassesValidatorRule.php

Doc Comments -2 removed lines

@@ -13,8 +13,6 @@
     /**
      * Create a new rule instance.
      *
-     * @param  App\Models\Applicant  $applicant
-     * @param  string  $relation
      * @return void
      */
     public function __construct($validator)