ValidIdRule::passes() - Code Metrics - Inspection of "Merge branch 'feature/job-builder/base' into featu..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job-builder/xm-job-0-c... ( 9c31b2...b9bf9c )

by Tristan

created 2019-06-06 22:53 UTC

ValidIdRule::passes() A

↳ Parent: ValidIdRule

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;

class ValidIdRule implements Rule
{
    /**
     * The fully qualified classname of the model to check.
     *
     * @var string
     */
    protected $className;

    /**
     * Create a rule that tests that a value is a valid id for the specified eloquent model.
     *
     * @param string $className

     */
    public function __construct(string $className)
    {
        $this->className = $className;
    }

    /**
     * Determine if the validation rule passes.
     *
     * @param  string  $attribute

     * @param  mixed  $value

     * @return bool

     */
    public function passes($attribute, $value)

    {
        $model = $this->className;
        return $model::where('id', $value)->exists();
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()

    {
        return Lang::get('validation.invalid_id');

    }
}


1		<?php
2
3		namespace App\Services\Validation\Rules;
4
5		use Illuminate\Contracts\Validation\Rule;
6		use Illuminate\Support\Facades\Lang;
7
8		class ValidIdRule implements Rule
9		{
10		/**
11		* The fully qualified classname of the model to check.
12		*
13		* @var string
14		*/
15		protected $className;
16
17		/**
18		* Create a rule that tests that a value is a valid id for the specified eloquent model.
19		*
20		* @param string $className
		1 ignored issue – show Coding Style Documentation introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
21		*/
22	5	public function __construct(string $className)
23		{
24	5	$this->className = $className;
25	5	}
26
27		/**
28		* Determine if the validation rule passes.
29		*
30		* @param string $attribute
		2 ignored issues – show Coding Style Documentation introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history... Coding Style introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Expected 1 spaces after parameter type; 2 found Loading history...
31		* @param mixed $value
		1 ignored issue – show Coding Style Documentation introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
32		* @return bool
		1 ignored issue – show Coding Style introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Expected "boolean" but found "bool" for function return type Loading history...
33		*/
34	5	public function passes($attribute, $value)
		1 ignored issue – show introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\ValidIdRule::passes() does not have parameter type hint for its parameter $attribute but it should be possible to add it based on @param annotation "string". Loading history... introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\ValidIdRule::passes() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool". Loading history... Coding Style introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Type hint "string" missing for $attribute Loading history...
35		{
36	5	$model = $this->className;
37	5	return $model::where('id', $value)->exists();
38		}
39
40		/**
41		* Get the validation error message.
42		*
43		* @return string
44		*/
45	1	public function message()
		0 ignored issues – show introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\ValidIdRule::message() does not have return type hint for its return value but it should be possible to add it based on @return annotation "string". Loading history...
46		{
47	1	return Lang::get('validation.invalid_id');
		0 ignored issues – show Bug Best Practice introduced 2019-06-03 20:38 UTC by Report Bug Copy Issue Report The expression `return Illuminate\Suppor...validation.invalid_id')` also could return the type `array` which is incompatible with the documented return type `string`. Loading history...
48		}
49		}
50

GCTC-NTGC / TalentCloud

Push — feature/job-builder/xm-job-0-c... ( 9c31b2...b9bf9c )

ValidIdRule::passes() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like