App\Http\Requests\UpdateRatingGuideAnswer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	0	7	1
A	authorize()	0	8	2

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use App\Services\Validation\Rules\ValidIdRule;
use App\Models\Criteria;

class UpdateRatingGuideAnswer extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool

Expected "boolean" but found "bool" for function return type

     */
    public function authorize()

Method \App\Http\Requests\UpdateRatingGuideAnswer::authorize() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

    {
        // originalParameter avoids type hinting that automagically transforms the id into the RatingGuideAnswer object

Inline comments must start with a capital letter

        //$answer = RatingGuideAnswer::find($this->route()->originalParameter('ratingGuideAnswer'));

No space found before comment text; expected "// $answer = RatingGuideAnswer::find($this->route()->originalParameter('ratingGuideAnswer'));" but found "//$answer = RatingGuideAnswer::find($this->route()->originalParameter('ratingGuideAnswer'));"

There should be no blank line after an inline comment.

        // The id parameter in the route is typehinted to magically become a RatingGuideAnswer object.
        $answer = $this->route('ratingGuideAnswer');
        return $answer && $this->user()->can('update', $answer);
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array

@return annotation of method \App\Http\Requests\UpdateRatingGuideAnswer::rules() does not specify type hint for items of its traversable return value.

     */
    public function rules()

Method \App\Http\Requests\UpdateRatingGuideAnswer::rules() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array".

    {
        return [
            // RatingGuideQUestionId shouldn't be updated after creation
            //'rating_guide_question_id' => ['required', new RatingGuideQuestionRule()],

No space found before comment text; expected "// 'rating_guide_question_id' => ['required', new RatingGuideQuestionRule()]," but found "//'rating_guide_question_id' => ['required', new RatingGuideQuestionRule()],"

            'criterion_id' => ['nullable', new ValidIdRule(Criteria::class)],
            'expected_answer' => 'nullable|string',
        ];
    }
}