App\Http\Controllers\Api\JobTaskController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Test Coverage

Coverage

96.43%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	indexByJob()	0	5	1
A	toApiArray()	0	3	1
B	batchUpdate()	0	37	6

<?php

namespace App\Http\Controllers\Api;

use App\Models\JobPosterKeyTask;
use App\Models\JobPoster;
use App\Http\Controllers\Controller;
use App\Http\Requests\BatchUpdateJobTask;

class JobTaskController extends Controller
{
    /**
     * Converts a JobPosterKeyTask to an array appropriate for the api.
     *
     * @param JobPosterKeyTask $model

Missing parameter comment

     * @return void

Function return type is void, but function contains return statement

     */
    public function toApiArray(JobPosterKeyTask $model)
    {
        return array_merge($model->toArray(), $model->getTranslationsArray());
    }

    public function indexByJob(JobPoster $jobPoster)

Missing doc comment for function indexByJob()

    {
        $toApiArray = array($this, 'toApiArray');
        $taskArray = JobPosterKeyTask::where('job_poster_id', $jobPoster->id)->get()->map($toApiArray);
        return response()->json($taskArray);
    }

    /**
     * Update the set of tasks associated with a Job.
     *
     * @param  App\Http\Requests\BatchUpdateJobTask  $request

The type App\Http\Controllers\Api\App\Http\Requests\BatchUpdateJobTask was not found. Did you mean App\Http\Requests\BatchUpdateJobTask? If so, make sure to prefix the type with \.

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 16 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response
     */
    public function batchUpdate(BatchUpdateJobTask $request, JobPoster $jobPoster)
    {
        $toApiArray = array($this, 'toApiArray');

        $newTasks = collect($request->validated()); // Collection of JobPosterKeyTasks
        $oldTasks = $jobPoster->job_poster_key_tasks;

        $savedNewTaskIds = [];

        // First, delete old tasks that weren't resubmitted, and update those that were
        foreach ($oldTasks as $task) {
            $newTask = $newTasks->firstWhere('id', $task['id']);
            if ($newTask) {
                $savedNewTaskIds[] = $newTask['id'];
                $task->fill(collect($newTask)->only(['en', 'fr'])->toArray());
                $task->save();
            } else {
                $task->delete();
            }
        }

        $isUnsaved = function ($task, $savedTaskIds): bool {
            return !array_key_exists('id', $task) || !in_array($task['id'], $savedTaskIds);
        };

        // Now, save any new tasks that remain
        foreach ($newTasks as $task) {
            if ($isUnsaved($task, $savedNewTaskIds)) {
                $jobPosterTask = new JobPosterKeyTask();
                $jobPosterTask->job_poster_id = $jobPoster->id;
                $jobPosterTask->fill(collect($task)->only(['en', 'fr'])->toArray());
                $jobPosterTask->save();
            }
        }

        $taskArray = $jobPoster->fresh()->job_poster_key_tasks->map($toApiArray);
        return response()->json($taskArray);
    }
}