ManagerProfileController::update() - Code Metrics - Inspection of "Merge branch 'dev' into task/user-api-endpoint" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — task/user-api-endpoint ( 4d9513...f85fee )

by Chris
created 2020-02-07 13:57 UTC
ManagerProfileController::update() A

↳ Parent: ManagerProfileController
Complexity

Conditions	4
Paths	6
Size

Total Lines	32
Code Lines	20
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
eloc	20
dl	0
loc	32
rs	9.6
c	0
b	0
f	0
cc	4
nc	6
nop	2
<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Lang;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use App\Http\Requests\UpdateManagerProfileRequest;
use App\Models\Lookup\Frequency;
use App\Models\Lookup\Department;
use App\Models\Manager;
use App\Services\Validation\Rules\LinkedInUrlRule;
use App\Services\Validation\Rules\TwitterHandleRule;
use Illuminate\Support\Facades\Hash;

class ManagerProfileController extends Controller
{

    /**
     * Show a manager profile
     *
     * @param  \Illuminate\Http\Request $request Incoming Request.
     * @param  \App\Models\Manager      $manager Incoming Manager.
     * @return \Illuminate\Http\Response
     */
    public function show(Request $request, Manager $manager)
    {
        $manager_profile = Lang::get('applicant/manager_profile');

        $manager_profile_sections = [
            [
                'title' => $manager_profile['section_titles']['approach'],
                'questions' => [
                    [
                        'title' => $manager_profile['questions']['leadership_style'],
                        'answer' => $manager->leadership_style
                    ],
                    [
                        'title' => $manager_profile['questions']['employee_expectations'],
                        'answer' => $manager->expectations
                    ],
                    [
                        'title' => $manager_profile['questions']['employee_learning'],
                        'answer' => $manager->employee_learning
                    ]
                ]
            ],
            [
                'title' => $manager_profile['section_titles']['about_me'],
                'questions' => [
                    [
                        'title' => $manager_profile['questions']['career_journey'],
                        'answer' => $manager->career_journey
                    ],
                    [
                        'title' => $manager_profile['questions']['learning_path'],
                        'answer' => $manager->learning_path
                    ],
                    [
                        'title' => $manager_profile['questions']['about_me'],
                        'answer' => $manager->about_me
                    ]
                ]
            ]
        ];

        return view('applicant/manager', [
        return /** @scrutinizer ignore-call */ view('applicant/manager', [
            'manager_profile' => $manager_profile,
            'urls' => Lang::get('common/urls'),
            'manager' => $manager,
            'manager_profile_photo_url' => '/images/user.png', // TODO get real photo.
            'manager_profile_sections' => $manager_profile_sections,
            'noInfo' => $manager_profile['no_info'],
        ]);
    }

    /**
     * Show the form for editing the logged-in manager's profile
     *
     * @param  \Illuminate\Http\Request $request Incoming Request.
     * @return \Illuminate\Http\Response
     */
    public function editAuthenticated(Request $request)
    {
        $manager = $request->user()->manager;
        return redirect(route('manager.profile.edit', $manager));
        return redirect(/** @scrutinizer ignore-call */ route('manager.profile.edit', $manager));
    }

    /**
     * Show the form for editing the logged-in user's manager profile
     *
     * @param  \Illuminate\Http\Request $request Incoming Request.
     * @param  \App\Models\Manager      $manager Incoming Manager.
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, Manager $manager)
    {
        // TODO: Improve workplace photos, and reference them in template direction from WorkEnvironment model.
        $workplacePhotos = [];

        $frequencies = Frequency::all();
        $linkedInUrlPattern = LinkedInUrlRule::PATTERN;
        $twitterHandlePattern = TwitterHandleRule::PATTERN;

        return view('manager/profile', [
        return /** @scrutinizer ignore-call */ view('manager/profile', [
            // Localization.
            'profile_l10n' => Lang::get('manager/profile'),
            // Data.
            'urls' => Lang::get('common/urls'),
            'user' => $manager->user,
            'manager' => $manager,
            'manager_profile_photo_url' => '/images/user.png', // TODO get real photo.
            'workplace_photos' => $workplacePhotos,
            'departments' => Department::all(),
            'telework_options' => $frequencies,
            'flex_hour_options' => $frequencies,
            'radio_options' => $frequencies,
            'translations' => $manager->getTranslations(),
            'linkedInUrlPattern' => $linkedInUrlPattern,
            'twitterHandlePattern' => $twitterHandlePattern,
        ]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\UpdateManagerProfileRequest $request Incoming Request.
     * @param  \App\Models\Manager                          $manager Incoming Manager.
     * @return \Illuminate\Http\Response
     */
    public function update(UpdateManagerProfileRequest $request, Manager $manager)
    {
        // TODO: save workplace Photos.
        // TODO: remove control of name in production.
        $input = $request->input();

        $validated = $request->validated();

        $user = $manager->user;
        $user->fill($validated);
        if (!empty($input['new_password'])) {
            $user->password = Hash::make($input['new_password']);
        }
        $user->save();

        $manager->fill($validated);
        $manager->save();

        // Use the button that was clicked to decide which element to redirect to.
        switch ($input['submit']) {
            case 'about_me':
                $hash = '#managerProfileSectionAbout';
                break;
            case 'leadership':
                $hash = '#managerProfileSectionLeadership';
                break;
            default:
                $hash = '';
                break;
        }

        return redirect(route('manager.profile.edit', $manager) . $hash);
        return /** @scrutinizer ignore-call */ redirect(route('manager.profile.edit', $manager) . $hash);
    }

    public function faq(Request $request)
    {
        $show_demo_notification = $request->user() && $request->user()->isDemoManager();

        return view(
        return /** @scrutinizer ignore-call */ view(
            'applicant/static_faq',
            [
                'breadcrumb_home' => route('manager.home'),
                'breadcrumb_home' => /** @scrutinizer ignore-call */ route('manager.home'),
                'faq' => Lang::get('applicant/faq'),
                'manager_sidebar_active' => 'active',
                'show_demo_notification' => $show_demo_notification,
            ]
        );
    }
}

GCTC-NTGC / TalentCloud

Push — task/user-api-endpoint ( 4d9513...f85fee )

ManagerProfileController::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
