GCTC-NTGC / TalentCloud

app/Services/Validation/Rules/CourseValidator.php

Indentation +5 added lines, -5 removed lines

@@ -25,13 +25,13 @@
         //Validate basic data is filled in
         Validator::make($courseValidator->getAttributes(), [ 
             'applicant_id' => [
-             'required',
+                'required',
                 Rule::in($applicant_ids->toArray()),
-       ],
-             'course_status_id' => [
-             'required',
+        ],
+                'course_status_id' => [
+                'required',
                 Rule::in($this->course_status_ids->toArray()),    
-     ]
+        ]
          
         ])->validate();
     }

Spacing +7 added lines, -7 removed lines

@@ -15,25 +15,25 @@
     public function __construct(Applicant $applicant)
     {
         $this->applicant = $applicant;
-        $this->course_status_ids = CourseStatus::all()->pluck('id');
+        $this->course_status_ids = CourseStatus::all ()->pluck ('id');
     }
     public function validate(CourseValidator $courseValidator)
     {
-        $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $courseValidator->id);
+        $uniqueSkillRule = new UniqueApplicantSkillRule ($this->applicant, $courseValidator->id);
         //This array is reset every time because applicants table can change frequently
-        $applicant_ids = Applicant::all()->pluck('id');
+        $applicant_ids = Applicant::all ()->pluck ('id');
         //Validate basic data is filled in
-        Validator::make($courseValidator->getAttributes(), [ 
+        Validator::make ($courseValidator->getAttributes (), [ 
             'applicant_id' => [
              'required',
-                Rule::in($applicant_ids->toArray()),
+                Rule::in ($applicant_ids->toArray ()),
        ],
              'course_status_id' => [
              'required',
-                Rule::in($this->course_status_ids->toArray()),    
+                Rule::in ($this->course_status_ids->toArray ()),    
      ]
          
-        ])->validate();
+        ])->validate ();
     }
     
 }
\ No newline at end of file

app/Utilities/HandleNullState.php

Indentation +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     public function getFunctions(): array
     {
         return [
-          new Twig_SimpleFunction('handleNullState', [$this, 'handleNullState']),
+            new Twig_SimpleFunction('handleNullState', [$this, 'handleNullState']),
         ];
     }
 

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     public function getFunctions(): array
     {
         return [
-          new Twig_SimpleFunction('handleNullState', [$this, 'handleNullState']),
+          new Twig_SimpleFunction ('handleNullState', [$this, 'handleNullState']),
         ];
     }
 

app/Models/Criteria.php

Indentation +2 added lines, -2 removed lines

@@ -28,8 +28,8 @@
  * @property string $level_description The localized description of the skill level (accounts for skill type).
  *
  *  Localized Properties:
-  * @property string $description
-  * @property string $specificity
+ * @property string $description
+ * @property string $specificity
  */
 class Criteria extends BaseModel
 {

Spacing +8 added lines, -8 removed lines

@@ -65,27 +65,27 @@ 
 
     public function criteria_type() //phpcs:ignore
     {
-        return $this->belongsTo(\App\Models\Lookup\CriteriaType::class);
+        return $this->belongsTo (\App\Models\Lookup\CriteriaType::class);
     }
 
     public function job_poster() //phpcs:ignore
     {
-        return $this->belongsTo(\App\Models\JobPoster::class);
+        return $this->belongsTo (\App\Models\JobPoster::class);
     }
 
     public function skill()
     {
-        return $this->belongsTo(\App\Models\Skill::class);
+        return $this->belongsTo (\App\Models\Skill::class);
     }
 
     public function skill_level() //phpcs:ignore
     {
-        return $this->belongsTo(\App\Models\Lookup\SkillLevel::class);
+        return $this->belongsTo (\App\Models\Lookup\SkillLevel::class);
     }
 
     public function criteria_translations() //phpcs:ignore
     {
-        return $this->hasMany(\App\Models\Lookup\CriteriaTypeTranslation::class);
+        return $this->hasMany (\App\Models\Lookup\CriteriaTypeTranslation::class);
     }
 
     /**
@@ -95,7 +95,7 @@ 
      */
     public function assessments() // phpcs:ignore
     {
-        return $this->hasMany(\App\Models\Assessment::class, 'criterion_id');
+        return $this->hasMany (\App\Models\Assessment::class, 'criterion_id');
     }
 
     /**
@@ -107,7 +107,7 @@ 
     {
         $level = $this->skill_level->name;
         $type = $this->skill->skill_type->name;
-        return Lang::get("common/lookup/skill_level.$level.$type.name");
+        return Lang::get ("common/lookup/skill_level.$level.$type.name");
     }
 
     /**
@@ -119,6 +119,6 @@ 
     {
         $level = $this->skill_level->name;
         $type = $this->skill->skill_type->name;
-        return Lang::get("common/lookup/skill_level.$level.$type.description");
+        return Lang::get ("common/lookup/skill_level.$level.$type.description");
     }
 }

app/Models/User.php

Indentation +7 added lines, -7 removed lines

@@ -173,10 +173,10 @@ 
     }
 
     /**
-    * Check if the user has the specified role.
-    * @param string $role This may be either 'applicant', 'manager' or 'admin'.
-    * @return boolean
-    */
+     * Check if the user has the specified role.
+     * @param string $role This may be either 'applicant', 'manager' or 'admin'.
+     * @return boolean
+     */
     public function hasRole($role)
     {
         switch ($role) {
@@ -195,8 +195,8 @@ 
      * Set this user to the specified role.
      *
      * @param string $role Must be either 'applicant', 'manager' or 'admin.
-    * @return void
-    */
+     * @return void
+     */
     public function setRole(string $role): void
     {
         $this->user_role()->associate(UserRole::where('name', $role)->firstOrFail());
@@ -231,7 +231,7 @@ 
      * Returns a user's full name.
      *
      * @return string
-    */
+     */
     public function getFullNameAttribute(): string
     {
         return $this->first_name . ' ' . $this->last_name;

Spacing +13 added lines, -13 removed lines

@@ -91,22 +91,22 @@ 
 
     public function applicant() //phpcs:ignore
     {
-        return $this->hasOne(\App\Models\Applicant::class);
+        return $this->hasOne (\App\Models\Applicant::class);
     }
 
     public function manager() //phpcs:ignore
     {
-        return $this->hasOne(\App\Models\Manager::class);
+        return $this->hasOne (\App\Models\Manager::class);
     }
 
     public function profile_pic() //phpcs:ignore
     {
-        return $this->hasOne(\App\Models\ProfilePic::class);
+        return $this->hasOne (\App\Models\ProfilePic::class);
     }
 
     public function user_role() //phpcs:ignore
     {
-        return $this->belongsTo(\App\Models\UserRole::class);
+        return $this->belongsTo (\App\Models\UserRole::class);
     }
 
     public function setIsPriorityAttribute($value)
@@ -137,7 +137,7 @@ 
      */
     public function isUpgradedManager(): bool
     {
-        return $this->isAdmin() || $this->user_role->name === 'upgradedManager';
+        return $this->isAdmin () || $this->user_role->name === 'upgradedManager';
     }
 
     /**
@@ -148,7 +148,7 @@ 
     public function isDemoManager(): bool
     {
         // Currently, every non-upgradedManager user can be considered a demoManager.
-        return !$this->isUpgradedManager();
+        return !$this->isUpgradedManager ();
     }
 
     /**
@@ -159,7 +159,7 @@ 
     public function isManager(): bool
     {
         // Currently, every user can use the Manager portal as a demoManager.
-        return $this->isDemoManager() || $this->isUpgradedManager();
+        return $this->isDemoManager () || $this->isUpgradedManager ();
     }
 
     /**
@@ -181,11 +181,11 @@ 
     {
         switch ($role) {
             case 'applicant':
-                return $this->isApplicant();
+                return $this->isApplicant ();
             case 'manager':
-                return $this->isManager();
+                return $this->isManager ();
             case 'admin':
-                return $this->isAdmin();
+                return $this->isAdmin ();
             default:
                 return false;
         }
@@ -199,7 +199,7 @@ 
     */
     public function setRole(string $role): void
     {
-        $this->user_role()->associate(UserRole::where('name', $role)->firstOrFail());
+        $this->user_role ()->associate (UserRole::where ('name', $role)->firstOrFail ());
     }
 
     /**
@@ -212,7 +212,7 @@ 
      */
     public function sendPasswordResetNotification($token): void
     {
-        $this->notify(new ResetPasswordNotification($token));
+        $this->notify (new ResetPasswordNotification ($token));
     }
 
     /**
@@ -234,6 +234,6 @@ 
     */
     public function getFullNameAttribute(): string
     {
-        return $this->first_name . ' ' . $this->last_name;
+        return $this->first_name.' '.$this->last_name;
     }
 }

app/Models/Lookup/Frequency.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
  * @property \Jenssegers\Date\Date $created_at
  * @property \Jenssegers\Date\Date $updated_at
  */
-class Frequency extends BaseModel {
+class Frequency extends BaseModel{
 
     protected $fillable = [];
 

routes/web.php

Indentation +1 added lines, -1 removed lines

@@ -480,7 +480,7 @@
         ->middleware('can:update,jobPoster');
 
 
-     Route::get('jobs/{jobPoster}/criteria', 'Api\CriteriaController@indexByJob')
+        Route::get('jobs/{jobPoster}/criteria', 'Api\CriteriaController@indexByJob')
         ->where('jobPoster', '[0-9]+')
         ->middleware('can:view,jobPoster');
     Route::put('jobs/{jobPoster}/criteria', 'Api\CriteriaController@batchUpdate')

Spacing +251 added lines, -251 removed lines

@@ -13,433 +13,433 @@ 
 |
  */
 
-Route::group(
+Route::group (
     [
-        'prefix' => LaravelLocalization::setLocale(),
+        'prefix' => LaravelLocalization::setLocale (),
         'middleware' => ['localeSessionRedirect', 'localizationRedirect', 'localeViewPath']
     ],
     function () : void {
         /** ADD ALL LOCALIZED ROUTES INSIDE THIS GROUP **/
 
-        Route::group(['prefix' => 'demo'], function () : void {
+        Route::group (['prefix' => 'demo'], function () : void {
 
             /* Temporary Blog Index */
-            Route::view('blog', 'common/blog-index')->middleware('localOnly')->name('blog');
+            Route::view ('blog', 'common/blog-index')->middleware ('localOnly')->name ('blog');
 
             /* Temporary Blog Post */
-            Route::view('post', 'common/blog-post')->middleware('localOnly')->name('post');
+            Route::view ('post', 'common/blog-post')->middleware ('localOnly')->name ('post');
 
             /* Static - Reliability Form Demo */
-            Route::view('reliability', 'demos/reliability/index', ['reliability' => Lang::get('common/reliability')])->name('reliability');
+            Route::view ('reliability', 'demos/reliability/index', ['reliability' => Lang::get ('common/reliability')])->name ('reliability');
 
             // /* Temp Builder 01 (Intro) */
-            Route::view('builder-01', 'manager/builder-01')->middleware('localOnly')->name('jpb1');
+            Route::view ('builder-01', 'manager/builder-01')->middleware ('localOnly')->name ('jpb1');
             // /* Temp Builder 02 (Job info) */
-            Route::view('builder-02', 'manager/builder-02')->middleware('localOnly')->name('jpb2');
+            Route::view ('builder-02', 'manager/builder-02')->middleware ('localOnly')->name ('jpb2');
             // /* Temp Builder 03 (Work Environment) */
-            Route::view('builder-03', 'manager/builder-03')->middleware('localOnly')->name('jpb3');
+            Route::view ('builder-03', 'manager/builder-03')->middleware ('localOnly')->name ('jpb3');
             // /* Temp Builder 04 (Impact) */
-            Route::view('builder-04', 'manager/builder-04')->middleware('localOnly')->name('jpb4');
+            Route::view ('builder-04', 'manager/builder-04')->middleware ('localOnly')->name ('jpb4');
             // /* Temp Builder 05 (Tasks) */
-            Route::view('builder-05', 'manager/builder-05')->middleware('localOnly')->name('jpb5');
+            Route::view ('builder-05', 'manager/builder-05')->middleware ('localOnly')->name ('jpb5');
             // /* Temp Builder 06 (Skills) */
-            Route::view('builder-06', 'manager/builder-06')->middleware('localOnly')->name('jpb6');
+            Route::view ('builder-06', 'manager/builder-06')->middleware ('localOnly')->name ('jpb6');
             // /* Temp Builder 07 (Education) */
-            Route::view('builder-07', 'manager/builder-07')->middleware('localOnly')->name('jpb7');
+            Route::view ('builder-07', 'manager/builder-07')->middleware ('localOnly')->name ('jpb7');
             // /* Temp Builder 08 (Review) */
-            Route::view('builder-08', 'manager/builder-08')->middleware('localOnly')->name('jpb8');
+            Route::view ('builder-08', 'manager/builder-08')->middleware ('localOnly')->name ('jpb8');
         });
 
 
-        Route::group(['prefix' => config('app.applicant_prefix')], function () : void {
+        Route::group (['prefix' => config ('app.applicant_prefix')], function () : void {
 
             /* Home */
-            Route::get('/', 'HomepageController@applicant')->name('home');
+            Route::get ('/', 'HomepageController@applicant')->name ('home');
 
             /* Jobs */
-            Route::get('jobs', 'JobController@index')->name('jobs.index');
+            Route::get ('jobs', 'JobController@index')->name ('jobs.index');
 
-            Route::get('jobs/{jobPoster}', 'JobController@show')
-                ->middleware('can:view,jobPoster')
-                ->name('jobs.show');
+            Route::get ('jobs/{jobPoster}', 'JobController@show')
+                ->middleware ('can:view,jobPoster')
+                ->name ('jobs.show');
 
             /* Require being logged in */
-            Route::middleware(['auth'])->group(function () : void {
+            Route::middleware (['auth'])->group (function () : void {
                 /* Managers */
-                Route::get('managers/{manager}', 'ManagerProfileController@show')
-                    ->middleware('can:view,manager')
-                    ->name('managers.show');
+                Route::get ('managers/{manager}', 'ManagerProfileController@show')
+                    ->middleware ('can:view,manager')
+                    ->name ('managers.show');
             });
 
             /* Require being logged in as applicant */
-            Route::middleware(['auth', 'role:applicant'])->group(function () : void {
+            Route::middleware (['auth', 'role:applicant'])->group (function () : void {
 
             // Application permissions are handled within the controller instead of with middleware
                 /* Applications */
-                Route::get('applications', 'ApplicationController@index')->name('applications.index');
+                Route::get ('applications', 'ApplicationController@index')->name ('applications.index');
 
                 /* View Application */
-                Route::get('applications/{application}', 'ApplicationController@show')
-                    ->middleware('can:view,application')
-                    ->name('applications.show');
+                Route::get ('applications/{application}', 'ApplicationController@show')
+                    ->middleware ('can:view,application')
+                    ->name ('applications.show');
 
                 /* Step 01 */
-                Route::get('jobs/{jobPoster}/application/step-01', 'ApplicationByJobController@editBasics')->name('job.application.edit.1');
+                Route::get ('jobs/{jobPoster}/application/step-01', 'ApplicationByJobController@editBasics')->name ('job.application.edit.1');
 
                 /* Step 02 */
-                Route::get('jobs/{jobPoster}/application/step-02', 'ApplicationByJobController@editExperience')->name('job.application.edit.2');
+                Route::get ('jobs/{jobPoster}/application/step-02', 'ApplicationByJobController@editExperience')->name ('job.application.edit.2');
 
                 /* Step 03 */
-                Route::get('jobs/{jobPoster}/application/step-03', 'ApplicationByJobController@editEssentialSkills')->name('job.application.edit.3');
+                Route::get ('jobs/{jobPoster}/application/step-03', 'ApplicationByJobController@editEssentialSkills')->name ('job.application.edit.3');
 
                 /* Step 04 */
-                Route::get('jobs/{jobPoster}/application/step-04', 'ApplicationByJobController@editAssetSkills')->name('job.application.edit.4');
+                Route::get ('jobs/{jobPoster}/application/step-04', 'ApplicationByJobController@editAssetSkills')->name ('job.application.edit.4');
 
                 /* Step 05 */
-                Route::get('jobs/{jobPoster}/application/step-05', 'ApplicationByJobController@preview')->name('job.application.edit.5');
+                Route::get ('jobs/{jobPoster}/application/step-05', 'ApplicationByJobController@preview')->name ('job.application.edit.5');
 
                 /* Step 06 */
-                Route::get('jobs/{jobPoster}/application/step-06', 'ApplicationByJobController@confirm')->name('job.application.edit.6');
+                Route::get ('jobs/{jobPoster}/application/step-06', 'ApplicationByJobController@confirm')->name ('job.application.edit.6');
 
                 /* Step 06: Complete */
-                Route::get('jobs/{jobPoster}/application/complete', 'ApplicationByJobController@complete')->name('job.application.complete');
+                Route::get ('jobs/{jobPoster}/application/complete', 'ApplicationByJobController@complete')->name ('job.application.complete');
 
                 /* Application Update routes */
 
                 /* Step 01 */
-                Route::post('jobs/{jobPoster}/application/step-01/update', 'ApplicationByJobController@updateBasics')->name('job.application.update.1');
+                Route::post ('jobs/{jobPoster}/application/step-01/update', 'ApplicationByJobController@updateBasics')->name ('job.application.update.1');
 
                 /* Step 02 */
-                Route::post('jobs/{jobPoster}/application/step-02/update', 'ApplicationByJobController@updateExperience')->name('job.application.update.2');
+                Route::post ('jobs/{jobPoster}/application/step-02/update', 'ApplicationByJobController@updateExperience')->name ('job.application.update.2');
 
                 /* Step 03 */
-                Route::post('jobs/{jobPoster}/application/step-03/update', 'ApplicationByJobController@updateEssentialSkills')->name('job.application.update.3');
+                Route::post ('jobs/{jobPoster}/application/step-03/update', 'ApplicationByJobController@updateEssentialSkills')->name ('job.application.update.3');
 
                 /* Step 04 */
-                Route::post('jobs/{jobPoster}/application/step-04/update', 'ApplicationByJobController@updateAssetSkills')->name('job.application.update.4');
+                Route::post ('jobs/{jobPoster}/application/step-04/update', 'ApplicationByJobController@updateAssetSkills')->name ('job.application.update.4');
 
                 /* Step 05 */
-                Route::post('jobs/{jobPoster}/application/submit', 'ApplicationByJobController@submit')->name('job.application.submit');
+                Route::post ('jobs/{jobPoster}/application/submit', 'ApplicationByJobController@submit')->name ('job.application.submit');
 
-                Route::get('profile', 'ApplicantProfileController@editAuthenticated')->name('profile');
-                Route::get('profile/about', 'ApplicantProfileController@editAuthenticated');
+                Route::get ('profile', 'ApplicantProfileController@editAuthenticated')->name ('profile');
+                Route::get ('profile/about', 'ApplicantProfileController@editAuthenticated');
 
                 /* Profile - About Me */
-                Route::get('profile/{applicant}/about', 'ApplicantProfileController@edit')
-                    ->middleware('can:view,applicant')
-                    ->middleware('can:update,applicant')
-                    ->name('profile.about.edit');
+                Route::get ('profile/{applicant}/about', 'ApplicantProfileController@edit')
+                    ->middleware ('can:view,applicant')
+                    ->middleware ('can:update,applicant')
+                    ->name ('profile.about.edit');
 
-                Route::post('profile/{applicant}/about/update', 'ApplicantProfileController@update')
-                    ->middleware('can:update,applicant')
-                    ->name('profile.about.update');
+                Route::post ('profile/{applicant}/about/update', 'ApplicantProfileController@update')
+                    ->middleware ('can:update,applicant')
+                    ->name ('profile.about.update');
 
                 /* Profile - My Experience */
-                Route::get('profile/experience', 'ExperienceController@editAuthenticated');
+                Route::get ('profile/experience', 'ExperienceController@editAuthenticated');
 
-                Route::get('profile/{applicant}/experience', 'ExperienceController@edit')
-                    ->middleware('can:view,applicant')
-                    ->middleware('can:update,applicant')
-                    ->name('profile.experience.edit');
+                Route::get ('profile/{applicant}/experience', 'ExperienceController@edit')
+                    ->middleware ('can:view,applicant')
+                    ->middleware ('can:update,applicant')
+                    ->name ('profile.experience.edit');
 
-                Route::post('profile/{applicant}/experience/update', 'ExperienceController@update')
-                    ->middleware('can:update,applicant')
-                    ->name('profile.experience.update');
+                Route::post ('profile/{applicant}/experience/update', 'ExperienceController@update')
+                    ->middleware ('can:update,applicant')
+                    ->name ('profile.experience.update');
 
                 /* Profile - My Skills */
-                Route::get('profile/skills', 'SkillDeclarationController@editAuthenticated');
+                Route::get ('profile/skills', 'SkillDeclarationController@editAuthenticated');
 
-                Route::get('profile/{applicant}/skills', 'SkillDeclarationController@edit')
-                    ->middleware('can:view,applicant')
-                    ->middleware('can:update,applicant')
-                    ->name('profile.skills.edit');
+                Route::get ('profile/{applicant}/skills', 'SkillDeclarationController@edit')
+                    ->middleware ('can:view,applicant')
+                    ->middleware ('can:update,applicant')
+                    ->name ('profile.skills.edit');
 
                 /* Profile - My References */
-                Route::get('profile/references', 'ReferencesController@editAuthenticated');
+                Route::get ('profile/references', 'ReferencesController@editAuthenticated');
 
-                Route::get('profile/{applicant}/references', 'ReferencesController@edit')
-                    ->middleware('can:view,applicant')
-                    ->middleware('can:update,applicant')
-                    ->name('profile.references.edit');
+                Route::get ('profile/{applicant}/references', 'ReferencesController@edit')
+                    ->middleware ('can:view,applicant')
+                    ->middleware ('can:update,applicant')
+                    ->name ('profile.references.edit');
 
                 /* Profile - My Portfolio */
-                Route::get('profile/portfolio', 'WorkSamplesController@editAuthenticated');
+                Route::get ('profile/portfolio', 'WorkSamplesController@editAuthenticated');
 
-                Route::get('profile/{applicant}/portfolio', 'WorkSamplesController@edit')
-                    ->middleware('can:view,applicant')
-                    ->middleware('can:update,applicant')
-                    ->name('profile.work_samples.edit');
+                Route::get ('profile/{applicant}/portfolio', 'WorkSamplesController@edit')
+                    ->middleware ('can:view,applicant')
+                    ->middleware ('can:update,applicant')
+                    ->name ('profile.work_samples.edit');
             });
 
             /* Static - FAQ */
-            Route::get('faq', 'FaqController')->name('faq');
+            Route::get ('faq', 'FaqController')->name ('faq');
 
             /* Static - Privacy Policy */
-            Route::view('privacy', 'common/static_privacy', ['privacy' => Lang::get('common/privacy')])
-                ->name('privacy');
+            Route::view ('privacy', 'common/static_privacy', ['privacy' => Lang::get ('common/privacy')])
+                ->name ('privacy');
 
             /* Static - Terms of Service */
-            Route::view('tos', 'common/static_tos', ['tos' => Lang::get('common/tos')])->name('tos');
+            Route::view ('tos', 'common/static_tos', ['tos' => Lang::get ('common/tos')])->name ('tos');
 
             /* Static - ITP */
-            Route::view('indigenous', 'common/static-itp', ['itp' => Lang::get('common/itp')])->name('itp');
+            Route::view ('indigenous', 'common/static-itp', ['itp' => Lang::get ('common/itp')])->name ('itp');
 
             /* Authentication =========================================================== */
 
             // Laravel default login, logout, register, and reset routes
-            Route::get('login', 'Auth\LoginController@showLoginForm')->name('login');
-            Route::post('login', 'Auth\LoginController@login')->name('login.post');
-            Route::post('logout', 'Auth\LoginController@logout')->name('logout');
+            Route::get ('login', 'Auth\LoginController@showLoginForm')->name ('login');
+            Route::post ('login', 'Auth\LoginController@login')->name ('login.post');
+            Route::post ('logout', 'Auth\LoginController@logout')->name ('logout');
 
             // Registration Routes...
-            Route::get('register', 'Auth\RegisterController@showRegistrationForm')->name('register');
-            Route::post('register', 'Auth\RegisterController@register')->name('register.post');
+            Route::get ('register', 'Auth\RegisterController@showRegistrationForm')->name ('register');
+            Route::post ('register', 'Auth\RegisterController@register')->name ('register.post');
 
             // Password Reset Routes...
-            Route::get('password/reset', 'Auth\ForgotPasswordController@showLinkRequestForm')->name('password.request');
-            Route::post('password/email', 'Auth\ForgotPasswordController@sendResetLinkEmail')->name('password.email');
-            Route::get('password/reset/{token}', 'Auth\ResetPasswordController@showResetForm')->name('password.reset');
-            Route::post('password/reset', 'Auth\ResetPasswordController@reset')->name('password.reset.post');
+            Route::get ('password/reset', 'Auth\ForgotPasswordController@showLinkRequestForm')->name ('password.request');
+            Route::post ('password/email', 'Auth\ForgotPasswordController@sendResetLinkEmail')->name ('password.email');
+            Route::get ('password/reset/{token}', 'Auth\ResetPasswordController@showResetForm')->name ('password.reset');
+            Route::post ('password/reset', 'Auth\ResetPasswordController@reset')->name ('password.reset.post');
         });
 
 
         /* Manager Portal =========================================================== */
 
-        Route::group([
-            'prefix' => config('app.manager_prefix'),
+        Route::group ([
+            'prefix' => config ('app.manager_prefix'),
         ], function (): void {
 
-            Route::middleware(['finishManagerRegistration'])->group(function (): void {
+            Route::middleware (['finishManagerRegistration'])->group (function (): void {
 
                 /* Home */
-                Route::get('/', 'HomepageController@manager')->name('manager.home');
+                Route::get ('/', 'HomepageController@manager')->name ('manager.home');
 
                 /* Static - FAQ */
-                Route::get(
+                Route::get (
                     'faq',
                     'ManagerProfileController@faq'
-                )->name('manager.faq');
+                )->name ('manager.faq');
 
-                Route::get(
+                Route::get (
                     'faq#manager-who',
                     'ManagerProfileController@faq'
-                )->name('manager.faq.section');
+                )->name ('manager.faq.section');
 
-                Route::middleware(['auth', 'role:manager'])->group(function (): void {
+                Route::middleware (['auth', 'role:manager'])->group (function (): void {
 
-                    Route::get('profile', 'ManagerProfileController@editAuthenticated')->name('manager.profile');
+                    Route::get ('profile', 'ManagerProfileController@editAuthenticated')->name ('manager.profile');
 
                     /* Profile */
-                    Route::get('profile/{manager}/edit', 'ManagerProfileController@edit')
-                    ->middleware('can:view,manager')
-                    ->middleware('can:update,manager')
-                    ->name('manager.profile.edit');
+                    Route::get ('profile/{manager}/edit', 'ManagerProfileController@edit')
+                    ->middleware ('can:view,manager')
+                    ->middleware ('can:update,manager')
+                    ->name ('manager.profile.edit');
 
-                    Route::post('profile/{manager}/update', 'ManagerProfileController@update')
-                    ->middleware('can:update,manager')
-                    ->name('manager.profile.update');
+                    Route::post ('profile/{manager}/update', 'ManagerProfileController@update')
+                    ->middleware ('can:update,manager')
+                    ->name ('manager.profile.update');
 
                     /* View Application */
-                    Route::get('applications/{application}', 'ApplicationController@show')
-                    ->middleware('can:view,application')
-                    ->name('manager.applications.show');
+                    Route::get ('applications/{application}', 'ApplicationController@show')
+                    ->middleware ('can:view,application')
+                    ->name ('manager.applications.show');
 
                     /* View Applicant Profile */
-                    Route::get('applicants/{applicant}', 'ApplicantProfileController@show')
-                    ->middleware('can:view,applicant')
-                    ->name('manager.applicants.show');
+                    Route::get ('applicants/{applicant}', 'ApplicantProfileController@show')
+                    ->middleware ('can:view,applicant')
+                    ->name ('manager.applicants.show');
 
                     /* Job Index */
-                    Route::get('jobs', 'JobController@managerIndex')->name('manager.jobs.index');
+                    Route::get ('jobs', 'JobController@managerIndex')->name ('manager.jobs.index');
 
                     /* View Job Poster */
-                    Route::get('jobs/{jobPoster}', 'JobController@show')
-                    ->where('jobPoster', '[0-9]+')
-                    ->middleware('can:view,jobPoster')
-                    ->name('manager.jobs.show');
+                    Route::get ('jobs/{jobPoster}', 'JobController@show')
+                    ->where ('jobPoster', '[0-9]+')
+                    ->middleware ('can:view,jobPoster')
+                    ->name ('manager.jobs.show');
 
-                    Route::get('jobs/{jobPoster}/applications', 'ApplicationByJobController@index')
-                    ->where('jobPoster', '[0-9]+')
-                    ->middleware('can:reviewApplicationsFor,jobPoster')
-                    ->name('manager.jobs.applications');
+                    Route::get ('jobs/{jobPoster}/applications', 'ApplicationByJobController@index')
+                    ->where ('jobPoster', '[0-9]+')
+                    ->middleware ('can:reviewApplicationsFor,jobPoster')
+                    ->name ('manager.jobs.applications');
 
                     /* Job Builder */
-                    Route::get(
+                    Route::get (
                         'jobs/builder',
                         'JobBuilderController@show'
-                    )->name('manager.jobs.create');
+                    )->name ('manager.jobs.create');
 
-                    Route::get(
+                    Route::get (
                         'jobs/{jobId}/builder',
                         'JobBuilderController@show'
                     )
-                        ->where('jobPoster', '[0-9]+')
-                        ->name('manager.jobs.edit');
-                    Route::get(
+                        ->where ('jobPoster', '[0-9]+')
+                        ->name ('manager.jobs.edit');
+                    Route::get (
                         'jobs/{jobId}/builder/intro',
                         'JobBuilderController@show'
-                    )->where('jobPoster', '[0-9]+');
-                    Route::get(
+                    )->where ('jobPoster', '[0-9]+');
+                    Route::get (
                         'jobs/{jobId}/builder/details',
                         'JobBuilderController@show'
-                    )->where('jobPoster', '[0-9]+');
-                    Route::get(
+                    )->where ('jobPoster', '[0-9]+');
+                    Route::get (
                         'jobs/{jobId}/builder/environment',
                         'JobBuilderController@show'
-                    )->where('jobPoster', '[0-9]+');
-                    Route::get(
+                    )->where ('jobPoster', '[0-9]+');
+                    Route::get (
                         'jobs/{jobId}/builder/impact',
                         'JobBuilderController@show'
-                    )->where('jobPoster', '[0-9]+');
-                    Route::get(
+                    )->where ('jobPoster', '[0-9]+');
+                    Route::get (
                         'jobs/{jobId}/builder/tasks',
                         'JobBuilderController@show'
-                    )->where('jobPoster', '[0-9]+');
-                    Route::get(
+                    )->where ('jobPoster', '[0-9]+');
+                    Route::get (
                         'jobs/{jobId}/builder/skills',
                         'JobBuilderController@show'
-                    )->where('jobPoster', '[0-9]+');
-                    Route::get(
+                    )->where ('jobPoster', '[0-9]+');
+                    Route::get (
                         'jobs/{jobId}/builder/review',
                         'JobBuilderController@show'
                     )
-                        ->where('jobPoster', '[0-9]+')
-                        ->name('manager.jobs.review');
+                        ->where ('jobPoster', '[0-9]+')
+                        ->name ('manager.jobs.review');
 
                     /* Delete Job */
-                    Route::delete('jobs/{jobPoster}', 'JobController@destroy')
-                        ->where('jobPoster', '[0-9]+')
-                        ->middleware('can:delete,jobPoster')
-                        ->name('manager.jobs.destroy');
+                    Route::delete ('jobs/{jobPoster}', 'JobController@destroy')
+                        ->where ('jobPoster', '[0-9]+')
+                        ->middleware ('can:delete,jobPoster')
+                        ->name ('manager.jobs.destroy');
 
-                    Route::view(
+                    Route::view (
                         'jobs/{jobPoster}/assessment-plan',
                         'manager/assessment_plan'
                     )
-                        ->where('jobPoster', '[0-9]+')
-                        ->name('manager.jobs.screening_plan');
+                        ->where ('jobPoster', '[0-9]+')
+                        ->name ('manager.jobs.screening_plan');
                 });
             });
 
             // These routes must be excluded from the finishManagerRegistration middleware to avoid an infinite loop of redirects
-            Route::middleware(['auth', 'role:manager'])->group(function (): void {
-                Route::get('first-visit', 'Auth\FirstVisitController@showFirstVisitManagerForm')
-                    ->name('manager.first_visit');
-                Route::post('finish_registration', 'Auth\FirstVisitController@finishManagerRegistration')
-                    ->name('manager.finish_registration');
+            Route::middleware (['auth', 'role:manager'])->group (function (): void {
+                Route::get ('first-visit', 'Auth\FirstVisitController@showFirstVisitManagerForm')
+                    ->name ('manager.first_visit');
+                Route::post ('finish_registration', 'Auth\FirstVisitController@finishManagerRegistration')
+                    ->name ('manager.finish_registration');
             });
 
             // Laravel default login, logout, register, and reset routes
-            Route::get('login', 'Auth\LoginController@showLoginForm')->name('manager.login');
-            Route::post('login', 'Auth\LoginController@login')->name('manager.login.post');
-            Route::post('logout', 'Auth\LoginController@logout')->name('manager.logout');
+            Route::get ('login', 'Auth\LoginController@showLoginForm')->name ('manager.login');
+            Route::post ('login', 'Auth\LoginController@login')->name ('manager.login.post');
+            Route::post ('logout', 'Auth\LoginController@logout')->name ('manager.logout');
 
             // Registration Routes...
-            Route::get('register', 'Auth\RegisterController@showManagerRegistrationForm')->name('manager.register');
-            Route::post('register', 'Auth\RegisterController@registerManager')->name('manager.register.post');
+            Route::get ('register', 'Auth\RegisterController@showManagerRegistrationForm')->name ('manager.register');
+            Route::post ('register', 'Auth\RegisterController@registerManager')->name ('manager.register.post');
 
             // Password Reset Routes...
-            Route::get('password/reset', 'Auth\ForgotPasswordController@showLinkRequestForm')->name('manager.password.request');
-            Route::post('password/email', 'Auth\ForgotPasswordController@sendResetLinkEmail')->name('manager.password.email');
-            Route::get('password/reset/{token}', 'Auth\ResetPasswordController@showResetForm')->name('manager.password.reset');
-            Route::post('password/reset', 'Auth\ResetPasswordController@reset')->name('manager.password.reset.post');
+            Route::get ('password/reset', 'Auth\ForgotPasswordController@showLinkRequestForm')->name ('manager.password.request');
+            Route::post ('password/email', 'Auth\ForgotPasswordController@sendResetLinkEmail')->name ('manager.password.email');
+            Route::get ('password/reset/{token}', 'Auth\ResetPasswordController@showResetForm')->name ('manager.password.reset');
+            Route::post ('password/reset', 'Auth\ResetPasswordController@reset')->name ('manager.password.reset.post');
         });
 
         /* AJAX calls =============================================================== */
 
         /* Require being logged in */
-        Route::middleware(['auth'])->group(function () : void {
+        Route::middleware (['auth'])->group (function () : void {
 
-            Route::delete('courses/{course}', 'CourseController@destroy')
-                ->middleware('can:delete,course')
-                ->name('courses.destroy');
+            Route::delete ('courses/{course}', 'CourseController@destroy')
+                ->middleware ('can:delete,course')
+                ->name ('courses.destroy');
 
-            Route::delete('degrees/{degree}', 'DegreeController@destroy')
-                ->middleware('can:delete,degree')
-                ->name('degrees.destroy');
+            Route::delete ('degrees/{degree}', 'DegreeController@destroy')
+                ->middleware ('can:delete,degree')
+                ->name ('degrees.destroy');
 
-            Route::delete('work-experiences/{workExperience}', 'WorkExperienceController@destroy')
-                ->middleware('can:delete,workExperience')
-                ->name('work_experiences.destroy');
+            Route::delete ('work-experiences/{workExperience}', 'WorkExperienceController@destroy')
+                ->middleware ('can:delete,workExperience')
+                ->name ('work_experiences.destroy');
 
-            Route::post('skill-declarations', 'SkillDeclarationController@create')
-                ->middleware('can:create,App\Models\SkillDeclaration')
-                ->name('skill_declarations.create');
+            Route::post ('skill-declarations', 'SkillDeclarationController@create')
+                ->middleware ('can:create,App\Models\SkillDeclaration')
+                ->name ('skill_declarations.create');
 
-            Route::put('skill-declarations/{skillDeclaration}', 'SkillDeclarationController@update')
-                ->middleware('can:update,skillDeclaration')
-                ->name('skill_declarations.update');
+            Route::put ('skill-declarations/{skillDeclaration}', 'SkillDeclarationController@update')
+                ->middleware ('can:update,skillDeclaration')
+                ->name ('skill_declarations.update');
 
-            Route::delete('skill-declarations/{skillDeclaration}', 'SkillDeclarationController@destroy')
-                ->middleware('can:delete,skillDeclaration')
-                ->name('skill_declarations.destroy');
+            Route::delete ('skill-declarations/{skillDeclaration}', 'SkillDeclarationController@destroy')
+                ->middleware ('can:delete,skillDeclaration')
+                ->name ('skill_declarations.destroy');
 
-            Route::post('references', 'ReferencesController@update')
-                ->middleware('can:create,App\Models\Reference')
-                ->name('references.create');
+            Route::post ('references', 'ReferencesController@update')
+                ->middleware ('can:create,App\Models\Reference')
+                ->name ('references.create');
 
-            Route::put('references/{reference}', 'ReferencesController@update')
-                ->middleware('can:update,reference')
-                ->name('references.update');
+            Route::put ('references/{reference}', 'ReferencesController@update')
+                ->middleware ('can:update,reference')
+                ->name ('references.update');
 
-            Route::delete('references/{reference}', 'ReferencesController@destroy')
-                ->middleware('can:delete,reference')
-                ->name('references.destroy');
+            Route::delete ('references/{reference}', 'ReferencesController@destroy')
+                ->middleware ('can:delete,reference')
+                ->name ('references.destroy');
 
-            Route::post('work-samples', 'WorkSamplesController@update')
-                ->middleware('can:create,App\Models\WorkSample')
-                ->name('work_samples.create');
+            Route::post ('work-samples', 'WorkSamplesController@update')
+                ->middleware ('can:create,App\Models\WorkSample')
+                ->name ('work_samples.create');
 
-            Route::put('work-samples/{workSample}', 'WorkSamplesController@update')
-                ->middleware('can:update,workSample')
-                ->name('work_samples.update');
+            Route::put ('work-samples/{workSample}', 'WorkSamplesController@update')
+                ->middleware ('can:update,workSample')
+                ->name ('work_samples.update');
 
-            Route::delete('work-samples/{workSample}', 'WorkSamplesController@destroy')
-                ->middleware('can:delete,workSample')
-                ->name('work_samples.destroy');
+            Route::delete ('work-samples/{workSample}', 'WorkSamplesController@destroy')
+                ->middleware ('can:delete,workSample')
+                ->name ('work_samples.destroy');
 
-            Route::delete('applications/{application}', 'ApplicationController@destroy')
-                ->middleware('can:delete,application')
-                ->name('applications.destroy');
+            Route::delete ('applications/{application}', 'ApplicationController@destroy')
+                ->middleware ('can:delete,application')
+                ->name ('applications.destroy');
 
-            Route::put('applications/{application}/review', 'ApplicationReviewController@updateForApplication')
-                ->middleware('can:review,application')
-                ->name('application_reviews.update');
+            Route::put ('applications/{application}/review', 'ApplicationReviewController@updateForApplication')
+                ->middleware ('can:review,application')
+                ->name ('application_reviews.update');
         });
 
 
         /* Non-Backpack Admin Portal (localized pages) =========================================================== */
-        Route::group(
+        Route::group (
             [
                 'prefix' => 'admin',
                 'middleware' => ['auth', 'role:admin']
             ],
             function (): void {
                 /* Edit Job */
-                Route::get('jobs/{jobPoster}/edit', 'JobController@edit')
-                    ->where('jobPoster', '[0-9]+')
-                    ->middleware('can:update,jobPoster')
-                    ->name('admin.jobs.edit');
-                Route::post('jobs/{jobPoster}', 'JobController@store')
-                    ->where('jobPoster', '[0-9]+')
-                    ->middleware('can:update,jobPoster')
-                    ->name('admin.jobs.update');
+                Route::get ('jobs/{jobPoster}/edit', 'JobController@edit')
+                    ->where ('jobPoster', '[0-9]+')
+                    ->middleware ('can:update,jobPoster')
+                    ->name ('admin.jobs.edit');
+                Route::post ('jobs/{jobPoster}', 'JobController@store')
+                    ->where ('jobPoster', '[0-9]+')
+                    ->middleware ('can:update,jobPoster')
+                    ->name ('admin.jobs.update');
             }
         );
     }
 );
 
 /* Non-Backpack Admin Portal (non-localized pages) =========================================================== */
-Route::group(
+Route::group (
     [
         'prefix' => 'admin',
         'middleware' => ['auth', 'role:admin']
     ],
     function (): void {
         // This page is non-localized, because the middleware that redirects to localized pages changes POSTs to GETs and messes up the request.
-        Route::post('jobs/create/as-manager/{manager}', 'JobController@createAsManager')
-            ->middleware('can:create,App\Models\JobPoster')
-            ->name('admin.jobs.create_as_manager');
+        Route::post ('jobs/create/as-manager/{manager}', 'JobController@createAsManager')
+            ->middleware ('can:create,App\Models\JobPoster')
+            ->name ('admin.jobs.create_as_manager');
     }
 );
 
@@ -449,65 +449,65 @@ 
 
 
 /** API routes - currently using same default http auth, but not localized */
-Route::group(['prefix' => 'api'], function (): void {
+Route::group (['prefix' => 'api'], function (): void {
     // Protected by a gate in the controller, instead of policy middleware
-    Route::get('jobs/{jobPoster}/assessment-plan', 'AssessmentPlanController@getForJob');
+    Route::get ('jobs/{jobPoster}/assessment-plan', 'AssessmentPlanController@getForJob');
     // Public, not protected by policy or gate
-    Route::get('skills', 'Api\SkillController@index');
-    Route::get('departments', 'Api\DepartmentController@index');
+    Route::get ('skills', 'Api\SkillController@index');
+    Route::get ('departments', 'Api\DepartmentController@index');
 
     // Resource Routes are protected by policies in controllers instead of middleware.
-    Route::resource('assessments', 'AssessmentController')->except([
+    Route::resource ('assessments', 'AssessmentController')->except ([
         'create', 'edit', 'index'
     ]);
-    Route::apiResource('rating-guide-answers', 'RatingGuideAnswerController')->except([
+    Route::apiResource ('rating-guide-answers', 'RatingGuideAnswerController')->except ([
         'index'
-    ])->parameters([
+    ])->parameters ([
         'rating-guide-answers' => 'ratingGuideAnswer'
     ]);
-    Route::resource('rating-guide-questions', 'RatingGuideQuestionController')->except([
+    Route::resource ('rating-guide-questions', 'RatingGuideQuestionController')->except ([
         'create', 'edit', 'index'
     ]);
-    Route::resource('assessment-plan-notifications', 'AssessmentPlanNotificationController')->except([
+    Route::resource ('assessment-plan-notifications', 'AssessmentPlanNotificationController')->except ([
         'store', 'create', 'edit'
     ]);
     // TODO: add policy middleware
-    Route::get('jobs/{jobPoster}/tasks', 'Api\JobTaskController@indexByJob')
-        ->where('jobPoster', '[0-9]+')
-        ->middleware('can:view,jobPoster');
-    Route::put('jobs/{jobPoster}/tasks', 'Api\JobTaskController@batchUpdate')
-        ->where('jobPoster', '[0-9]+')
-        ->middleware('can:update,jobPoster');
-
-
-     Route::get('jobs/{jobPoster}/criteria', 'Api\CriteriaController@indexByJob')
-        ->where('jobPoster', '[0-9]+')
-        ->middleware('can:view,jobPoster');
-    Route::put('jobs/{jobPoster}/criteria', 'Api\CriteriaController@batchUpdate')
-        ->where('jobPoster', '[0-9]+')
-        ->middleware('can:update,jobPoster');
-
-
-    Route::post('jobs/{job}/submit', 'Api\JobApiController@submitForReview')
-        ->where('job', '[0-9]+')
-        ->middleware('can:submitForReview,job')
-        ->name('api.jobs.submit');
-    Route::resource('jobs', 'Api\JobApiController')->only([
+    Route::get ('jobs/{jobPoster}/tasks', 'Api\JobTaskController@indexByJob')
+        ->where ('jobPoster', '[0-9]+')
+        ->middleware ('can:view,jobPoster');
+    Route::put ('jobs/{jobPoster}/tasks', 'Api\JobTaskController@batchUpdate')
+        ->where ('jobPoster', '[0-9]+')
+        ->middleware ('can:update,jobPoster');
+
+
+     Route::get ('jobs/{jobPoster}/criteria', 'Api\CriteriaController@indexByJob')
+        ->where ('jobPoster', '[0-9]+')
+        ->middleware ('can:view,jobPoster');
+    Route::put ('jobs/{jobPoster}/criteria', 'Api\CriteriaController@batchUpdate')
+        ->where ('jobPoster', '[0-9]+')
+        ->middleware ('can:update,jobPoster');
+
+
+    Route::post ('jobs/{job}/submit', 'Api\JobApiController@submitForReview')
+        ->where ('job', '[0-9]+')
+        ->middleware ('can:submitForReview,job')
+        ->name ('api.jobs.submit');
+    Route::resource ('jobs', 'Api\JobApiController')->only ([
         'show', 'store', 'update'
-    ])->names([ // Specify custom names because default names collied with existing routes.
+    ])->names ([// Specify custom names because default names collied with existing routes.
         'show' => 'api.jobs.show',
         'store' => 'api.jobs.store',
         'update' => 'api.jobs.update'
     ]);
 
-    Route::resource('managers', 'Api\ManagerApiController')->only([
+    Route::resource ('managers', 'Api\ManagerApiController')->only ([
         'show', 'update'
-    ])->names([ // Specify custom names because default names collied with existing routes
+    ])->names ([// Specify custom names because default names collied with existing routes
         'show' => 'api.managers.show',
         'update' => 'api.managers.update'
     ]);
 
     // User must be logged in to user currentuser routes
-    Route::get('currentuser/manager', 'Api\ManagerApiController@showAuthenticated')
-        ->middleware('auth');
+    Route::get ('currentuser/manager', 'Api\ManagerApiController@showAuthenticated')
+        ->middleware ('auth');
 });

app/Http/Controllers/Api/CriteriaController.php

Indentation +5 added lines, -5 removed lines

@@ -12,11 +12,11 @@
 class CriteriaController extends Controller
 {
 /**
-     * Converts a Criteria to the shape sent and recieved by the api.
-     *
-     * @param Criteria $model
-     * @return void
-     */
+ * Converts a Criteria to the shape sent and recieved by the api.
+ *
+ * @param Criteria $model
+ * @return void
+ */
     public function toApiArray(Criteria $model)
     {
         return array_merge($model->toArray(), $model->getTranslationsArray());

Spacing +29 added lines, -29 removed lines

@@ -19,7 +19,7 @@ 
      */
     public function toApiArray(Criteria $model)
     {
-        return array_merge($model->toArray(), $model->getTranslationsArray());
+        return array_merge ($model->toArray (), $model->getTranslationsArray ());
     }
 
     /**
@@ -31,8 +31,8 @@ 
     public function indexByJob(JobPoster $jobPoster)
     {
         $toApiArray = array($this, 'toApiArray');
-        $criteriaAray = Criteria::where('job_poster_id', $jobPoster->id)->get()->map($toApiArray);
-        return response()->json($criteriaAray);
+        $criteriaAray = Criteria::where ('job_poster_id', $jobPoster->id)->get ()->map ($toApiArray);
+        return response ()->json ($criteriaAray);
     }
 
     /**
@@ -46,39 +46,39 @@ 
     {
         $toApiArray = array($this, 'toApiArray');
 
-        $newCriteria = collect($request->input()); // TODO: switch to validated
+        $newCriteria = collect ($request->input ()); // TODO: switch to validated
         $oldCriteria = $jobPoster->criteria;
 
         $updatedIds = [];
 
         // First, delete old criteria that weren't resubmitted, and update those that were
         foreach ($oldCriteria as $criteria) {
-            $newData = $newCriteria->firstWhere('id', $criteria['id']);
+            $newData = $newCriteria->firstWhere ('id', $criteria['id']);
             if ($newData) {
                 $updatedIds[] = $criteria->id;
-                $this->updateCriteria($criteria, $newData);
+                $this->updateCriteria ($criteria, $newData);
             } else {
-                $this->deleteCriteria($criteria);
+                $this->deleteCriteria ($criteria);
             }
         }
 
         $isUnsaved = function ($criteria, $savedIds): bool {
-            return !array_key_exists('id', $criteria) || !in_array($criteria['id'], $savedIds);
+            return !array_key_exists ('id', $criteria) || !in_array ($criteria['id'], $savedIds);
         };
 
         // Now, save any new criteria that remain
         foreach ($newCriteria as $criteriaData) {
-            if ($isUnsaved($criteriaData, $updatedIds)) {
-                $criteria = new Criteria();
+            if ($isUnsaved ($criteriaData, $updatedIds)) {
+                $criteria = new Criteria ();
                 $criteria->job_poster_id = $jobPoster->id;
-                $fillableData = collect($criteriaData)->except(['id', 'job_poster_id'])->toArray();
-                $criteria->fill($fillableData);
-                $this->createCriteria($criteria);
+                $fillableData = collect ($criteriaData)->except (['id', 'job_poster_id'])->toArray ();
+                $criteria->fill ($fillableData);
+                $this->createCriteria ($criteria);
             }
         }
 
-        $criteriaAray = Criteria::where('job_poster_id', $jobPoster->id)->get()->map($toApiArray);
-        return response()->json($criteriaAray);
+        $criteriaAray = Criteria::where ('job_poster_id', $jobPoster->id)->get ()->map ($toApiArray);
+        return response ()->json ($criteriaAray);
     }
 
     /**
@@ -89,13 +89,13 @@ 
      */
     protected function createCriteria(Criteria $criteria)
     {
-        $criteria->save();
+        $criteria->save ();
 
-        $notification = $this->makeAssessmentPlanNotification(
+        $notification = $this->makeAssessmentPlanNotification (
             'CREATE',
             $criteria
         );
-        $notification->save();
+        $notification->save ();
 
         return $criteria;
     }
@@ -113,19 +113,19 @@ 
         if ($oldCriteria->skill_level_id != $newData['skill_level_id']
             || $oldCriteria->skill_id != $newData['skill_id']
         ) {
-            $notification = $this->makeAssessmentPlanNotification(
+            $notification = $this->makeAssessmentPlanNotification (
                 'UPDATE',
                 $oldCriteria,
                 $newData['skill_id'],
                 $newData['skill_level_id'],
                 $newData['criteria_type_id']
             );
-            $notification->save();
+            $notification->save ();
         }
         // Get just the data that can be changed
-        $fillableData = collect($newData)->except(['id', 'job_poster_id'])->toArray();
-        $oldCriteria->fill($fillableData);
-        $oldCriteria->save();
+        $fillableData = collect ($newData)->except (['id', 'job_poster_id'])->toArray ();
+        $oldCriteria->fill ($fillableData);
+        $oldCriteria->save ();
     }
 
     /**
@@ -136,15 +136,15 @@ 
      */
     protected function deleteCriteria(Criteria $criteria): void
     {
-        $notification = $notification = $this->makeAssessmentPlanNotification(
+        $notification = $notification = $this->makeAssessmentPlanNotification (
             'DELETE',
             $criteria
         );
-        $notification->save();
+        $notification->save ();
 
         // Delete assessments related to this criteria.
-        Assessment::where('criterion_id', $criteria->id)->delete();
-        $criteria->delete();
+        Assessment::where ('criterion_id', $criteria->id)->delete ();
+        $criteria->delete ();
     }
 
     /**
@@ -163,8 +163,8 @@ 
         $newSkillId = null,
         $newSkillLevelId = null,
         $newCriteriaTypeId = null
-    ) {
-        $notification = new AssessmentPlanNotification();
+    ){
+        $notification = new AssessmentPlanNotification ();
         $notification->job_poster_id = $criteria->job_poster_id;
         $notification->type = $type;
         $notification->criteria_id = $criteria->id;

routes/backpack/custom.php

Spacing +9 added lines, -9 removed lines

@@ -5,16 +5,16 @@
 // --------------------------
 // This route file is loaded automatically by Backpack\Base.
 // Routes you generate using Backpack\Generators will be placed here.
-Route::group([
-    'prefix' => config('backpack.base.route_prefix', 'admin'),
-    'middleware' => ['web', config('backpack.base.middleware_key', 'admin')],
+Route::group ([
+    'prefix' => config ('backpack.base.route_prefix', 'admin'),
+    'middleware' => ['web', config ('backpack.base.middleware_key', 'admin')],
     'namespace' => 'App\Http\Controllers\Admin',
 ], function () : void {
     // Custom admin routes.
-    Route::crud('skill', 'SkillCrudController');
-    Route::crud('job-poster', 'JobPosterCrudController');
-    Route::crud('user', 'UserCrudController');
-    Route::crud('manager', 'ManagerCrudController');
-    Route::crud('department', 'DepartmentCrudController');
-    Route::crud('classification', 'ClassificationCrudController');
+    Route::crud ('skill', 'SkillCrudController');
+    Route::crud ('job-poster', 'JobPosterCrudController');
+    Route::crud ('user', 'UserCrudController');
+    Route::crud ('manager', 'ManagerCrudController');
+    Route::crud ('department', 'DepartmentCrudController');
+    Route::crud ('classification', 'ClassificationCrudController');
 });

app/Notifications/ResetPasswordNotification.php

Spacing +6 added lines, -6 removed lines

@@ -57,11 +57,11 @@
     public function toMail($notifiable)
     {
         return (new MailMessage)
-            ->subject(Lang::get('common/notifications/password_reset.subject'))
-            ->greeting(Lang::get('common/notifications/password_reset.greeting'))
-            ->line(Lang::get('common/notifications/password_reset.line_1'))
-            ->action(Lang::get('common/notifications/password_reset.action'), url(route('password.reset', $this->token, false)))
-            ->line(Lang::get('common/notifications/password_reset.line_2'))
-            ->salutation(Lang::get('common/notifications/password_reset.salutation', ['name' => config('mail.from.name')]));
+            ->subject (Lang::get ('common/notifications/password_reset.subject'))
+            ->greeting (Lang::get ('common/notifications/password_reset.greeting'))
+            ->line (Lang::get ('common/notifications/password_reset.line_1'))
+            ->action (Lang::get ('common/notifications/password_reset.action'), url (route ('password.reset', $this->token, false)))
+            ->line (Lang::get ('common/notifications/password_reset.line_2'))
+            ->salutation (Lang::get ('common/notifications/password_reset.salutation', ['name' => config ('mail.from.name')]));
     }
 }