GCTC-NTGC / TalentCloud

app/Models/ProfilePic.php

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
  *
  * @property \App\Models\User $user
  */
-class ProfilePic extends BaseModel {
+class ProfilePic extends BaseModel{
 
     protected $casts = [
         'user_id' => 'int',
@@ -31,8 +31,8 @@ 
         'image'
     ];
 
-    public function user() {
-        return $this->belongsTo(\App\Models\User::class);
+    public function user(){
+        return $this->belongsTo (\App\Models\User::class);
     }
 
 }

app/Models/BaseModel.php

Spacing +14 added lines, -14 removed lines

@@ -9,7 +9,7 @@ 
 use Jenssegers\Date\Date;
 use DateTime;
 
-abstract class BaseModel extends Eloquent {
+abstract class BaseModel extends Eloquent{
     //Override date functions to return Jenssegers Data instead of Carbon
 
     /**
@@ -30,13 +30,13 @@ 
      */
     protected function asDateTime($value)
     {
-        $timezone = Config::get('app.timezone');
+        $timezone = Config::get ('app.timezone');
 
         // If this value is already a Carbon instance, we shall just return it as is.
         // This prevents us having to re-instantiate a Carbon instance when we know
         // it already is one, which wouldn't be fulfilled by the DateTime check.
         if ($value instanceof Carbon) {
-            return Date::parse($value, $timezone);
+            return Date::parse ($value, $timezone);
         }
         if ($value instanceof Date) {
             return $value;
@@ -45,35 +45,35 @@ 
         // these checks since they will be a waste of time, and hinder performance
         // when checking the field. We will just return the DateTime right away.
         if ($value instanceof DateTimeInterface) {
-            return new Date(
+            return new Date (
                 //$value->format('Y-m-d H:i:s.u'), $value->getTimeZone()
-                $value->format('Y-m-d H:i:s.u'), $timezone
+                $value->format ('Y-m-d H:i:s.u'), $timezone
             );
         }
         // If this value is an integer, we will assume it is a UNIX timestamp's value
         // and format a Carbon object from this timestamp. This allows flexibility
         // when defining your date fields as they might be UNIX timestamps here.
-        if (is_numeric($value)) {
-            return Date::createFromTimestamp($value, $timezone);
+        if (is_numeric ($value)) {
+            return Date::createFromTimestamp ($value, $timezone);
         }
         // If the value is in simply year, month, day format, we will instantiate the
         // Carbon instances from that format. Again, this provides for simple date
         // fields on the database, while still supporting Carbonized conversion.
-        if (preg_match('/^(\d{4})-(\d{1,2})-(\d{1,2})$/', $value)) {
-            return Date::createFromFormat('Y-m-d', $value, $timezone)->startOfDay();
+        if (preg_match ('/^(\d{4})-(\d{1,2})-(\d{1,2})$/', $value)) {
+            return Date::createFromFormat ('Y-m-d', $value, $timezone)->startOfDay ();
         }
 
         // If the date follows the api configured date format, use that.
-        $apiFormat = Config::get('app.api_datetime_format');
-        $date = DateTime::createFromFormat($apiFormat, $value);
-        if ($date && $date->format($apiFormat) == $value) {
+        $apiFormat = Config::get ('app.api_datetime_format');
+        $date = DateTime::createFromFormat ($apiFormat, $value);
+        if ($date && $date->format ($apiFormat) == $value) {
             return $date;
         }
 
         // Finally, we will just assume this date is in the format used by default on
         // the database connection and use that format to create the Carbon object
         // that is returned back out to the developers after we convert it here.
-        return Date::createFromFormat($this->getDateFormat(), $value, $timezone);
+        return Date::createFromFormat ($this->getDateFormat (), $value, $timezone);
     }
 
     /**
@@ -84,6 +84,6 @@ 
      */
     protected function serializeDate(DateTimeInterface $date)
     {
-        return $date->format(Config::get('app.api_datetime_format'));
+        return $date->format (Config::get ('app.api_datetime_format'));
     }
 }

app/Models/JobApplication.php

Spacing +41 added lines, -41 removed lines

@@ -46,7 +46,7 @@ 
  * @property \Illuminate\Database\Eloquent\Collection $skill_declarations
  * @property \App\Models\ApplicationReview $application_review
  */
-class JobApplication extends BaseModel {
+class JobApplication extends BaseModel{
 
     use Notifiable;
 
@@ -85,52 +85,52 @@ 
      */
     protected $appends = ['meets_essential_criteria'];
 
-    protected function createApplicantSnapshot($applicant_id) {
-        $applicant = Applicant::where('id', $applicant_id)->firstOrFail();
+    protected function createApplicantSnapshot($applicant_id){
+        $applicant = Applicant::where ('id', $applicant_id)->firstOrFail ();
 
-        $snapshot = $applicant->replicate();
+        $snapshot = $applicant->replicate ();
 
     }
 
-    public function applicant() {
-        return $this->belongsTo(\App\Models\Applicant::class);
+    public function applicant(){
+        return $this->belongsTo (\App\Models\Applicant::class);
     }
 
-    public function applicant_snapshot() {
-        return $this->belongsTo(\App\Models\Applicant::class, 'applicant_snapshot_id');
+    public function applicant_snapshot(){
+        return $this->belongsTo (\App\Models\Applicant::class, 'applicant_snapshot_id');
     }
 
-    public function application_status() {
-        return $this->belongsTo(\App\Models\Lookup\ApplicationStatus::class);
+    public function application_status(){
+        return $this->belongsTo (\App\Models\Lookup\ApplicationStatus::class);
     }
 
-    public function citizenship_declaration() {
-        return $this->belongsTo(\App\Models\Lookup\CitizenshipDeclaration::class);
+    public function citizenship_declaration(){
+        return $this->belongsTo (\App\Models\Lookup\CitizenshipDeclaration::class);
     }
 
-    public function veteran_status() {
-        return $this->belongsTo(\App\Models\Lookup\VeteranStatus::class);
+    public function veteran_status(){
+        return $this->belongsTo (\App\Models\Lookup\VeteranStatus::class);
     }
 
-    public function preferred_language() {
-        return $this->belongsTo(\App\Models\Lookup\PreferredLanguage::class);
+    public function preferred_language(){
+        return $this->belongsTo (\App\Models\Lookup\PreferredLanguage::class);
     }
 
-    public function job_poster() {
-        return $this->belongsTo(\App\Models\JobPoster::class);
+    public function job_poster(){
+        return $this->belongsTo (\App\Models\JobPoster::class);
     }
 
-    public function job_application_answers() {
-        return $this->hasMany(\App\Models\JobApplicationAnswer::class);
+    public function job_application_answers(){
+        return $this->hasMany (\App\Models\JobApplicationAnswer::class);
     }
 
-    public function skill_declarations() {
-        return $this->applicant->skill_declarations()
-            ->whereIn('skill_id', $this->job_poster->criteria->pluck('skill_id'));
+    public function skill_declarations(){
+        return $this->applicant->skill_declarations ()
+            ->whereIn ('skill_id', $this->job_poster->criteria->pluck ('skill_id'));
     }
 
-    public function application_review() {
-        return $this->hasOne(ApplicationReview::class);
+    public function application_review(){
+        return $this->hasOne (ApplicationReview::class);
     }
 
     /**
@@ -146,41 +146,41 @@ 
      *
      * @return string $status   'complete', 'incomplete' or 'error'
      */
-    public function getSectionStatus(string $section) {
+    public function getSectionStatus(string $section){
         //TODO: determine whether sections are complete or invalid
-        $validator = new ApplicationValidator();
+        $validator = new ApplicationValidator ();
         $status = 'incomplete';
-        switch($section) {
+        switch ($section) {
             case 'basics':
-                if ($validator->basicsComplete($this)) {
+                if ($validator->basicsComplete ($this)) {
                     $status = 'complete';
                 }
                 break;
             case 'experience':
-                if ($validator->experienceComplete($this)) {
+                if ($validator->experienceComplete ($this)) {
                     $status = 'complete';
                 }
                 break;
             case 'essential_skills':
-                if ($validator->essentialSkillsComplete($this)) {
+                if ($validator->essentialSkillsComplete ($this)) {
                     $status = 'complete';
                 }
                 break;
             case 'asset_skills':
-                if ($validator->assetSkillsComplete($this)) {
+                if ($validator->assetSkillsComplete ($this)) {
                     $status = 'complete';
                 }
                 break;
             case 'preview':
-                if ($validator->basicsComplete($this) &&
-                    $validator->experienceComplete($this) &&
-                    $validator->essentialSkillsComplete($this) &&
-                    $validator->assetSkillsComplete($this)) {
+                if ($validator->basicsComplete ($this) &&
+                    $validator->experienceComplete ($this) &&
+                    $validator->essentialSkillsComplete ($this) &&
+                    $validator->assetSkillsComplete ($this)) {
                     $status = 'complete';
                 }
                 break;
             case 'confirm':
-                if ($validator->affirmationComplete($this)) {
+                if ($validator->affirmationComplete ($this)) {
                     $status = 'complete';
                 }
                 break;
@@ -200,13 +200,13 @@ 
      */
     public function meetsEssentialCriteria(): bool
     {
-        $essentialCriteria = $this->job_poster->criteria->filter(
-            function ($value, $key) {
+        $essentialCriteria = $this->job_poster->criteria->filter (
+            function ($value, $key){
                 return $value->criteria_type->name == 'essential';
             }
         );
         foreach ($essentialCriteria as $criterion) {
-            $skillDeclaration = $this->skill_declarations->where("skill_id", $criterion->skill_id)->first();
+            $skillDeclaration = $this->skill_declarations->where ("skill_id", $criterion->skill_id)->first ();
             if ($skillDeclaration === null ||
                 $skillDeclaration->skill_level_id < $criterion->skill_level_id) {
                 return false;
@@ -223,6 +223,6 @@ 
      */
     public function getMeetsEssentialCriteriaAttribute():bool
     {
-        return $this->meetsEssentialCriteria();
+        return $this->meetsEssentialCriteria ();
     }
 }

app/Models/ApplicantProfileAnswer.php

Spacing +5 added lines, -5 removed lines

@@ -20,7 +20,7 @@ 
  * @property \App\Models\Applicant $applicant
  * @property \App\Models\Lookup\ApplicantProfileQuestion $applicant_profile_question
  */
-class ApplicantProfileAnswer extends BaseModel {
+class ApplicantProfileAnswer extends BaseModel{
 
     protected $casts = [
         'applicant_id' => 'int',
@@ -34,12 +34,12 @@ 
         'applicant_profile_question'
     ];
 
-    public function applicant() {
-        return $this->belongsTo(\App\Models\Applicant::class);
+    public function applicant(){
+        return $this->belongsTo (\App\Models\Applicant::class);
     }
 
-    public function applicant_profile_question() {
-        return $this->belongsTo(\App\Models\Lookup\ApplicantProfileQuestion::class);
+    public function applicant_profile_question(){
+        return $this->belongsTo (\App\Models\Lookup\ApplicantProfileQuestion::class);
     }
 
 }

app/Models/JobApplicationAnswer.php

Spacing +5 added lines, -5 removed lines

@@ -20,7 +20,7 @@ 
  * @property \App\Models\JobApplication $job_application
  * @property \App\Models\JobPosterQuestion $job_poster_question
  */
-class JobApplicationAnswer extends BaseModel {
+class JobApplicationAnswer extends BaseModel{
 
     protected $casts = [
         'job_poster_questions_id' => 'int',
@@ -30,12 +30,12 @@ 
         'answer'
     ];
 
-    public function job_application() {
-        return $this->belongsTo(\App\Models\JobApplication::class);
+    public function job_application(){
+        return $this->belongsTo (\App\Models\JobApplication::class);
     }
 
-    public function job_poster_question() {
-        return $this->belongsTo(\App\Models\JobPosterQuestion::class);
+    public function job_poster_question(){
+        return $this->belongsTo (\App\Models\JobPosterQuestion::class);
     }
 
 }

app/Models/WorkplacePhotoCaption.php

Spacing +5 added lines, -5 removed lines

@@ -21,7 +21,7 @@ 
  * @property \App\Models\WorkEnvironment $work_environment
  * @property \App\Models\WorkplacePhoto $workplace_photo
  */
-class WorkplacePhotoCaption extends BaseModel {
+class WorkplacePhotoCaption extends BaseModel{
 
     protected $casts = [
         'work_environment_id' => 'int',
@@ -32,12 +32,12 @@ 
         'description'
     ];
 
-    public function work_environment() {
-        return $this->belongsTo(\App\Models\WorkEnvironment::class);
+    public function work_environment(){
+        return $this->belongsTo (\App\Models\WorkEnvironment::class);
     }
 
-    public function workplace_photo() {
-        return $this->belongsTo(\App\Models\WorkplacePhoto::class);
+    public function workplace_photo(){
+        return $this->belongsTo (\App\Models\WorkplacePhoto::class);
     }
 
 }

app/Services/Validation/ApplicationValidator.php

Spacing +64 added lines, -64 removed lines

@@ -13,19 +13,19 @@ 
 use App\Services\Validation\Rules\ContainsObjectWithAttributeRule;
 use App\Services\Validation\JobApplicationAnswerValidator;
 
-class ApplicationValidator {
+class ApplicationValidator{
 
     protected $citizenship_ids;
     protected $veteran_status_ids;
     protected $preferred_language_ids;
 
-    public function __construct() {
-        $this->citizenship_ids = CitizenshipDeclaration::all()->pluck('id')->toArray();
-        $this->veteran_status_ids = VeteranStatus::all()->pluck('id')->toArray();
-        $this->preferred_language_ids = PreferredLanguage::all()->pluck('id')->toArray();
+    public function __construct(){
+        $this->citizenship_ids = CitizenshipDeclaration::all ()->pluck ('id')->toArray ();
+        $this->veteran_status_ids = VeteranStatus::all ()->pluck ('id')->toArray ();
+        $this->preferred_language_ids = PreferredLanguage::all ()->pluck ('id')->toArray ();
     }
 
-    public function validate(JobApplication $application) {
+    public function validate(JobApplication $application){
 
         $backendRules = [
             'job_poster_id' => 'required',
@@ -33,30 +33,30 @@ 
             'applicant_id' => 'required'
         ];
 
-        $rules = array_merge(
+        $rules = array_merge (
             $backendRules,
             //$this->basicsValidator($application)->getRules(),
-            $this->experienceValidator($application)->getRules(),
+            $this->experienceValidator ($application)->getRules (),
             //$this->essentialSkillsValidator($application)->getRules(),
-            $this->affirmationValidator($application)->getRules()
+            $this->affirmationValidator ($application)->getRules ()
         );
 
-        $data = $application->toArray();
+        $data = $application->toArray ();
 
         // Combining and simplifiying error messages
-        $rules = array_merge(
+        $rules = array_merge (
             $rules,
             ['application_step_1' => 'required|boolean|accepted'],
             ['application_step_3' => 'required|boolean|accepted']
         );
-        $data = array_merge(
+        $data = array_merge (
             $data,
-            ['application_step_1' => $this->basicsComplete($application)],
-            ['application_step_3' => $this->essentialSkillsComplete($application)]
+            ['application_step_1' => $this->basicsComplete ($application)],
+            ['application_step_3' => $this->essentialSkillsComplete ($application)]
         );
 
         //Validate basic data is filled in
-        Validator::make($data, $rules)->validate();
+        Validator::make ($data, $rules)->validate ();
     }
 
     /**
@@ -70,110 +70,110 @@ 
     {
         $newArray = [];
         foreach ($array as $key => $value) {
-            $newArray[$fn($key)] = $value;
+            $newArray[$fn ($key)] = $value;
         }
         return $newArray;
     }
 
-    protected function addNestedValidatorRules($nestedAttribute, $validatorRules, $rules = []) {
+    protected function addNestedValidatorRules($nestedAttribute, $validatorRules, $rules = []){
         // prepend the attribute name of each validator rule with the nested attribute name
-        $newRules = $this->arrayMapKeys(function($key) use ($nestedAttribute) {
-                return implode('.', [$nestedAttribute, $key]);
+        $newRules = $this->arrayMapKeys (function ($key) use ($nestedAttribute) {
+                return implode ('.', [$nestedAttribute, $key]);
             },
             $validatorRules);
         //Merge new rules with old rules
-        $rules = array_merge($rules, $newRules);
+        $rules = array_merge ($rules, $newRules);
         return $rules;
     }
 
-    public function basicsValidator(JobApplication $application) {
+    public function basicsValidator(JobApplication $application){
         // Validate the fields common to every application
         $rules = [
             'language_requirement_confirmed' => ['required', 'boolean'],
-            'citizenship_declaration_id' => ['required', Rule::in($this->citizenship_ids)],
-            'veteran_status_id' => ['required', Rule::in($this->veteran_status_ids)],
-            'preferred_language_id' => ['required', Rule::in($this->preferred_language_ids)],
+            'citizenship_declaration_id' => ['required', Rule::in ($this->citizenship_ids)],
+            'veteran_status_id' => ['required', Rule::in ($this->veteran_status_ids)],
+            'preferred_language_id' => ['required', Rule::in ($this->preferred_language_ids)],
         ];
 
         //Load application answers so they are included in application->toArray()
-        $application->load('job_application_answers');
+        $application->load ('job_application_answers');
 
         // Validate that each question has been answered
         $jobPosterQuestionRules = [];
-        foreach($application->job_poster->job_poster_questions as $question) {
-            $jobPosterQuestionRules[] = new ContainsObjectWithAttributeRule('job_poster_question_id', $question->id);
+        foreach ($application->job_poster->job_poster_questions as $question) {
+            $jobPosterQuestionRules[] = new ContainsObjectWithAttributeRule ('job_poster_question_id', $question->id);
         }
         $rules['job_application_answers'] = $jobPosterQuestionRules;
-        $answerValidatorFactory = new JobApplicationAnswerValidator($application);
+        $answerValidatorFactory = new JobApplicationAnswerValidator ($application);
 
         //Validate that each answer is complete
-        foreach($application->job_application_answers as $key=>$answer) {
-            $attribute = implode('.', ['job_application_answers', $key]);
-            $rules = $this->addNestedValidatorRules($attribute, $answerValidatorFactory->rules(), $rules);
+        foreach ($application->job_application_answers as $key=>$answer) {
+            $attribute = implode ('.', ['job_application_answers', $key]);
+            $rules = $this->addNestedValidatorRules ($attribute, $answerValidatorFactory->rules (), $rules);
         }
 
-        $validator = Validator::make($application->toArray(), $rules);
+        $validator = Validator::make ($application->toArray (), $rules);
         return $validator;
     }
 
-    public function basicsComplete(JobApplication $application) {
-        $validator = $this->basicsValidator($application);
-        return $validator->passes();
+    public function basicsComplete(JobApplication $application){
+        $validator = $this->basicsValidator ($application);
+        return $validator->passes ();
     }
 
-    public function experienceValidator(JobApplication $application) {
+    public function experienceValidator(JobApplication $application){
         $rules = ['experience_saved' => 'required|boolean|accepted'];
-        return Validator::make($application->toArray(), $rules);
+        return Validator::make ($application->toArray (), $rules);
     }
 
-    public function experienceComplete(JobApplication $application) {
-        return $this->experienceValidator($application)->passes();
+    public function experienceComplete(JobApplication $application){
+        return $this->experienceValidator ($application)->passes ();
     }
 
-    protected function skillsValidator(JobApplication $application, $criteria_type) {
+    protected function skillsValidator(JobApplication $application, $criteria_type){
         $rules = [];
 
         $skillDeclarationRules = [];
-        $criteriaTypeId = CriteriaType::where('name', $criteria_type)->firstOrFail()->id;
-        foreach($application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId) as $criteria) {
+        $criteriaTypeId = CriteriaType::where ('name', $criteria_type)->firstOrFail ()->id;
+        foreach ($application->job_poster->criteria->where ('criteria_type_id', $criteriaTypeId) as $criteria) {
             //Validate that every essential skill has a corresponding declaration
-            $skillDeclarationRules[] = new ContainsObjectWithAttributeRule('skill_id', $criteria->skill_id);
+            $skillDeclarationRules[] = new ContainsObjectWithAttributeRule ('skill_id', $criteria->skill_id);
         }
         $rules['skill_declarations'] = $skillDeclarationRules;
-        $application->applicant->load('skill_declarations');
+        $application->applicant->load ('skill_declarations');
 
         //Validate that those declarations are complete
-        $skilDeclarationValidatorFactory = new SkillDeclarationValidator($application->applicant);
-        $relevantSkillIds = $application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId)->pluck('skill_id');
-        foreach( $application->skill_declarations as $key=>$declaration) {
-            if ($relevantSkillIds->contains($declaration->skill_id)) {
-                $attribute = implode('.', ['skill_declarations', $key]);
-                $skillDeclarationValidator = $skilDeclarationValidatorFactory->validator($declaration);
-                $rules = $this->addNestedValidatorRules($attribute, $skillDeclarationValidator->getRules(), $rules);
+        $skilDeclarationValidatorFactory = new SkillDeclarationValidator ($application->applicant);
+        $relevantSkillIds = $application->job_poster->criteria->where ('criteria_type_id', $criteriaTypeId)->pluck ('skill_id');
+        foreach ($application->skill_declarations as $key=>$declaration) {
+            if ($relevantSkillIds->contains ($declaration->skill_id)) {
+                $attribute = implode ('.', ['skill_declarations', $key]);
+                $skillDeclarationValidator = $skilDeclarationValidatorFactory->validator ($declaration);
+                $rules = $this->addNestedValidatorRules ($attribute, $skillDeclarationValidator->getRules (), $rules);
             }
         }
 
-        $validator = Validator::make($application->toArray(), $rules);
+        $validator = Validator::make ($application->toArray (), $rules);
         return $validator;
     }
 
-    public function essentialSkillsValidator(JobApplication $application) {
-        return $this->skillsValidator($application, 'essential');
+    public function essentialSkillsValidator(JobApplication $application){
+        return $this->skillsValidator ($application, 'essential');
     }
 
-    public function essentialSkillsComplete(JobApplication $application) {
-        return $this->essentialSkillsValidator($application)->passes();
+    public function essentialSkillsComplete(JobApplication $application){
+        return $this->essentialSkillsValidator ($application)->passes ();
     }
 
-    public function assetSkillsValidator(JobApplication $application) {
-        return $this->skillsValidator($application, 'asset');
+    public function assetSkillsValidator(JobApplication $application){
+        return $this->skillsValidator ($application, 'asset');
     }
 
-    public function assetSkillsComplete(JobApplication $application) {
-        return $this->assetSkillsValidator($application)->passes();
+    public function assetSkillsComplete(JobApplication $application){
+        return $this->assetSkillsValidator ($application)->passes ();
     }
 
-    public function affirmationValidator(JobApplication $application) {
+    public function affirmationValidator(JobApplication $application){
         $rules = [
             'submission_signature' => [
                 'required',
@@ -186,10 +186,10 @@ 
                 'max:191',
             ]
         ];
-        return Validator::make($application->toArray(), $rules);
+        return Validator::make ($application->toArray (), $rules);
     }
 
-    public function affirmationComplete(JobApplication $application) {
-        return $this->affirmationValidator($application)->passes();
+    public function affirmationComplete(JobApplication $application){
+        return $this->affirmationValidator ($application)->passes ();
     }
 }

app/Services/Validation/JobApplicationAnswerValidator.php

Spacing +12 added lines, -12 removed lines

@@ -7,42 +7,42 @@
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;
 
-class JobApplicationAnswerValidator {
+class JobApplicationAnswerValidator{
 
     protected $application;
     protected $questionIds;
 
-    public function __construct(JobApplication $application) {
+    public function __construct(JobApplication $application){
         $this->application = $application;
-        $this->questionIds = $application->job_poster->job_poster_questions->pluck('id')->toArray();
+        $this->questionIds = $application->job_poster->job_poster_questions->pluck ('id')->toArray ();
     }
 
-    public function rules() {
+    public function rules(){
         $rules = [
             'answer' => 'required|string',
             'job_poster_question_id' => [
                 'required',
-                Rule::in($this->questionIds),
+                Rule::in ($this->questionIds),
             ],
             'job_application_id' => [
                 'required',
-                Rule::in([$this->application->id]),
+                Rule::in ([$this->application->id]),
             ]
         ];
         return $rules;
     }
 
-    public function validator(JobApplicationAnswer $answer) {
+    public function validator(JobApplicationAnswer $answer){
 
 
-        return Validator::make($answer->toArray(), $this->rules());
+        return Validator::make ($answer->toArray (), $this->rules ());
     }
 
-    public function validate(JobApplicationAnswer $answer) {
-        return $this->validator($answer)->validate();
+    public function validate(JobApplicationAnswer $answer){
+        return $this->validator ($answer)->validate ();
     }
 
-    public function isComplete(JobApplicationAnswer $answer) {
-        return $this->validator($answer)->passes();
+    public function isComplete(JobApplicationAnswer $answer){
+        return $this->validator ($answer)->passes ();
     }
 }

app/Services/Validation/SkillDeclarationValidator.php

Spacing +11 added lines, -11 removed lines

@@ -23,33 +23,33 @@ 
     public function __construct(Applicant $applicant)
     {
         $this->applicant = $applicant;
-        $this->skill_ids = Skill::all()->pluck('id');
-        $this->skill_status_ids = SkillStatus::all()->pluck('id');
-        $this->skill_level_ids = SkillLevel::all()->pluck('id');
+        $this->skill_ids = Skill::all ()->pluck ('id');
+        $this->skill_status_ids = SkillStatus::all ()->pluck ('id');
+        $this->skill_level_ids = SkillLevel::all ()->pluck ('id');
 
     }
 
-    public function validator(SkillDeclaration $skillDeclaration) {
-        $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);
+    public function validator(SkillDeclaration $skillDeclaration){
+        $uniqueSkillRule = new UniqueApplicantSkillRule ($this->applicant, $skillDeclaration->id);
 
         //Validate basic data is filled in
-        $validator = Validator::make($skillDeclaration->getAttributes(), [
+        $validator = Validator::make ($skillDeclaration->getAttributes (), [
             'skill_id' => [
                 'required',
-                Rule::in($this->skill_ids->toArray()),
+                Rule::in ($this->skill_ids->toArray ()),
                 $uniqueSkillRule,
             ],
             'applicant_id' => [
                 'required',
-                Rule::in([$this->applicant->id]),
+                Rule::in ([$this->applicant->id]),
             ],
             'skill_status_id' => [
                 'required',
-                Rule::in($this->skill_status_ids->toArray()),
+                Rule::in ($this->skill_status_ids->toArray ()),
             ],
             'skill_level_id' => [
                 'required',
-                Rule::in($this->skill_level_ids->toArray()),
+                Rule::in ($this->skill_level_ids->toArray ()),
             ],
             'description' => 'required|string',
         ]);
@@ -58,7 +58,7 @@ 
 
     public function validate(SkillDeclaration $skillDeclaration)
     {
-        return $this->validator($skillDeclaration)->validate();
+        return $this->validator ($skillDeclaration)->validate ();
     }