ApplicationController::show() - Code Metrics - Inspection of "Include some more fake data for storybook" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — feature/application-review-ui ( afbf92 )

by Chris
created 2020-08-24 14:14 UTC
ApplicationController::show() C

↳ Parent: ApplicationController
Complexity

Conditions	12
Paths	128
Size

Total Lines	100
Code Lines	69
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
eloc	69
c	0
b	0
f	0
dl	0
loc	100
rs	6.063
cc	12
nc	128
nop	1
How to fix Long Method Complexity

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Auth;
use App\Models\JobApplication;
use App\Models\JobPoster;
use App\Models\Skill;
use App\Models\Lookup\ReviewStatus;
use Facades\App\Services\WhichPortal;

class ApplicationController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $applications = Auth::user()->applicant->job_applications;
        return view(
        return /** @scrutinizer ignore-call */ view(
            'applicant/application_index',
            [
                'application_index' => Lang::get('applicant/application_index'),
                'applications' => $applications,
                'manager_profile_photo' => '/images/user.png', // TODO: get real photo.
            ]
        );
    }

    /**
     * Determine whether the user can view the jobApplication.
     *
     * @param  \App\Models\JobPoster    $jobPoster Incoming JobPoster object.
     * @param  \App\Models\JobApplication $application Incoming Application object.
     * @return \Illuminate\Http\Response
     */
    public function showWithJob(JobPoster $jobPoster, JobApplication $application)
    {
        if ($jobPoster->job_applications->contains($application)) {
            return $this->show($application);
        } else {
            return abort(404);
            return /** @scrutinizer ignore-call */ abort(404);
        }
    }

    /**
     * Display specified application
     *
     * @param  \App\Models\JobApplication $application Incoming Application object.
     * @return \Illuminate\Http\Response
     */
    public function show(JobApplication $application)
    {
        $response_poster = false;
        $show_review = true;
        $jobPoster = $application->job_poster;

        if ($jobPoster->isInStrategicResponseDepartment()) {
            $response_poster = true;
            $show_review = false;
        }

        $essential_criteria = $jobPoster->criteria->filter(function ($value, $key) {
        $essential_criteria = $jobPoster->criteria->filter(function ($value, /** @scrutinizer ignore-unused */ $key) {
            return $value->criteria_type->name == 'essential'
                && $value->skill->skill_type->name == 'hard';
        });
        $asset_criteria = $jobPoster->criteria->filter(function ($value, $key) {
        $asset_criteria = $jobPoster->criteria->filter(function ($value, /** @scrutinizer ignore-unused */ $key) {
            return $value->criteria_type->name == 'asset'
                && $value->skill->skill_type->name == 'hard';
        });

        // Display slightly different views on different portals.
        $view = WhichPortal::isManagerPortal() || WhichPortal::isHrPortal() ?
            'manager/application_post' : 'applicant/application_preview';

        $application_view = $response_poster
            ? 'applicant/strategic_response_application/application_view/application_layout'
            : 'common/application/view/view_layout';

        if (WhichPortal::isManagerPortal() || WhichPortal::isHrPortal()) {
            // Load things required for review component.
            $application->load(['veteran_status', 'citizenship_declaration', 'application_review', 'applicant.user']);
        }


        // If the application status is draft then get data through the applicant model.
        // Else, grab the data from the application itself.
        if ($application->isDraft()) {
            $source = $application->applicant;
            $show_review = false;
        } else {
            $source = $application;
        }

        $degrees = $source->degrees;
        $courses = $source->courses;
        $work_experiences = $source->work_experiences;
        $skill_declarations = $source->skill_declarations;
        $references = $source->references;
        $work_samples = $source->work_samples;

        $custom_breadcrumbs = [
            'home' => route('home'),
            'home' => /** @scrutinizer ignore-call */ route('home'),
            'applications' =>  route('applications.index'),
            'application' => '',
        ];

        if (WhichPortal::isManagerPortal() || WhichPortal::isHrPortal()) {
            $custom_breadcrumbs = [
                'home' => route('home'),
                'jobs' => route(WhichPortal::prefixRoute('jobs.index')),
                $jobPoster->title => route(WhichPortal::prefixRoute('jobs.summary'), $jobPoster),
                'applications' =>  route(WhichPortal::prefixRoute('jobs.applications'), $jobPoster),
                'application' => '',
            ];
        }

        return view(
        return /** @scrutinizer ignore-call */ view(
            $view,
            [
                'application_view_template' => $application_view,
                // Localized strings.
                'post' => Lang::get('manager/application_post'), // Change text
                'is_manager_view' => WhichPortal::isManagerPortal(),
                'is_hr_portal' => WhichPortal::isHrPortal(),
                // Application Template Data.
                'application_template' => Lang::get('applicant/application_template'),
                'citizenship_declaration_template' => Lang::get('common/citizenship_declaration'),
                'veteran_status_template' => Lang::get('common/veteran_status'),
                // Job Data.
                'job' => $jobPoster,
                // Skills Data.
                'skills' => Skill::all(),
                'skill_template' => Lang::get('common/skills'),
                'reference_template' => Lang::get('common/references'),
                'sample_template' => Lang::get('common/work_samples'),
                'essential_criteria' => $essential_criteria,
                'asset_criteria' => $asset_criteria,
                // Applicant Data.
                'applicant' => $application->applicant,
                'job_application' => $application,
                'degrees' => $degrees,
                'courses' => $courses,
                'work_experiences' => $work_experiences,
                'skill_declarations' => $skill_declarations,
                'references' => $references,
                'work_samples' => $work_samples,
                'review_statuses' => ReviewStatus::all(),
                'custom_breadcrumbs' => $custom_breadcrumbs,
                'response_poster' => $response_poster,
                'show_review' => $show_review,
            ]
        );
    }

    /**
     * Delete the particular resource from storage.
     *
     * @param  \Illuminate\Http\Request   $request     Incoming Request object.
     * @param  \App\Models\JobApplication $application Incoming Application object.
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, JobApplication $application)
    {
        $this->authorize('delete', $application);

        $application->delete();

        if ($request->ajax()) {
            return [
                'message' => 'Application deleted'
            ];
        }

        return redirect()->back();
        return /** @scrutinizer ignore-call */ redirect()->back();
    }
}

GCTC-NTGC / TalentCloud

Push — feature/application-review-ui ( afbf92 )

ApplicationController::show() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
