JobControllerTest::testManagerCreate() - Code Metrics - Inspection of "Merge dev into feature/screening-plan" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/screening-plan ( 46ccc1...3f87fd )

by Tristan

created 2019-01-04 02:00 UTC

JobControllerTest::testManagerCreate() A

↳ Parent: JobControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	58
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	44
dl	0
loc	58
rs	9.216
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace Tests\Unit;

use Tests\TestCase;
use Illuminate\Foundation\Testing\WithFaker;
use Illuminate\Support\Facades\Lang;

use App\Models\Criteria;
use App\Models\Lookup\Department;
use App\Models\JobPoster;
use App\Models\JobPosterKeyTask;
use App\Models\JobPosterQuestion;
use App\Models\Lookup\LanguageRequirement;
use App\Models\Manager;
use App\Models\Lookup\Province;
use App\Models\Lookup\SecurityClearance;

class JobControllerTest extends TestCase
{
    /**
     * Run parent setup and provide reusable factories.
     *
     * @return void
     */
    protected function setUp()
    {
        parent::setUp();

        $this->faker = \Faker\Factory::create();

        $this->faker_fr = \Faker\Factory::create('fr_FR');


        $this->manager = factory(Manager::class)->create();

        $this->jobPoster = factory(JobPoster::class)->create([

            'manager_id' => $this->manager->id
        ]);

        $this->jobPoster->criteria()->saveMany(factory(Criteria::class, 2)->make([
            'job_poster_id' => $this->jobPoster->id
        ]));
        $this->jobPoster->job_poster_key_tasks()->saveMany(factory(JobPosterKeyTask::class, 2)->make([
            'job_poster_id' => $this->jobPoster->id
        ]));
        $this->jobPoster->job_poster_questions()->saveMany(factory(JobPosterQuestion::class, 2)->make([
            'job_poster_id' => $this->jobPoster->id
        ]));

        $this->otherManager = factory(Manager::class)->create();

        $this->otherJobPoster = factory(JobPoster::class)->create([

            'manager_id' => $this->otherManager->id
        ]);
    }

    /**
     * Ensure a manager can view their index page.
     *
     * @return void
     */
    public function testManagerIndexView()
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs');
        $response->assertStatus(200);

        $response->assertSee('<h3>' . $this->jobPoster->title . '</h3>');
        $response->assertDontSee('<h3>' . $this->otherJobPoster->title . '</h3>');
    }

    /**
     * Ensure a manager can view the create Job Poster form.
     *
     * @return void
     */
    public function testManagerCreateView()
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs/create');
        $response->assertStatus(200);

        $response->assertSee('<h2 class="heading--01">' . Lang::get('manager/job_create')['title'] . '</h2>');
        $response->assertViewIs('manager.job_create');
    }

    /**
     * Ensure a manager can create a Job Poster.
     *
     * @return void
     */
    public function testManagerCreate()
    {
        $newJob = [
            'term_qty' => $this->faker->numberBetween(1, 4),
            'salary_min' => $this->faker->numberBetween(60000, 80000),
            'salary_max' => $this->faker->numberBetween(80000, 100000),
            'noc' => $this->faker->numberBetween(1, 9999),
            'classification' => $this->faker->regexify('[A-Z]{2}-0[1-5]'),
            'manager_id' => $this->manager->id,
            'published' => $this->faker->boolean(50),
            'remote_work_allowed' => $this->faker->boolean(50),
            'open_date' => $this->faker->date('Y-m-d', strtotime('+1 day')),
            'open_time' => $this->faker->time(),
            'close_date' => $this->faker->date('Y-m-d', strtotime('+2 weeks')),
            'close_time' => $this->faker->time(),
            'start_date_time' => $this->faker->date('Y-m-d', strtotime('+2 weeks')) . ' ' . $this->faker->time(),
            'security_clearance' => SecurityClearance::inRandomOrder()->first()->id,
            'language_requirement' => LanguageRequirement::inRandomOrder()->first()->id,
            'department' => Department::inRandomOrder()->first()->id,
            'province' => Province::inRandomOrder()->first()->id,
            'city' => $this->faker->city,
            'title' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'impact' => [
                'en' => $this->faker->paragraphs(
                    2,
                    true
                ),
                'fr' => $this->faker_fr->paragraphs(
                    2,
                    true
                )
            ],
            'branch' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'division' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'education' => [
                'en' => $this->faker->sentence(),
                'fr' => $this->faker_fr->sentence()
            ],
            'submit' => '',
        ];

        $dbValues = array_slice($newJob, 0, 6);

        $response = $this->followingRedirects()
            ->actingAs($this->manager->user)
            ->post('manager/jobs/', $newJob);
        $response->assertStatus(200);
        $response->assertViewIs('manager.job_index');
        $this->assertDatabaseHas('job_posters', $dbValues);
    }

    /**
     * Ensure a manager can edit an unpublished Job Poster they created.
     *
     * @return void
     */
    public function testManagerEditView()
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs/' . $this->jobPoster->id . '/edit');

        $response->assertStatus(200);
        $response->assertViewIs('manager.job_create');
        // Check for a handful of properties
        $response->assertSee($this->jobPoster->city);
        $response->assertSee($this->jobPoster->education);
        $response->assertSee($this->jobPoster->title);
        $response->assertSee($this->jobPoster->impact);
        $response->assertSee($this->jobPoster->branch);
        $response->assertSee($this->jobPoster->division);
        $response->assertSee($this->jobPoster->education);
    }
}


1			<?php
2
3			namespace Tests\Unit;
4
5			use Tests\TestCase;
6			use Illuminate\Foundation\Testing\WithFaker;
7			use Illuminate\Support\Facades\Lang;
8
9			use App\Models\Criteria;
10			use App\Models\Lookup\Department;
11			use App\Models\JobPoster;
12			use App\Models\JobPosterKeyTask;
13			use App\Models\JobPosterQuestion;
14			use App\Models\Lookup\LanguageRequirement;
15			use App\Models\Manager;
16			use App\Models\Lookup\Province;
17			use App\Models\Lookup\SecurityClearance;
18
19			class JobControllerTest extends TestCase
20			{
21			/**
22			* Run parent setup and provide reusable factories.
23			*
24			* @return void
25			*/
26			protected function setUp()
27			{
28			parent::setUp();
29
30			$this->faker = \Faker\Factory::create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `faker` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
31			$this->faker_fr = \Faker\Factory::create('fr_FR');
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `faker_fr` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
32
33			$this->manager = factory(Manager::class)->create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `manager` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
34			$this->jobPoster = factory(JobPoster::class)->create([
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `jobPoster` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
35			'manager_id' => $this->manager->id
36			]);
37
38			$this->jobPoster->criteria()->saveMany(factory(Criteria::class, 2)->make([
39			'job_poster_id' => $this->jobPoster->id
40			]));
41			$this->jobPoster->job_poster_key_tasks()->saveMany(factory(JobPosterKeyTask::class, 2)->make([
42			'job_poster_id' => $this->jobPoster->id
43			]));
44			$this->jobPoster->job_poster_questions()->saveMany(factory(JobPosterQuestion::class, 2)->make([
45			'job_poster_id' => $this->jobPoster->id
46			]));
47
48			$this->otherManager = factory(Manager::class)->create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `otherManager` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
49			$this->otherJobPoster = factory(JobPoster::class)->create([
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `otherJobPoster` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
50			'manager_id' => $this->otherManager->id
51			]);
52			}
53
54			/**
55			* Ensure a manager can view their index page.
56			*
57			* @return void
58			*/
59			public function testManagerIndexView()
60			{
61			$response = $this->actingAs($this->manager->user)
62			->get('manager/jobs');
63			$response->assertStatus(200);
64
65			$response->assertSee('<h3>' . $this->jobPoster->title . '</h3>');
66			$response->assertDontSee('<h3>' . $this->otherJobPoster->title . '</h3>');
67			}
68
69			/**
70			* Ensure a manager can view the create Job Poster form.
71			*
72			* @return void
73			*/
74			public function testManagerCreateView()
75			{
76			$response = $this->actingAs($this->manager->user)
77			->get('manager/jobs/create');
78			$response->assertStatus(200);
79
80			$response->assertSee('<h2 class="heading--01">' . Lang::get('manager/job_create')['title'] . '</h2>');
81			$response->assertViewIs('manager.job_create');
82			}
83
84			/**
85			* Ensure a manager can create a Job Poster.
86			*
87			* @return void
88			*/
89			public function testManagerCreate()
90			{
91			$newJob = [
92			'term_qty' => $this->faker->numberBetween(1, 4),
93			'salary_min' => $this->faker->numberBetween(60000, 80000),
94			'salary_max' => $this->faker->numberBetween(80000, 100000),
95			'noc' => $this->faker->numberBetween(1, 9999),
96			'classification' => $this->faker->regexify('[A-Z]{2}-0[1-5]'),
97			'manager_id' => $this->manager->id,
98			'published' => $this->faker->boolean(50),
99			'remote_work_allowed' => $this->faker->boolean(50),
100			'open_date' => $this->faker->date('Y-m-d', strtotime('+1 day')),
101			'open_time' => $this->faker->time(),
102			'close_date' => $this->faker->date('Y-m-d', strtotime('+2 weeks')),
103			'close_time' => $this->faker->time(),
104			'start_date_time' => $this->faker->date('Y-m-d', strtotime('+2 weeks')) . ' ' . $this->faker->time(),
105			'security_clearance' => SecurityClearance::inRandomOrder()->first()->id,
106			'language_requirement' => LanguageRequirement::inRandomOrder()->first()->id,
107			'department' => Department::inRandomOrder()->first()->id,
108			'province' => Province::inRandomOrder()->first()->id,
109			'city' => $this->faker->city,
110			'title' => [
111			'en' => $this->faker->word,
112			'fr' => $this->faker_fr->word
113			],
114			'impact' => [
115			'en' => $this->faker->paragraphs(
116			2,
117			true
118			),
119			'fr' => $this->faker_fr->paragraphs(
120			2,
121			true
122			)
123			],
124			'branch' => [
125			'en' => $this->faker->word,
126			'fr' => $this->faker_fr->word
127			],
128			'division' => [
129			'en' => $this->faker->word,
130			'fr' => $this->faker_fr->word
131			],
132			'education' => [
133			'en' => $this->faker->sentence(),
134			'fr' => $this->faker_fr->sentence()
135			],
136			'submit' => '',
137			];
138
139			$dbValues = array_slice($newJob, 0, 6);
140
141			$response = $this->followingRedirects()
142			->actingAs($this->manager->user)
143			->post('manager/jobs/', $newJob);
144			$response->assertStatus(200);
145			$response->assertViewIs('manager.job_index');
146			$this->assertDatabaseHas('job_posters', $dbValues);
147			}
148
149			/**
150			* Ensure a manager can edit an unpublished Job Poster they created.
151			*
152			* @return void
153			*/
154			public function testManagerEditView()
155			{
156			$response = $this->actingAs($this->manager->user)
157			->get('manager/jobs/' . $this->jobPoster->id . '/edit');
158
159			$response->assertStatus(200);
160			$response->assertViewIs('manager.job_create');
161			// Check for a handful of properties
162			$response->assertSee($this->jobPoster->city);
163			$response->assertSee($this->jobPoster->education);
164			$response->assertSee($this->jobPoster->title);
165			$response->assertSee($this->jobPoster->impact);
166			$response->assertSee($this->jobPoster->branch);
167			$response->assertSee($this->jobPoster->division);
168			$response->assertSee($this->jobPoster->education);
169			}
170			}
171

GCTC-NTGC / TalentCloud

Push — feature/screening-plan ( 46ccc1...3f87fd )

JobControllerTest::testManagerCreate() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like