FrequencyRule::__construct() - Code Metrics - Inspection of "Merge branch 'feature/redux-job-get-update' into f..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job-builder/step-01 ( f1a00d...d3a820 )

by Chris

created 2019-05-23 13:08 UTC

FrequencyRule::__construct() A

↳ Parent: FrequencyRule

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;
use App\Models\Lookup\Frequency;

/**
 * Validates that value is a valid department id
 */
class FrequencyRule implements Rule
{
    /**
     * Colaction of valid Frequency ids.
     *
     * @var Collection
     */
    protected $validIds;

    public function __construct()

    {
        $this->validIds = Frequency::all()->pluck('id');


    }


    public function passes($attribute, $value)

    {
        return $this->validIds->contains($value);

    }


    public function message()

    {
        return Lang::get('validation.invalid_id');
    }
}


1		<?php
2
3		namespace App\Services\Validation\Rules;
4
5		use Illuminate\Contracts\Validation\Rule;
6		use Illuminate\Support\Facades\Lang;
7		use App\Models\Lookup\Frequency;
8
9		/**
10		* Validates that value is a valid department id
11		*/
12		class FrequencyRule implements Rule
13		{
14		/**
15		* Colaction of valid Frequency ids.
16		*
17		* @var Collection
18		*/
19		protected $validIds;
20
21	2	public function __construct()
		1 ignored issue – show Coding Style Documentation introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Missing doc comment for function __construct() Loading history...
22		{
23	2	$this->validIds = Frequency::all()->pluck('id');
		0 ignored issues – show Documentation Bug introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report It seems like `App\Models\Lookup\Frequency::all()->pluck('id')` of type `Illuminate\Support\Collection` is incompatible with the declared type `App\Services\Validation\Rules\Collection` of property `$validIds`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
24
25	2	}
		0 ignored issues – show Coding Style introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Function closing brace must go on the next line following the body; found 1 blank lines before brace Loading history...
26
27	2	public function passes($attribute, $value)
		1 ignored issue – show introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\FrequencyRule::passes() does not have parameter type hint nor @param annotation for its parameter $attribute. Loading history... introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\FrequencyRule::passes() does not have parameter type hint nor @param annotation for its parameter $value. Loading history... introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\FrequencyRule::passes() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Missing doc comment for function passes() Loading history...
28		{
29	2	return $this->validIds->contains($value);
30
31		}
		0 ignored issues – show Coding Style introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Function closing brace must go on the next line following the body; found 1 blank lines before brace Loading history...
32
33		public function message()
		1 ignored issue – show introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\FrequencyRule::message() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Missing doc comment for function message() Loading history...
34		{
35		return Lang::get('validation.invalid_id');
36		}
37		}
38

GCTC-NTGC / TalentCloud

Push — feature/job-builder/step-01 ( f1a00d...d3a820 )

FrequencyRule::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like