DepartmentRule::message() - Code Metrics - Inspection of "Merge branch 'feature/redux-job-get-update' into f..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job-builder/step-01 ( f1a00d...d3a820 )

by Chris

created 2019-05-23 13:08 UTC

DepartmentRule::message() A

↳ Parent: DepartmentRule

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;
use App\Models\Lookup\Department;

/**
 * Validates that value is a valid department id
 */
class DepartmentRule implements Rule
{
    public function passes($attribute, $value)

    {
        return Department::where('id', $value)->exists();

    }

    public function message()

    {
        return Lang::get('validation.invalid_id');
    }
}


1		<?php
2
3		namespace App\Services\Validation\Rules;
4
5		use Illuminate\Contracts\Validation\Rule;
6		use Illuminate\Support\Facades\Lang;
7		use App\Models\Lookup\Department;
8
9		/**
10		* Validates that value is a valid department id
11		*/
12		class DepartmentRule implements Rule
13		{
14	4	public function passes($attribute, $value)
		1 ignored issue – show introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\DepartmentRule::passes() does not have parameter type hint nor @param annotation for its parameter $attribute. Loading history... introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\DepartmentRule::passes() does not have parameter type hint nor @param annotation for its parameter $value. Loading history... introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\DepartmentRule::passes() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Missing doc comment for function passes() Loading history...
15		{
16	4	return Department::where('id', $value)->exists();
		0 ignored issues – show Bug Best Practice introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report The expression `return App\Models\Lookup...'id', $value)->exists()` also could return the type `Illuminate\Database\Eloquent\Builder` which is incompatible with the return type mandated by `Illuminate\Contracts\Validation\Rule::passes()` of `boolean`. Loading history...
17		}
18
19	1	public function message()
		1 ignored issue – show introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\DepartmentRule::message() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Missing doc comment for function message() Loading history...
20		{
21	1	return Lang::get('validation.invalid_id');
22		}
23		}
24

GCTC-NTGC / TalentCloud

Push — feature/job-builder/step-01 ( f1a00d...d3a820 )

DepartmentRule::message() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like