App\Http\Controllers\SkillDeclarationController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	131
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	destroy()	0	10	2
A	editAuthenticated()	0	4	1
A	edit()	0	11	1
A	updateSkillDeclaration()	0	34	2
A	create()	0	19	1
A	update()	0	5	1

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Log;
use Illuminate\Http\Request;
use App\Models\Skill;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\SkillStatus;
use App\Models\SkillDeclaration;
use App\Models\Applicant;
use App\Http\Controllers\Controller;
use App\Services\Validation\BulkSkillDeclarationValidator;
use App\Services\Validation\SkillDeclarationValidator;

class SkillDeclarationController extends Controller
{

    /**
     * Show the form for editing the logged-in applicant's skills
     *
     * @param  Request $request

Missing parameter comment

     * @return \Illuminate\Http\RedirectResponse
     */
    public function editAuthenticated(Request $request): \Illuminate\Http\RedirectResponse
    {
        $applicant = $request->user()->applicant;
        return redirect(route('profile.skills.edit', $applicant));
    }

    /**
     * Show the form for editing the applicant's skills
     *
     * @param Request   $request   Incoming request object.
     * @param Applicant $applicant Applicant object.
     *
     * @return \Illuminate\View\View|\Illuminate\Contracts\View\Factory
     */
    public function edit(Request $request, Applicant $applicant)
    {
        $applicant->load([
            'skill_declarations.skill.skill_type',
            'skill_declarations.skill_status',
            'skill_declarations.skill_level',
        ]);

        return view('applicant/profile_03_skills', [
            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_skills'),
        ]);
    }

    /**
     * Create the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request $request

Missing parameter comment

     * @return \Illuminate\Http\Response
     */
    public function create(Request $request): \Illuminate\Http\Response
    {
        $this->authorize('create', SkillDeclaration::class);

        $user = $request->user();
        $applicant = $user->applicant;

        //Get the default claim status id
        $claimedStatusId = SkillStatus::where('name', 'claimed')->firstOrFail()->id;

        // Create a new Skill Declaration
        // But don't save, as it hasn't been validated yet
        $skillDeclaration = new SkillDeclaration();
        $skillDeclaration->applicant_id = $applicant->id;
        $skillDeclaration->skill_id = $request->input('skill_id');
        $skillDeclaration->skill_status_id = $claimedStatusId;

        //Update variable fields in skill declaration
        return $this->updateSkillDeclaration($request, $skillDeclaration);

The expression return $this->updateSkillDeclaration($request, $skillDeclaration) returns the type Illuminate\Http\RedirectResponse|string which is incompatible with the type-hinted return Illuminate\Http\Response.

    }

    /**
     * Update the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request     $request

Missing parameter comment

     * @param  \App\Models\SkillDeclaration $skillDeclaration

Missing parameter comment

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, SkillDeclaration $skillDeclaration): \Illuminate\Http\Response
    {
        $this->authorize('update', $skillDeclaration);

        return $this->updateSkillDeclaration($request, $skillDeclaration);

The expression return $this->updateSkillDeclaration($request, $skillDeclaration) returns the type Illuminate\Http\RedirectResponse|string which is incompatible with the type-hinted return Illuminate\Http\Response.

    }

    protected function updateSkillDeclaration(Request $request, SkillDeclaration $skillDeclaration)

Method \App\Http\Controllers\SkillDeclarationController::updateSkillDeclaration() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function updateSkillDeclaration()

    {
        //Fill variable values
        $skillDeclaration->fill([
            'description' => $request->input('description'),
            'skill_level_id' => $request->input('skill_level_id'),
        ]);

        //Validate before saving
        $validator = new SkillDeclarationValidator($request->user()->applicant);
        $validator->validate($skillDeclaration);

        //Save this skill declaration
        $skillDeclaration->save();

        //Attach relatives
        $referenceIds = $this->getRelativeIds($request->input(), 'references');
        $skillDeclaration->references()->sync($referenceIds);

        $sampleIds = $this->getRelativeIds($request->input(), 'samples');
        $skillDeclaration->work_samples()->sync($sampleIds);

        // $skillDeclaration->save();

        // If an ajax request, return the new object
        if ($request->ajax()) {
            $skillDeclaration->load('references');
            $skillDeclaration->load('work_samples');
            $skillDeclaration->load('skill');
            $skillDeclaration->load('skill_status');
            return $skillDeclaration->toJson();
        }

        return redirect()->back();
    }

    /**
     * Delete the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request     $request

Missing parameter comment

     * @param  \App\Models\SkillDeclaration $skillDeclaration

Missing parameter comment

     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, SkillDeclaration $skillDeclaration): \Illuminate\Http\Response
    {
        $this->authorize('delete', $skillDeclaration);
        $skillDeclaration->delete();

        if ($request->ajax()) {
            return ['message' => 'Skill deleted'];

The expression return array('message' => 'Skill deleted') returns the type array<string,string> which is incompatible with the type-hinted return Illuminate\Http\Response.

        }

        return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the type-hinted return Illuminate\Http\Response.

    }
}